Attachment 114508 Details for Bug 71423 – Patch

[patch] Patch

bug-71423-20111110082651.patch (text/plain), 4.41 KB, created by Darin Adler on 2011-11-10 08:26:52 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Darin Adler

Created: 2011-11-10 08:26:52 PST

Size: 4.41 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 99859)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2011-11-10  Darin Adler  <darin@apple.com>
>+
>+        Remove all releaseRef implementations except for RetainPtr
>+        https://bugs.webkit.org/show_bug.cgi?id=71423
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * API/JSRetainPtr.h: Removed releaseRef.
>+        * wtf/PassRefPtr.h: Removed releaseRef.
>+
> 2011-11-10  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Fix make distcheck build.
>Index: Source/JavaScriptCore/API/JSRetainPtr.h
>===================================================================
>--- Source/JavaScriptCore/API/JSRetainPtr.h	(revision 99858)
>+++ Source/JavaScriptCore/API/JSRetainPtr.h	(working copy)
>@@ -71,9 +71,6 @@ public:
>     
>     void swap(JSRetainPtr&);
> 
>-    // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
>-    T releaseRef() { return leakRef(); }
>-
> private:
>     T m_ptr;
> };
>Index: Source/JavaScriptCore/wtf/PassRefPtr.h
>===================================================================
>--- Source/JavaScriptCore/wtf/PassRefPtr.h	(revision 99858)
>+++ Source/JavaScriptCore/wtf/PassRefPtr.h	(working copy)
>@@ -92,9 +92,6 @@ namespace WTF {
> 
>         friend PassRefPtr adoptRef<T>(T*);
> 
>-        // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
>-        T* releaseRef() const WARN_UNUSED_RETURN { return leakRef(); }
>-
>     private:
>         // adopting constructor
>         PassRefPtr(T* ptr, bool) : m_ptr(ptr) { }
>@@ -155,9 +152,6 @@ namespace WTF {
> 
>         NonNullPassRefPtr& operator=(const NonNullPassRefPtr&) { COMPILE_ASSERT(!sizeof(T*), NonNullPassRefPtr_should_never_be_assigned_to); return *this; }
> 
>-        // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
>-        T* releaseRef() const WARN_UNUSED_RETURN { return leakRef(); }
>-
>     private:
>         mutable T* m_ptr;
>     };
>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 99859)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2011-11-10  Darin Adler  <darin@apple.com>
>+
>+        Remove all releaseRef implementations except for RetainPtr
>+        https://bugs.webkit.org/show_bug.cgi?id=71423
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/win/COMPtr.h: Removed releaseRef.
>+
> 2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>
> 
>         [GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
>Index: Source/WebCore/platform/win/COMPtr.h
>===================================================================
>--- Source/WebCore/platform/win/COMPtr.h	(revision 99858)
>+++ Source/WebCore/platform/win/COMPtr.h	(working copy)
>@@ -93,9 +93,6 @@ public:
>     template<typename U> HRESULT copyRefTo(U**);
>     void adoptRef(T*);
> 
>-    // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
>-    T* releaseRef() { return leakRef(); }
>-
> private:
>     static T* copyQueryInterfaceRef(IUnknown*);
>     static T* createInstance(const IID& clsid);
>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 99859)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2011-11-10  Darin Adler  <darin@apple.com>
>+
>+        Remove all releaseRef implementations except for RetainPtr
>+        https://bugs.webkit.org/show_bug.cgi?id=71423
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
>+        (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
>+
> 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
> 
>         [Qt] Fix keyboard related layout tests after API refactoring
>Index: Tools/DumpRenderTree/cf/WebArchiveDumpSupport.cpp
>===================================================================
>--- Tools/DumpRenderTree/cf/WebArchiveDumpSupport.cpp	(revision 99858)
>+++ Tools/DumpRenderTree/cf/WebArchiveDumpSupport.cpp	(working copy)
>@@ -226,5 +226,5 @@ CFStringRef createXMLStringFromWebArchiv
>     // Replace "Apple Computer" with "Apple" in the DTD declaration.
>     CFStringFindAndReplace(string.get(), CFSTR("-//Apple Computer//"), CFSTR("-//Apple//"), CFRangeMake(0, CFStringGetLength(string.get())), 0);
> 
>-    return string.releaseRef();
>+    return string.leakRef();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 71423: 114508