Attachment 103190 Details for Bug 65501 – Patch

[patch] Patch

bug-65501-20110808103625.patch (text/plain), 7.16 KB, created by James Kozianski on 2011-08-07 17:36:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: James Kozianski

Created: 2011-08-07 17:36:27 PDT

Size: 7.16 KB

patch

obsolete

>Subversion Revision: 92575
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7ce44528f4ff0808691482d53cb4010a2e006283..b1d367a46cd8bbb7422b0de5c28d44a5a9831d9f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2011-08-07  James Kozianski  <koz@chromium.org>
>+
>+        Make the fullscreen JS API enabled at runtime.
>+        https://bugs.webkit.org/show_bug.cgi?id=65501
>+
>+        Reviewed by Adam Barth.
>+
>+        * bindings/generic/RuntimeEnabledFeatures.cpp:
>+        * bindings/generic/RuntimeEnabledFeatures.h:
>+        (WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
>+        (WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
>+        (WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
>+        (WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
>+        (WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
>+        (WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
>+        (WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):
>+        * dom/Document.idl:
>+        * dom/Element.idl:
>+
> 2011-08-07  Martin Robinson  <mrobinson@igalia.com>
> 
>         Distribution fix for GTK+.
>diff --git a/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp b/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
>index dd47184ab5f1fe2fe9f1a34e7aa41061f11ad415..8bd01ccba96fa15f54b219f1025ab8eb25b7108b 100644
>--- a/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
>+++ b/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
>@@ -146,4 +146,8 @@ bool RuntimeEnabledFeatures::openDatabaseSyncEnabled()
> bool RuntimeEnabledFeatures::isQuotaEnabled = false;
> #endif
> 
>+#if ENABLE(FULLSCREEN_API)
>+bool RuntimeEnabledFeatures::isFullScreenAPIEnabled = true;
>+#endif
>+
> } // namespace WebCore
>diff --git a/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h b/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
>index 4e8436780065ef04fc3375430ccc9de4d29b403f..d7cf489aeb1ffc5457d983bf9993759bd5183a8c 100644
>--- a/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
>+++ b/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
>@@ -70,6 +70,16 @@ public:
>     static bool webkitIDBRequestEnabled() { return isIndexedDBEnabled; }
>     static bool webkitIDBTransactionEnabled() { return isIndexedDBEnabled; }
> 
>+#if ENABLE(FULLSCREEN_API)
>+    static bool webkitFullScreenAPIEnabled() { return isFullScreenAPIEnabled; }
>+    static void setWebkitFullScreenAPIEnabled(bool isEnabled) { isFullScreenAPIEnabled = isEnabled; }
>+    static bool webkitRequestFullScreenEnabled() { return isFullScreenAPIEnabled; }
>+    static bool webkitIsFullScreenEnabled() { return isFullScreenAPIEnabled; }
>+    static bool webkitFullScreenKeyboardInputAllowedEnabled() { return isFullScreenAPIEnabled; }
>+    static bool webkitCurrentFullScreenElementEnabled() { return isFullScreenAPIEnabled; }
>+    static bool webkitCancelFullScreenEnabled() { return isFullScreenAPIEnabled; }
>+#endif
>+
> #if ENABLE(VIDEO)
>     static bool audioEnabled();
>     static bool htmlMediaElementEnabled();
>@@ -192,6 +202,10 @@ private:
> #if ENABLE(QUOTA)
>     static bool isQuotaEnabled;
> #endif
>+
>+#if ENABLE(FULLSCREEN_API)
>+    static bool isFullScreenAPIEnabled;
>+#endif
> };
> 
> } // namespace WebCore
>diff --git a/Source/WebCore/dom/Document.idl b/Source/WebCore/dom/Document.idl
>index 652767fb851a1a1673edf166de0b8a8ec90f509e..5c6838ec5f5f0435118a85f6d14f2ea30901d036 100644
>--- a/Source/WebCore/dom/Document.idl
>+++ b/Source/WebCore/dom/Document.idl
>@@ -238,10 +238,10 @@ module core {
>             raises(DOMException);
> 
> #if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
>-        readonly attribute boolean webkitIsFullScreen;
>-        readonly attribute boolean webkitFullScreenKeyboardInputAllowed;
>-        readonly attribute Element webkitCurrentFullScreenElement;
>-        void webkitCancelFullScreen();
>+        readonly attribute [EnabledAtRuntime] boolean webkitIsFullScreen;
>+        readonly attribute [EnabledAtRuntime] boolean webkitFullScreenKeyboardInputAllowed;
>+        readonly attribute [EnabledAtRuntime] Element webkitCurrentFullScreenElement;
>+        [EnabledAtRuntime] void webkitCancelFullScreen();
> #endif
> 
> #if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
>diff --git a/Source/WebCore/dom/Element.idl b/Source/WebCore/dom/Element.idl
>index c728abd0a4bff12a47e41d82e5ada495451fe819..9ebb02a592f718326c16e02f1981b41d9c8890ec 100644
>--- a/Source/WebCore/dom/Element.idl
>+++ b/Source/WebCore/dom/Element.idl
>@@ -136,7 +136,7 @@ module core {
> 
> #if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
>         const unsigned short ALLOW_KEYBOARD_INPUT = 1;
>-        void webkitRequestFullScreen(in [Optional=CallWithDefaultValue] unsigned short flags);
>+        [EnabledAtRuntime] void webkitRequestFullScreen(in [Optional=CallWithDefaultValue] unsigned short flags);
> #endif
> 
> #if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
>diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog
>index 63ac1324a0bf64b2ee4d29ef7ad915a261160656..8c6c67517670628d7dfb7bfc4397ab50558f1912 100644
>--- a/Source/WebKit/chromium/ChangeLog
>+++ b/Source/WebKit/chromium/ChangeLog
>@@ -1,3 +1,15 @@
>+2011-08-07  James Kozianski  <koz@chromium.org>
>+
>+        Make the fullscreen JS API enabled at runtime.
>+        https://bugs.webkit.org/show_bug.cgi?id=65501
>+
>+        Reviewed by Adam Barth.
>+
>+        * public/WebRuntimeFeatures.h:
>+        * src/WebRuntimeFeatures.cpp:
>+        (WebKit::WebRuntimeFeatures::enableFullScreenAPI):
>+        (WebKit::WebRuntimeFeatures::isFullScreenAPIEnabled):
>+
> 2011-08-05  James Robinson  <jamesr@chromium.org>
> 
>         [chromium] Accelerated canvas breaks when moving canvases or resources between Pages
>diff --git a/Source/WebKit/chromium/public/WebRuntimeFeatures.h b/Source/WebKit/chromium/public/WebRuntimeFeatures.h
>index 2413e2f6c776582d2d384f6ee127741266739052..a3082cc041e2b546d676afafcc344dfe5ef4abd1 100644
>--- a/Source/WebKit/chromium/public/WebRuntimeFeatures.h
>+++ b/Source/WebKit/chromium/public/WebRuntimeFeatures.h
>@@ -106,6 +106,9 @@ public:
>     WEBKIT_EXPORT static void enableMediaStream(bool);
>     WEBKIT_EXPORT static bool isMediaStreamEnabled();
> 
>+    WEBKIT_EXPORT static void enableFullScreenAPI(bool);
>+    WEBKIT_EXPORT static bool isFullScreenAPIEnabled();
>+
> private:
>     WebRuntimeFeatures();
> };
>diff --git a/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp b/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp
>index a5b6a2fccb03fc5e522a9986b495717bd0a84ab0..8a629c0e6b18825720ead746cfb133f7374ca4d6 100644
>--- a/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp
>+++ b/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp
>@@ -356,4 +356,22 @@ bool WebRuntimeFeatures::isMediaStreamEnabled()
> #endif
> }
> 
>+void WebRuntimeFeatures::enableFullScreenAPI(bool enable)
>+{
>+#if ENABLE(FULLSCREEN_API)
>+    RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled(enable);
>+#else
>+    UNUSED_PARAM(enable);
>+#endif
>+}
>+
>+bool WebRuntimeFeatures::isFullScreenAPIEnabled()
>+{
>+#if ENABLE(FULLSCREEN_API)
>+    return RuntimeEnabledFeatures::webkitFullScreenAPIEnabled();
>+#else
>+    return false;
>+#endif
>+}
>+
> } // namespace WebKit

Actions: View | Formatted Diff | Diff

Attachments on bug 65501: 102599 | 102603 | 102617 | 102618 | 103189 | 103190