Attachment #79483 for bug #52745

View Details Raw Unified Return to Bug 52745



2011-01-19  Adam Barth  <abarth@webkit.org>

        Reviewed by NOBODY (OOPS!).

        Chromium builders don't delete unversioned directories when DEPS change
        https://bugs.webkit.org/show_bug.cgi?id=52745

        If we pass this option to gclient sync, gclient will delete directories
        that are no longer part of DEPS instead of leaving them around to
        confuse us later.  Apparently, the downstream buildbots use this option
        already.

        * Scripts/update-webkit-chromium:

2011-01-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

Lines 65-68 GetOptions( Tools/Scripts/update-webkit-chromium_sec1
- Tools/Scripts/update-webkit-chromium +1 lines
65	print "Updating chromium port dependencies using gclient...\n";	65	print "Updating chromium port dependencies using gclient...\n";
66	my @gclientArgs = ($gclientPath, "sync");	66	my @gclientArgs = ($gclientPath, "sync");
67	push @gclientArgs, "--force" if $force;	67	push @gclientArgs, "--force" if $force;
		68	push @gclientArgs, "--delete_unversioned_trees" if $force;
68	system(@gclientArgs) == 0 or die $!;	69	system(@gclientArgs) == 0 or die $!;

Return to Bug 52745

Lines 1-3 Tools/ChangeLog_sec1
- Tools/ChangeLog +14 lines
		1	2011-01-19 Adam Barth <abarth@webkit.org>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Chromium builders don't delete unversioned directories when DEPS change
		6	https://bugs.webkit.org/show_bug.cgi?id=52745
		7
		8	If we pass this option to gclient sync, gclient will delete directories
		9	that are no longer part of DEPS instead of leaving them around to
		10	confuse us later. Apparently, the downstream buildbots use this option
		11	already.
		12
		13	* Scripts/update-webkit-chromium:
		14
1	2011-01-19 Dirk Pranke <dpranke@chromium.org>	15	2011-01-19 Dirk Pranke <dpranke@chromium.org>
2		16
3	Reviewed by Ojan Vafai.	17	Reviewed by Ojan Vafai.