Attachment #65230 for bug #44497

View Details Raw Unified Return to Bug 44497

| Differences between



2010-08-23  Krzysztof Czech  <k.czech@samsung.com>

        Reviewed by NOBODY (OOPS!).

        [EFL] Crash while calling PopupMenuEfl destructor
        https://bugs.webkit.org/show_bug.cgi?id=44497

        Condition checks if m_view is defined
        before popup is hide

        * platform/efl/PopupMenuEfl.cpp:
        (WebCore::PopupMenuEfl::~PopupMenuEfl):

2010-08-19  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.



{
    // Tell client to destroy data related to this popup since this object is
    // going away.
    if (m_view)
        hide();
}

void PopupMenuEfl::show(const IntRect& rect, FrameView* view, int index)

Return to Bug 44497

Lines 1-3 a/WebCore/ChangeLog_sec1
- a/WebCore/ChangeLog +13 lines
		1	2010-08-23 Krzysztof Czech <k.czech@samsung.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	[EFL] Crash while calling PopupMenuEfl destructor
		6	https://bugs.webkit.org/show_bug.cgi?id=44497
		7
		8	Condition checks if m_view is defined
		9	before popup is hide
		10
		11	* platform/efl/PopupMenuEfl.cpp:
		12	(WebCore::PopupMenuEfl::~PopupMenuEfl):
		13
1	2010-08-19 Andreas Kling <andreas.kling@nokia.com>	14	2010-08-19 Andreas Kling <andreas.kling@nokia.com>
2		15
3	Reviewed by Kenneth Rohde Christiansen.	16	Reviewed by Kenneth Rohde Christiansen.

Lines 43-49 PopupMenuEfl::~PopupMenuEfl() a/WebCore/platform/efl/PopupMenuEfl.cpp_sec1
- a/WebCore/platform/efl/PopupMenuEfl.cpp -1 / +2 lines
43	{	43	{
44	// Tell client to destroy data related to this popup since this object is	44	// Tell client to destroy data related to this popup since this object is
45	// going away.	45	// going away.
46	hide();	46	if (m_view)
		47	hide();
47	}	48	}
48		49
49	void PopupMenuEfl::show(const IntRect& rect, FrameView* view, int index)	50	void PopupMenuEfl::show(const IntRect& rect, FrameView* view, int index)