Attachment #63341 for bug #43429

View Details Raw Unified Return to Bug 43429



2010-08-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by NOBODY (OOPS!).

        [GTK] Does not paint the node highlight used by the inspector
        https://bugs.webkit.org/show_bug.cgi?id=43429

        Implement highlighting the nodes when using the inspector.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::highlight):
        (WebKit::InspectorClient::hideHighlight):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_expose_event):

2010-07-26  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.



    m_frontendPage = 0;
}

void InspectorClient::highlight(Node*)
{
    hideHighlight();
}

void InspectorClient::hideHighlight()
{
    // FIXME: we should be able to only invalidate the actual rects of
    // the new and old nodes. We need to track the nodes, and take the
    // actual highlight size into account when calculating the damage
    // rect.
    gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView));
}

void InspectorClient::populateSetting(const String& key, String* value)

Lines 548-553 static gboolean webkit_web_view_expose_event(GtkWidget* widget, GdkEventExpose* a/WebKit/gtk/webkit/webkitwebview.cpp_sec1
- a/WebKit/gtk/webkit/webkitwebview.cpp -1 / +5 lines
548	ctx.restore();	548	ctx.restore();
549	}	549	}
550	}	550	}
		551
		552	ctx.save();
		553	ctx.clip(static_cast<IntRect>(event->area));
		554	frame->page()->inspectorController()->drawNodeHighlight(ctx);
		555	ctx.restore();
551	}	556	}
552		557
553	return FALSE;	558	return FALSE;
554	-

Return to Bug 43429

Lines 101-114 void InspectorClient::releaseFrontendPage() a/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp_sec1
- a/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp -3 / +7 lines
101	m_frontendPage = 0;	101	m_frontendPage = 0;
102	}	102	}
103		103
104	void InspectorClient::highlight(Node* node)	104	void InspectorClient::highlight(Node*)
105	{	105	{
106	notImplemented();	106	hideHighlight();
107	}	107	}
108		108
109	void InspectorClient::hideHighlight()	109	void InspectorClient::hideHighlight()
110	{	110	{
111	notImplemented();	111	// FIXME: we should be able to only invalidate the actual rects of
		112	// the new and old nodes. We need to track the nodes, and take the
		113	// actual highlight size into account when calculating the damage
		114	// rect.
		115	gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView));
112	}	116	}
113		117
114	void InspectorClient::populateSetting(const String& key, String* value)	118	void InspectorClient::populateSetting(const String& key, String* value)

Lines 1-3 a/WebKit/gtk/ChangeLog_sec1
- a/WebKit/gtk/ChangeLog +15 lines
		1	2010-08-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	[GTK] Does not paint the node highlight used by the inspector
		6	https://bugs.webkit.org/show_bug.cgi?id=43429
		7
		8	Implement highlighting the nodes when using the inspector.
		9
		10	* WebCoreSupport/InspectorClientGtk.cpp:
		11	(WebKit::InspectorClient::highlight):
		12	(WebKit::InspectorClient::hideHighlight):
		13	* webkit/webkitwebview.cpp:
		14	(webkit_web_view_expose_event):
		15
1	2010-07-26 Steve Block <steveblock@google.com>	16	2010-07-26 Steve Block <steveblock@google.com>
2		17
3	Reviewed by Jeremy Orlow.	18	Reviewed by Jeremy Orlow.