View Details Raw Unified Return to Bug 42172
| Differences between
and this patch
Collapse All Expand All
- ChangeLog +9 lines
Lines 1-3 ChangeLog_sec1
1 
2010-07-13  Scott Violet  <sky@chromium.org>
2 

            

            

              3
              
        Reviewed by NOBODY (OOPS!).

            

            

              4
              

            

            

              5
              
        [Chromium] Makes pressing tab accept the currently selected item in a popup.

            

            

              6
              
        https://bugs.webkit.org/show_bug.cgi?id=42172

            

            

              7
              

            

            

              8
              
        * WebCore/platform/chromium/PopupMenuChromium.cpp:

            

            

              9
              

            

        

          1
          
2010-07-12  Xan Lopez  <xlopez@igalia.com>

          10
          
2010-07-12  Xan Lopez  <xlopez@igalia.com>

        

        

          2
          

          11
          

        

        

          3
          
        Reviewed by Gustavo Noronha.

          12
          
        Reviewed by Gustavo Noronha.

        



-
  WebCore/platform/chromium/PopupMenuChromium.cpp
    
      -2 / +5 lines
    




  

    
      
            Lines 751-758
      
      bool PopupListBox::handleKeyEvent(const 
      
        WebCore/platform/chromium/PopupMenuChromium.cpp_sec1
      
    
  

        

          751
          
    if (event.windowsVirtualKeyCode() == VKEY_TAB) {

          751
          
    if (event.windowsVirtualKeyCode() == VKEY_TAB) {

        

        

          752
          
        // TAB is a special case as it should select the current item if any and

          752
          
        // TAB is a special case as it should select the current item if any and

        

        

          753
          
        // advance focus.

          753
          
        // advance focus.

        

          
            

              754
              
        if (m_selectedIndex >= 0)


              754
              
        if (m_selectedIndex >= 0) {

            

            

              755
              
            m_popupClient->setTextFromItem(m_selectedIndex);


              755
              
            acceptIndex(m_selectedIndex);  // may delete us.

            

            

              
              

              756
              
            // Return false so the TAB key event is propagated to the page.

            

            


              757
              
            return false;

            

            


              758
              
        }

            

        

          756
          
        // Call abandon() so we honor m_acceptedIndexOnAbandon if set.

          759
          
        // Call abandon() so we honor m_acceptedIndexOnAbandon if set.

        

        

          757
          
        abandon();

          760
          
        abandon();

        

        

          758
          
        // Return false so the TAB key event is propagated to the page.

          761
          
        // Return false so the TAB key event is propagated to the page.

        






  

  Return to Bug 42172