Attachment #387295 for bug #206021

View Details Raw Unified Return to Bug 206021

| Differences between



2020-01-09  Brent Fulgham  <bfulgham@apple.com>

        Remove com.apple.locationd.registration from the WebContent sandbox
        https://bugs.webkit.org/show_bug.cgi?id=206021
        <rdar://problem/58451384>

        Reviewed by NOBODY (OOPS!).

        Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove
        the blanket allow rule from the sandbox.

        Test: fast/sandbox/ios/sandbox-mach-lookup.html

        * Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

2020-01-09  Simon Fraser  <simon.fraser@apple.com>

        Clean up -[WKWebView _initializeWithConfiguration:]



            (iokit-user-client-class "AppleKeyStoreUserClient")))

(define-once (location-services)
    (allow mach-lookup
           (global-name "com.apple.locationd.registration"))
    (allow-carrier-bundle) ;; <rdar://problem/21192365>
    (mobile-preferences-read
        "com.apple.AppSupport"



            (iokit-user-client-class "AppleKeyStoreUserClient")))

(define-once (location-services)
    (allow mach-lookup (with report) (with telemetry)
           (global-name "com.apple.locationd.registration"))
    (allow-carrier-bundle) ;; <rdar://problem/21192365>
    (mobile-preferences-read
        "com.apple.AppSupport"



2020-01-09  Brent Fulgham  <bfulgham@apple.com>

        Remove com.apple.locationd.registration from the WebContent sandbox
        https://bugs.webkit.org/show_bug.cgi?id=206021
        <rdar://problem/58451384>

        Reviewed by NOBODY (OOPS!).

        Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove
        the blanket allow rule from the sandbox.

        * fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
        * fast/sandbox/ios/sandbox-mach-lookup.html:

2020-01-09  Brent Fulgham  <bfulgham@apple.com>

        REGRESSION (r253662): Large Data URLs are not being handled properly

Lines 6-11 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE a/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt_sec1
- a/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt +1 lines
6	PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.apple-extension-service") is false	6	PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.apple-extension-service") is false
7	PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.viewservice") is false	7	PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.viewservice") is false
8	PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.TextInput") is false	8	PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.TextInput") is false
		9	PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.locationd.registration") is false
9	PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.pluginkit.pkd") is false	10	PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.pluginkit.pkd") is false
10	PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.system.logger") is false	11	PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.system.logger") is false
11		12

Lines 9-14 if (window.internals) { a/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html_sec1
- a/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html +1 lines
9	shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.apple-extension-service\")");	9	shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.apple-extension-service\")");
10	shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.viewservice\")");	10	shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.viewservice\")");
11	shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.TextInput\")");	11	shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.TextInput\")");
		12	shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.locationd.registration\")");
12	shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.pluginkit.pkd\")");	13	shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.pluginkit.pkd\")");
13	shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.system.logger\")");	14	shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.system.logger\")");
14	}	15	}

Return to Bug 206021

Lines 112-119 a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb_sec1
- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb -2 lines
112	(iokit-user-client-class "AppleKeyStoreUserClient")))	112	(iokit-user-client-class "AppleKeyStoreUserClient")))
113		113
114	(define-once (location-services)	114	(define-once (location-services)
115	(allow mach-lookup
116	(global-name "com.apple.locationd.registration"))
117	(allow-carrier-bundle) ;; <rdar://problem/21192365>	115	(allow-carrier-bundle) ;; <rdar://problem/21192365>
118	(mobile-preferences-read	116	(mobile-preferences-read
119	"com.apple.AppSupport"	117	"com.apple.AppSupport"

Lines 125-132 a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb_sec1
- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb -2 lines
125	(iokit-user-client-class "AppleKeyStoreUserClient")))	125	(iokit-user-client-class "AppleKeyStoreUserClient")))
126		126
127	(define-once (location-services)	127	(define-once (location-services)
128	(allow mach-lookup (with report) (with telemetry)
129	(global-name "com.apple.locationd.registration"))
130	(allow-carrier-bundle) ;; <rdar://problem/21192365>	128	(allow-carrier-bundle) ;; <rdar://problem/21192365>
131	(mobile-preferences-read	129	(mobile-preferences-read
132	"com.apple.AppSupport"	130	"com.apple.AppSupport"

Lines 1-3 a/Source/WebKit/ChangeLog_sec1
- a/Source/WebKit/ChangeLog +16 lines
		1	2020-01-09 Brent Fulgham <bfulgham@apple.com>
		2
		3	Remove com.apple.locationd.registration from the WebContent sandbox
		4	https://bugs.webkit.org/show_bug.cgi?id=206021
		5	<rdar://problem/58451384>
		6
		7	Reviewed by NOBODY (OOPS!).
		8
		9	Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove
		10	the blanket allow rule from the sandbox.
		11
		12	Test: fast/sandbox/ios/sandbox-mach-lookup.html
		13
		14	* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
		15	* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
		16
1	2020-01-09 Simon Fraser <simon.fraser@apple.com>	17	2020-01-09 Simon Fraser <simon.fraser@apple.com>
2		18
3	Clean up -[WKWebView _initializeWithConfiguration:]	19	Clean up -[WKWebView _initializeWithConfiguration:]

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +14 lines
		1	2020-01-09 Brent Fulgham <bfulgham@apple.com>
		2
		3	Remove com.apple.locationd.registration from the WebContent sandbox
		4	https://bugs.webkit.org/show_bug.cgi?id=206021
		5	<rdar://problem/58451384>
		6
		7	Reviewed by NOBODY (OOPS!).
		8
		9	Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove
		10	the blanket allow rule from the sandbox.
		11
		12	* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
		13	* fast/sandbox/ios/sandbox-mach-lookup.html:
		14
1	2020-01-09 Brent Fulgham <bfulgham@apple.com>	15	2020-01-09 Brent Fulgham <bfulgham@apple.com>
2		16
3	REGRESSION (r253662): Large Data URLs are not being handled properly	17	REGRESSION (r253662): Large Data URLs are not being handled properly