Attachment #375616 for bug #200466

View Details Raw Unified Return to Bug 200466



2019-08-06  Antti Koivisto  <antti@apple.com>

        REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
        https://bugs.webkit.org/show_bug.cgi?id=200466

        Reviewed by NOBODY (OOPS!).

        The page calls preventDefault() for a mouse event generated by a site specific quirk.

        * page/Quirks.cpp:
        (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

        Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.

2019-08-05  Zalan Bujtas  <zalan@apple.com>

        [LFC] Remove out-of-flow descendants from Container



        return true;
    if (equalLettersIgnoringASCIICase(host, "naver.com"))
        return true;
    if (host.endsWithIgnoringASCIICase(".naver.com")) {
        // Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
        if (equalLettersIgnoringASCIICase(host, "tv.naver.com"))
            return false;
        // Disable the quirk on the mobile site.
        // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.
        if (equalLettersIgnoringASCIICase(host, "m.naver.com"))
            return false;
        return true;
    }
    return false;
}


Return to Bug 200466

Lines 295-303 bool Quirks::shouldDispatchSimulatedMous Source/WebCore/page/Quirks.cpp_sec1
- Source/WebCore/page/Quirks.cpp -3 / +10 lines
295	return true;	295	return true;
296	if (equalLettersIgnoringASCIICase(host, "naver.com"))	296	if (equalLettersIgnoringASCIICase(host, "naver.com"))
297	return true;	297	return true;
298	// Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.	298	if (host.endsWithIgnoringASCIICase(".naver.com")) {
299	if (host.endsWithIgnoringASCIICase(".naver.com"))	299	// Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
300	return !equalLettersIgnoringASCIICase(host, "tv.naver.com");	300	if (equalLettersIgnoringASCIICase(host, "tv.naver.com"))
		301	return false;
		302	// Disable the quirk on the mobile site.
		303	// FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.
		304	if (equalLettersIgnoringASCIICase(host, "m.naver.com"))
		305	return false;
		306	return true;
		307	}
301	return false;	308	return false;
302	}	309	}
303		310

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +14 lines
		1	2019-08-06 Antti Koivisto <antti@apple.com>
		2
		3	REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
		4	https://bugs.webkit.org/show_bug.cgi?id=200466
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	The page calls preventDefault() for a mouse event generated by a site specific quirk.
		9
		10	* page/Quirks.cpp:
		11	(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
		12
		13	Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.
		14
1	2019-08-05 Zalan Bujtas <zalan@apple.com>	15	2019-08-05 Zalan Bujtas <zalan@apple.com>
2		16
3	[LFC] Remove out-of-flow descendants from Container	17	[LFC] Remove out-of-flow descendants from Container