|
Lines 1-3
a/Source/WebCore/ChangeLog_sec1
|
|
|
1 |
2019-03-26 Said Abou-Hallawa <said@apple.com> |
| 2 |
|
| 3 |
Remove the SVG tear off objects for SVGLength, SVGLengthList and SVGAnimatedLengthList |
| 4 |
https://bugs.webkit.org/show_bug.cgi?id=196083 |
| 5 |
|
| 6 |
Reviewed by Simon Fraser. |
| 7 |
|
| 8 |
-- SVGLength will be a superclass of SVGValueProperty<SVGLengthValue>. It |
| 9 |
is a wrapper of SVGLengthValue. It will be provide the DOM methods. It |
| 10 |
can setValueAsString() and return valueAsString(). |
| 11 |
|
| 12 |
-- SVGLengthList will be a superclass of SVGValuePropertyList<SVGLength>. |
| 13 |
The base class will provide all the DOM methods. SVGLengthList will be |
| 14 |
responsible for parsing a String to a SVGLength items. It can also |
| 15 |
build a string representing the stored items. |
| 16 |
|
| 17 |
-- SVGAnimatedLengthList will be defined as SVGAnimatedPropertyList<SVGLengthList>. |
| 18 |
Like SVGAnimatedPointList, all the required methods and attributes |
| 19 |
will be handled by SVGAnimatedPropertyList. |
| 20 |
|
| 21 |
-- SVGAnimatedLengthAccessor and SVGAnimatedLengthListAccessor will be |
| 22 |
added to access the members of types SVGAnimatedLength and |
| 23 |
SVGAnimatedLengthList. |
| 24 |
|
| 25 |
-- SVGAnimatedLengthAnimator and SVGAnimatedLengthListAnimator will be |
| 26 |
created by the the new accessors to animate attributes of types |
| 27 |
SVGAnimatedLength and SVGAnimatedLengthList. |
| 28 |
|
| 29 |
-- SVGAnimationLengthFunction and SVGAnimationLengthListFunction will be |
| 30 |
responsible for progressing the animVal() of attributes of types |
| 31 |
SVGAnimatedLength and SVGAnimatedLengthList. |
| 32 |
|
| 33 |
-- SVGValuePropertyAnimator is a new template class which can animate a |
| 34 |
none reflecting attribute which should be backed by a value property, |
| 35 |
e.g. SVGLength. |
| 36 |
|
| 37 |
-- SVGValuePropertyListAnimator is a new template class which can animate a |
| 38 |
none reflecting attribute which should be backed by a value property |
| 39 |
list, e.g. SVGLengthList. |
| 40 |
|
| 41 |
Notes: |
| 42 |
|
| 43 |
-- SVGElement::isAnimatedStyleAttribute() will return true if the |
| 44 |
attribute is known by SVGPropertyAnimatorFactory. Or it's has |
| 45 |
a reflecting SVGAnimatedPropertyLength property and its name is |
| 46 |
one of the names listed in isAnimatedStylePropertyAttribute() of |
| 47 |
the propertyRegistry() of the SVGElement. |
| 48 |
|
| 49 |
-- SVGElement::commitPropertyChange() has to handle the attributes |
| 50 |
for which isAnimatedStylePropertyAttribute() returns true different |
| 51 |
from the other ones. styleReclac() needs updated attributes since |
| 52 |
it does not access the reflecting properties in the SVGELement. |
| 53 |
|
| 54 |
-- SVGTextContentElement does not need a customized SVGAnimatedLength. |
| 55 |
All SVGTextContentElement::textLengthAnimated() needs to know is |
| 56 |
whether m_textLength->baseVal() holds an empty SVGLength. If it |
| 57 |
does, it sets its value to getComputedTextLength(). |
| 58 |
|
| 59 |
* Sources.txt: |
| 60 |
* WebCore.xcodeproj/project.pbxproj: |
| 61 |
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp: |
| 62 |
(WebCore::updateCharacterData): |
| 63 |
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap): |
| 64 |
* svg/SVGAnimateElementBase.cpp: |
| 65 |
(WebCore::SVGAnimateElementBase::hasValidAttributeType const): |
| 66 |
* svg/SVGAnimatedLength.cpp: Removed. |
| 67 |
* svg/SVGAnimatedLength.h: Removed. |
| 68 |
* svg/SVGAnimatedLengthList.cpp: Removed. |
| 69 |
* svg/SVGAnimatedLengthList.h: Removed. |
| 70 |
* svg/SVGAnimatedType.h: |
| 71 |
(WebCore::SVGAnimatedType::type const): |
| 72 |
* svg/SVGAnimationElement.cpp: |
| 73 |
(WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): |
| 74 |
(WebCore::inheritsFromProperty): |
| 75 |
* svg/SVGAnimatorFactory.h: |
| 76 |
(WebCore::SVGAnimatorFactory::isSupportedAttribute): |
| 77 |
(WebCore::SVGAnimatorFactory::create): |
| 78 |
These changes were required because some of the tests were trying to |
| 79 |
animated unsupported attributes. To differentiate between between the |
| 80 |
these two cases: |
| 81 |
1) the attribute is animate-able by the legacy controller. |
| 82 |
2) animating the attribute or the attribute itself is not supported |
| 83 |
by the element. |
| 84 |
|
| 85 |
We want SVGAnimatorFactory tell us whether it can create an animator for |
| 86 |
a given attribute or not. |
| 87 |
|
| 88 |
* svg/SVGCircleElement.cpp: |
| 89 |
(WebCore::SVGCircleElement::SVGCircleElement): |
| 90 |
(WebCore::SVGCircleElement::parseAttribute): |
| 91 |
(WebCore::SVGCircleElement::svgAttributeChanged): |
| 92 |
(WebCore::SVGCircleElement::registerAttributes): Deleted. |
| 93 |
* svg/SVGCircleElement.h: |
| 94 |
* svg/SVGCursorElement.cpp: |
| 95 |
(WebCore::SVGCursorElement::SVGCursorElement): |
| 96 |
(WebCore::SVGCursorElement::parseAttribute): |
| 97 |
(WebCore::SVGCursorElement::svgAttributeChanged): |
| 98 |
(WebCore::SVGCursorElement::registerAttributes): Deleted. |
| 99 |
* svg/SVGCursorElement.h: |
| 100 |
* svg/SVGElement.cpp: |
| 101 |
(WebCore::SVGElement::commitPropertyChange): |
| 102 |
(WebCore::SVGElement::isAnimatedStyleAttribute const): |
| 103 |
* svg/SVGElement.h: |
| 104 |
* svg/SVGEllipseElement.cpp: |
| 105 |
(WebCore::SVGEllipseElement::SVGEllipseElement): |
| 106 |
(WebCore::SVGEllipseElement::parseAttribute): |
| 107 |
(WebCore::SVGEllipseElement::svgAttributeChanged): |
| 108 |
(WebCore::SVGEllipseElement::registerAttributes): Deleted. |
| 109 |
* svg/SVGEllipseElement.h: |
| 110 |
* svg/SVGFilterElement.cpp: |
| 111 |
(WebCore::SVGFilterElement::SVGFilterElement): |
| 112 |
(WebCore::SVGFilterElement::registerAttributes): |
| 113 |
(WebCore::SVGFilterElement::parseAttribute): |
| 114 |
* svg/SVGFilterElement.h: |
| 115 |
* svg/SVGFilterPrimitiveStandardAttributes.cpp: |
| 116 |
(WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes): |
| 117 |
(WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute): |
| 118 |
(WebCore::SVGFilterPrimitiveStandardAttributes::registerAttributes): Deleted. |
| 119 |
* svg/SVGFilterPrimitiveStandardAttributes.h: |
| 120 |
(WebCore::SVGFilterPrimitiveStandardAttributes::x const): |
| 121 |
(WebCore::SVGFilterPrimitiveStandardAttributes::y const): |
| 122 |
(WebCore::SVGFilterPrimitiveStandardAttributes::width const): |
| 123 |
(WebCore::SVGFilterPrimitiveStandardAttributes::height const): |
| 124 |
(WebCore::SVGFilterPrimitiveStandardAttributes::xAnimated): |
| 125 |
(WebCore::SVGFilterPrimitiveStandardAttributes::yAnimated): |
| 126 |
(WebCore::SVGFilterPrimitiveStandardAttributes::widthAnimated): |
| 127 |
(WebCore::SVGFilterPrimitiveStandardAttributes::heightAnimated): |
| 128 |
(WebCore::SVGFilterPrimitiveStandardAttributes::isKnownAttribute): Deleted. |
| 129 |
* svg/SVGForeignObjectElement.cpp: |
| 130 |
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement): |
| 131 |
(WebCore::SVGForeignObjectElement::parseAttribute): |
| 132 |
(WebCore::SVGForeignObjectElement::registerAttributes): Deleted. |
| 133 |
* svg/SVGForeignObjectElement.h: |
| 134 |
* svg/SVGImageElement.cpp: |
| 135 |
(WebCore::SVGImageElement::SVGImageElement): |
| 136 |
(WebCore::SVGImageElement::parseAttribute): |
| 137 |
(WebCore::SVGImageElement::registerAttributes): Deleted. |
| 138 |
* svg/SVGImageElement.h: |
| 139 |
* svg/SVGLength.h: |
| 140 |
(WebCore::SVGLength::create): |
| 141 |
(WebCore::SVGLength::clone const): |
| 142 |
(WebCore::SVGLength::unitType): |
| 143 |
(WebCore::SVGLength::valueForBindings): |
| 144 |
(WebCore::SVGLength::setValueForBindings): |
| 145 |
(WebCore::SVGLength::valueInSpecifiedUnits): |
| 146 |
(WebCore::SVGLength::setValueInSpecifiedUnits): |
| 147 |
(WebCore::SVGLength::setValueAsString): |
| 148 |
(WebCore::SVGLength::newValueSpecifiedUnits): |
| 149 |
(WebCore::SVGLength::convertToSpecifiedUnits): |
| 150 |
(WebCore::SVGLength::valueAsString): Deleted. |
| 151 |
(WebCore::SVGLength::SVGLength): Deleted. |
| 152 |
* svg/SVGLengthList.h: |
| 153 |
(WebCore::SVGLengthList::create): |
| 154 |
(WebCore::SVGLengthList::lengthMode const): |
| 155 |
(WebCore::SVGLengthList::parse): |
| 156 |
(WebCore::SVGLengthList::SVGLengthList): |
| 157 |
* svg/SVGLengthListValues.cpp: Removed. |
| 158 |
* svg/SVGLengthListValues.h: Removed. |
| 159 |
* svg/SVGLineElement.cpp: |
| 160 |
(WebCore::SVGLineElement::SVGLineElement): |
| 161 |
(WebCore::SVGLineElement::parseAttribute): |
| 162 |
(WebCore::SVGLineElement::svgAttributeChanged): |
| 163 |
(WebCore::SVGLineElement::registerAttributes): Deleted. |
| 164 |
* svg/SVGLineElement.h: |
| 165 |
* svg/SVGLinearGradientElement.cpp: |
| 166 |
(WebCore::SVGLinearGradientElement::SVGLinearGradientElement): |
| 167 |
(WebCore::SVGLinearGradientElement::parseAttribute): |
| 168 |
(WebCore::SVGLinearGradientElement::svgAttributeChanged): |
| 169 |
(WebCore::SVGLinearGradientElement::registerAttributes): Deleted. |
| 170 |
* svg/SVGLinearGradientElement.h: |
| 171 |
* svg/SVGMarkerElement.cpp: |
| 172 |
(WebCore::SVGMarkerElement::SVGMarkerElement): |
| 173 |
(WebCore::SVGMarkerElement::registerAttributes): |
| 174 |
(WebCore::SVGMarkerElement::parseAttribute): |
| 175 |
* svg/SVGMarkerElement.h: |
| 176 |
* svg/SVGMaskElement.cpp: |
| 177 |
(WebCore::SVGMaskElement::SVGMaskElement): |
| 178 |
(WebCore::SVGMaskElement::registerAttributes): |
| 179 |
(WebCore::SVGMaskElement::parseAttribute): |
| 180 |
(WebCore::SVGMaskElement::svgAttributeChanged): |
| 181 |
* svg/SVGMaskElement.h: |
| 182 |
* svg/SVGPatternElement.cpp: |
| 183 |
(WebCore::SVGPatternElement::SVGPatternElement): |
| 184 |
(WebCore::SVGPatternElement::registerAttributes): |
| 185 |
(WebCore::SVGPatternElement::parseAttribute): |
| 186 |
* svg/SVGPatternElement.h: |
| 187 |
* svg/SVGPoint.h: |
| 188 |
* svg/SVGRadialGradientElement.cpp: |
| 189 |
(WebCore::SVGRadialGradientElement::SVGRadialGradientElement): |
| 190 |
(WebCore::SVGRadialGradientElement::parseAttribute): |
| 191 |
(WebCore::SVGRadialGradientElement::svgAttributeChanged): |
| 192 |
(WebCore::SVGRadialGradientElement::registerAttributes): Deleted. |
| 193 |
* svg/SVGRadialGradientElement.h: |
| 194 |
* svg/SVGRectElement.cpp: |
| 195 |
(WebCore::SVGRectElement::SVGRectElement): |
| 196 |
(WebCore::SVGRectElement::parseAttribute): |
| 197 |
(WebCore::SVGRectElement::svgAttributeChanged): |
| 198 |
(WebCore::SVGRectElement::registerAttributes): Deleted. |
| 199 |
* svg/SVGRectElement.h: |
| 200 |
* svg/SVGSVGElement.cpp: |
| 201 |
(WebCore::SVGSVGElement::SVGSVGElement): |
| 202 |
(WebCore::SVGSVGElement::parseAttribute): |
| 203 |
(WebCore::SVGSVGElement::svgAttributeChanged): |
| 204 |
(WebCore::SVGSVGElement::registerAttributes): Deleted. |
| 205 |
* svg/SVGSVGElement.h: |
| 206 |
* svg/SVGTextContentElement.cpp: |
| 207 |
(WebCore::SVGTextContentElement::SVGTextContentElement): |
| 208 |
(WebCore::SVGTextContentElement::registerAttributes): |
| 209 |
(WebCore::SVGTextContentElement::parseAttribute): |
| 210 |
(WebCore::SVGTextContentElement::svgAttributeChanged): |
| 211 |
(WebCore::SVGTextContentElement::textLengthAnimated): |
| 212 |
* svg/SVGTextContentElement.h: |
| 213 |
(WebCore::SVGTextContentElement::specifiedTextLength const): |
| 214 |
(WebCore::SVGTextContentElement::textLength const): |
| 215 |
(WebCore::SVGTextContentElement::specifiedTextLength): Deleted. |
| 216 |
(WebCore::SVGTextContentElement::textLengthAnimated): Deleted. |
| 217 |
(WebCore::SVGTextContentElement::SVGAnimatedCustomLengthAttribute::SVGAnimatedCustomLengthAttribute): Deleted. |
| 218 |
(WebCore::SVGTextContentElement::SVGAnimatedCustomLengthAttribute::synchronize): Deleted. |
| 219 |
(WebCore::SVGTextContentElement::SVGAnimatedCustomLengthAttribute::animatedProperty): Deleted. |
| 220 |
* svg/SVGTextPathElement.cpp: |
| 221 |
(WebCore::SVGTextPathElement::SVGTextPathElement): |
| 222 |
(WebCore::SVGTextPathElement::registerAttributes): |
| 223 |
(WebCore::SVGTextPathElement::parseAttribute): |
| 224 |
* svg/SVGTextPathElement.h: |
| 225 |
* svg/SVGTextPositioningElement.cpp: |
| 226 |
(WebCore::SVGTextPositioningElement::SVGTextPositioningElement): |
| 227 |
(WebCore::SVGTextPositioningElement::parseAttribute): |
| 228 |
(WebCore::SVGTextPositioningElement::svgAttributeChanged): |
| 229 |
(WebCore::SVGTextPositioningElement::registerAttributes): Deleted. |
| 230 |
* svg/SVGTextPositioningElement.h: |
| 231 |
(WebCore::SVGTextPositioningElement::x const): |
| 232 |
(WebCore::SVGTextPositioningElement::y const): |
| 233 |
(WebCore::SVGTextPositioningElement::dx const): |
| 234 |
(WebCore::SVGTextPositioningElement::dy const): |
| 235 |
(WebCore::SVGTextPositioningElement::xAnimated): |
| 236 |
(WebCore::SVGTextPositioningElement::yAnimated): |
| 237 |
(WebCore::SVGTextPositioningElement::dxAnimated): |
| 238 |
(WebCore::SVGTextPositioningElement::dyAnimated): |
| 239 |
(WebCore::SVGTextPositioningElement::isKnownAttribute): Deleted. |
| 240 |
* svg/SVGUseElement.cpp: |
| 241 |
(WebCore::SVGUseElement::SVGUseElement): |
| 242 |
(WebCore::SVGUseElement::parseAttribute): |
| 243 |
(WebCore::SVGUseElement::svgAttributeChanged): |
| 244 |
(WebCore::SVGUseElement::registerAttributes): Deleted. |
| 245 |
* svg/SVGUseElement.h: |
| 246 |
* svg/SVGValue.h: |
| 247 |
* svg/properties/SVGAnimatedPropertyAccessorImpl.h: |
| 248 |
* svg/properties/SVGAnimatedPropertyAnimator.h: |
| 249 |
* svg/properties/SVGAnimatedPropertyAnimatorImpl.h: |
| 250 |
* svg/properties/SVGAnimatedPropertyImpl.h: |
| 251 |
* svg/properties/SVGAnimationAdditiveListFunctionImpl.h: |
| 252 |
(WebCore::SVGAnimationLengthListFunction::SVGAnimationLengthListFunction): |
| 253 |
(WebCore::SVGAnimationLengthListFunction::progress): |
| 254 |
(WebCore::SVGAnimationNumberListFunction::progress): |
| 255 |
(WebCore::SVGAnimationPointListFunction::progress): |
| 256 |
* svg/properties/SVGAnimationAdditiveValueFunctionImpl.h: |
| 257 |
(WebCore::SVGAnimationLengthFunction::SVGAnimationLengthFunction): |
| 258 |
(WebCore::SVGAnimationLengthFunction::progress): |
| 259 |
* svg/properties/SVGAttributeAnimator.cpp: |
| 260 |
(WebCore::SVGAttributeAnimator::isAnimatedStylePropertyAniamtor const): |
| 261 |
* svg/properties/SVGAttributeAnimator.h: |
| 262 |
* svg/properties/SVGAttributeRegistry.h: |
| 263 |
* svg/properties/SVGPropertyAnimatorFactory.h: |
| 264 |
(WebCore::SVGPropertyAnimatorFactory::createLengthAnimator): |
| 265 |
(WebCore::SVGPropertyAnimatorFactory::createLengthListAnimator): |
| 266 |
(WebCore::SVGPropertyAnimatorFactory::attributeAnimatorCreator): |
| 267 |
* svg/properties/SVGPropertyOwnerRegistry.h: |
| 268 |
(WebCore::SVGPropertyOwnerRegistry::registerProperty): |
| 269 |
(WebCore::SVGPropertyOwnerRegistry::isAnimatedLengthAttribute): |
| 270 |
* svg/properties/SVGPropertyRegistry.h: |
| 271 |
* svg/properties/SVGValuePropertyAnimator.h: Added. |
| 272 |
(WebCore::SVGValuePropertyAnimator::SVGValuePropertyAnimator): |
| 273 |
* svg/properties/SVGValuePropertyAnimatorImpl.h: Added. |
| 274 |
* svg/properties/SVGValuePropertyListAnimator.h: Added. |
| 275 |
(WebCore::SVGValuePropertyListAnimator::SVGValuePropertyListAnimator): |
| 276 |
* svg/properties/SVGValuePropertyListAnimatorImpl.h: Added. |
| 277 |
|
| 1 |
2019-03-26 Mike Gorse <mgorse@alum.wpi.edu> |
278 |
2019-03-26 Mike Gorse <mgorse@alum.wpi.edu> |
| 2 |
|
279 |
|
| 3 |
Build failure with gstreamer 1.12.5 if USE_GSTREAMER_GL is enabled |
280 |
Build failure with gstreamer 1.12.5 if USE_GSTREAMER_GL is enabled |