Attachment #314764 for bug #174221

View Details Raw Unified Return to Bug 174221

| Differences between



2017-07-06  Stephan Szabo  <stephan.szabo@sony.com>

        [Win] Build precompiled header successfully with clang-cl
        https://bugs.webkit.org/show_bug.cgi?id=174221

        Reviewed by NOBODY (OOPS!).

        * Source/cmake/WebKitMacros.cmake:

2017-06-28  Stephan Szabo  <stephan.szabo@am.sony.com>

        [Win] Build JSCOnly on Windows with clang-cl



        set(PrecompiledBinary "${CMAKE_CURRENT_BINARY_DIR}/${_source}/${PrecompiledBasename}.pch")
        set(_sources ${${_source}})

        # clang-cl requires /FI with /Yc
        if (COMPILER_IS_CLANG_CL)
            set_source_files_properties(${_cpp}
                PROPERTIES COMPILE_FLAGS "/Yc\"${_header}\" /Fp\"${PrecompiledBinary}\" /FI\"${_header}\""
                OBJECT_OUTPUTS "${PrecompiledBinary}")
        else ()
            set_source_files_properties(${_cpp}
\               PROPERTIES COMPILE_FLAGS "/Yc\"${_header}\" /Fp\"${PrecompiledBinary}\""
                OBJECT_OUTPUTS "${PrecompiledBinary}")
        endif ()
        set_source_files_properties(${_sources}
            PROPERTIES COMPILE_FLAGS "/Yu\"${_header}\" /FI\"${_header}\" /Fp\"${PrecompiledBinary}\"")


Return to Bug 174221

Lines 1-3 a/ChangeLog_sec1
- a/ChangeLog +9 lines
		1	2017-07-06 Stephan Szabo <stephan.szabo@sony.com>
		2
		3	[Win] Build precompiled header successfully with clang-cl
		4	https://bugs.webkit.org/show_bug.cgi?id=174221
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* Source/cmake/WebKitMacros.cmake:
		9
1	2017-06-28 Stephan Szabo <stephan.szabo@am.sony.com>	10	2017-06-28 Stephan Szabo <stephan.szabo@am.sony.com>
2		11
3	[Win] Build JSCOnly on Windows with clang-cl	12	[Win] Build JSCOnly on Windows with clang-cl

Lines 34-42 macro(ADD_PRECOMPILED_HEADER _header _cpp _source) a/Source/cmake/WebKitMacros.cmake_sec1
- a/Source/cmake/WebKitMacros.cmake -3 / +10 lines
34	set(PrecompiledBinary "${CMAKE_CURRENT_BINARY_DIR}/${_source}/${PrecompiledBasename}.pch")	34	set(PrecompiledBinary "${CMAKE_CURRENT_BINARY_DIR}/${_source}/${PrecompiledBasename}.pch")
35	set(_sources ${${_source}})	35	set(_sources ${${_source}})
36		36
37	set_source_files_properties(${_cpp}	37	# clang-cl requires /FI with /Yc
38	PROPERTIES COMPILE_FLAGS "/Yc\"${_header}\" /Fp\"${PrecompiledBinary}\""	38	if (COMPILER_IS_CLANG_CL)
39	OBJECT_OUTPUTS "${PrecompiledBinary}")	39	set_source_files_properties(${_cpp}
		40	PROPERTIES COMPILE_FLAGS "/Yc\"${_header}\" /Fp\"${PrecompiledBinary}\" /FI\"${_header}\""
		41	OBJECT_OUTPUTS "${PrecompiledBinary}")
		42	else ()
		43	set_source_files_properties(${_cpp}
		44	\ PROPERTIES COMPILE_FLAGS "/Yc\"${_header}\" /Fp\"${PrecompiledBinary}\""
		45	OBJECT_OUTPUTS "${PrecompiledBinary}")
		46	endif ()
40	set_source_files_properties(${_sources}	47	set_source_files_properties(${_sources}
41	PROPERTIES COMPILE_FLAGS "/Yu\"${_header}\" /FI\"${_header}\" /Fp\"${PrecompiledBinary}\"")	48	PROPERTIES COMPILE_FLAGS "/Yu\"${_header}\" /FI\"${_header}\" /Fp\"${PrecompiledBinary}\"")
42		49