Attachment #308554 for bug #171436

View Details Raw Unified Return to Bug 171436

| Differences between



2017-04-28  Don Olmstead  <don.olmstead@am.sony.com>

        [Win] Set CMake args in build-webkit
        https://bugs.webkit.org/show_bug.cgi?id=171436

        Reviewed by NOBODY (OOPS!).

        * Scripts/build-webkit:
        (cMakeArgsFromFeatures): Deleted.
        (writeCongrats): Deleted.

2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>

        [ATK] GridCellRole should implement AtkTableCell (regression?)

Lines 257-263 if (isAppleWinWebKit() \|\| isWinCairo()) { a/Tools/Scripts/build-webkit_sec1
- a/Tools/Scripts/build-webkit -1 / +1 lines
257	removeCMakeCache(@featureArgs);	257	removeCMakeCache(@featureArgs);
258		258
259	chdirWebKit();	259	chdirWebKit();
260	if (exitStatus(generateBuildSystemFromCMakeProject())) {	260	if (exitStatus(generateBuildSystemFromCMakeProject($prefixPath, @cmakeArgs))) {
261	die "Run \"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/vcvarsall.bat\" before build-webkit when using ninja";	261	die "Run \"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/vcvarsall.bat\" before build-webkit when using ninja";
262	}	262	}
263	chdirWebKit();	263	chdirWebKit();

Return to Bug 171436

Lines 1-3 a/Tools/ChangeLog_sec1
- a/Tools/ChangeLog +11 lines
		1	2017-04-28 Don Olmstead <don.olmstead@am.sony.com>
		2
		3	[Win] Set CMake args in build-webkit
		4	https://bugs.webkit.org/show_bug.cgi?id=171436
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* Scripts/build-webkit:
		9	(cMakeArgsFromFeatures): Deleted.
		10	(writeCongrats): Deleted.
		11
1	2017-04-28 Joanmarie Diggs <jdiggs@igalia.com>	12	2017-04-28 Joanmarie Diggs <jdiggs@igalia.com>
2		13
3	[ATK] GridCellRole should implement AtkTableCell (regression?)	14	[ATK] GridCellRole should implement AtkTableCell (regression?)