| Differences between
and this patch
- a/Source/ThirdParty/ANGLE/ChangeLog +10 lines
Lines 1-3 a/Source/ThirdParty/ANGLE/ChangeLog_sec1
1
2016-07-28  David Kilzer  <ddkilzer@apple.com>
2
3
        Remove unused check-for-exit-time-destructors, check-for-global-initializers scripts and deploy -Wexit-time-destructors, -Wglobal-constructors clang switches consistently
4
        <https://webkit.org/b/160302>
5
6
        Reviewed by NOBODY (OOPS!).
7
8
        * Configurations/Base.xcconfig: Add -Wglobal-constructors
9
        warning flag.
10
1
2016-07-13  Enrica Casucci  <enrica@apple.com>
11
2016-07-13  Enrica Casucci  <enrica@apple.com>
2
12
3
        Update supported platforms in xcconfig files to match the sdk names.
13
        Update supported platforms in xcconfig files to match the sdk names.
- a/Source/WebInspectorUI/ChangeLog +11 lines
Lines 1-3 a/Source/WebInspectorUI/ChangeLog_sec1
1
2016-07-28  David Kilzer  <ddkilzer@apple.com>
2
3
        Remove unused check-for-exit-time-destructors, check-for-global-initializers scripts and deploy -Wexit-time-destructors, -Wglobal-constructors clang switches consistently
4
        <https://webkit.org/b/160302>
5
6
        Reviewed by NOBODY (OOPS!).
7
8
        * Configurations/Base.xcconfig:
9
        - Add -Wexit-time-destructors, -Wglobal-constructors warning
10
          flags.
11
1
2016-07-27  Nikita Vasilyev  <nvasilyev@apple.com>
12
2016-07-27  Nikita Vasilyev  <nvasilyev@apple.com>
2
13
3
        Web Inspector: Visual Styles Sidebar should have only one column when it's narrow
14
        Web Inspector: Visual Styles Sidebar should have only one column when it's narrow
- a/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig +1 lines
Lines 42-47 GCC_WARN_UNUSED_FUNCTION = YES; a/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig_sec1
42
GCC_WARN_UNUSED_VARIABLE = YES;
42
GCC_WARN_UNUSED_VARIABLE = YES;
43
PREBINDING = NO;
43
PREBINDING = NO;
44
STRIP_INSTALLED_PRODUCT = NO;
44
STRIP_INSTALLED_PRODUCT = NO;
45
WARNING_CFLAGS = -Wexit-time-destructors -Wglobal-constructors;
45
46
46
SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
47
SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
47
48
- a/Source/WebInspectorUI/Configurations/Base.xcconfig -1 / +1 lines
Lines 46-52 GCC_WARN_UNDECLARED_SELECTOR = YES; a/Source/WebInspectorUI/Configurations/Base.xcconfig_sec1
46
GCC_WARN_UNINITIALIZED_AUTOS = YES
46
GCC_WARN_UNINITIALIZED_AUTOS = YES
47
GCC_WARN_UNUSED_FUNCTION = YES;
47
GCC_WARN_UNUSED_FUNCTION = YES;
48
GCC_WARN_UNUSED_VARIABLE = YES
48
GCC_WARN_UNUSED_VARIABLE = YES
49
WARNING_CFLAGS = -Wall -W -Wchar-subscripts -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wexit-time-destructors;
49
WARNING_CFLAGS = -Wall -W -Wchar-subscripts -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wexit-time-destructors -Wglobal-constructors;
50
50
51
ENGINEERING_BUILD_DEFINES = $(ENGINEERING_BUILD_DEFINES_$(ENGINEERING_BUILD));
51
ENGINEERING_BUILD_DEFINES = $(ENGINEERING_BUILD_DEFINES_$(ENGINEERING_BUILD));
52
ENGINEERING_BUILD_DEFINES_1 = ENGINEERING_BUILD=1;
52
ENGINEERING_BUILD_DEFINES_1 = ENGINEERING_BUILD=1;
- a/Tools/ChangeLog +20 lines
Lines 1-3 a/Tools/ChangeLog_sec1
1
2016-07-28  David Kilzer  <ddkilzer@apple.com>
2
3
        Remove unused check-for-exit-time-destructors, check-for-global-initializers scripts and deploy -Wexit-time-destructors, -Wglobal-constructors clang switches consistently
4
        <https://webkit.org/b/160302>
5
6
        Reviewed by NOBODY (OOPS!).
7
8
        * Scripts/check-for-exit-time-destructors: Removed.
9
        * Scripts/check-for-global-initializers: Removed.
10
11
        * DumpRenderTree/mac/Configurations/Base.xcconfig:
12
        * LayoutTestRelay/Configurations/Base.xcconfig:
13
        * MiniBrowser/Configurations/Base.xcconfig:
14
        * TestWebKitAPI/Configurations/Base.xcconfig:
15
        * WebEditingTester/Configurations/Base.xcconfig:
16
        * WebKitLauncher/Configurations/Base.xcconfig:
17
        * WebKitTestRunner/Configurations/Base.xcconfig:
18
        - Add -Wexit-time-destructors, -Wglobal-constructors warning
19
          flags.
20
1
2016-07-27  Alexey Proskuryakov  <ap@apple.com>
21
2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2
22
3
        LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
23
        LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
- a/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig -1 / +1 lines
Lines 63-69 GCC_WARN_UNDECLARED_SELECTOR = YES; a/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig_sec1
63
// FIXME: <http://webkit.org/b/118590> DumpRenderTree should build with -Wshorten-64-to-32
63
// FIXME: <http://webkit.org/b/118590> DumpRenderTree should build with -Wshorten-64-to-32
64
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64] = NO;
64
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64] = NO;
65
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
65
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
66
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
66
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef -Wexit-time-destructors -Wglobal-constructors;
67
67
68
DEBUG_DEFINES_debug = ;
68
DEBUG_DEFINES_debug = ;
69
DEBUG_DEFINES_normal = NDEBUG;
69
DEBUG_DEFINES_normal = NDEBUG;
- a/Tools/LayoutTestRelay/Configurations/Base.xcconfig -1 / +1 lines
Lines 45-51 GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO a/Tools/LayoutTestRelay/Configurations/Base.xcconfig_sec1
45
GCC_WARN_UNUSED_FUNCTION = YES
45
GCC_WARN_UNUSED_FUNCTION = YES
46
GCC_WARN_UNUSED_VARIABLE = YES
46
GCC_WARN_UNUSED_VARIABLE = YES
47
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
47
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
48
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
48
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef -Wexit-time-destructors -Wglobal-constructors;
49
49
50
DEBUG_DEFINES_debug = ;
50
DEBUG_DEFINES_debug = ;
51
DEBUG_DEFINES_normal = NDEBUG;
51
DEBUG_DEFINES_normal = NDEBUG;
- a/Tools/MiniBrowser/Configurations/Base.xcconfig -1 / +1 lines
Lines 52-58 GCC_WARN_UNUSED_VARIABLE = YES a/Tools/MiniBrowser/Configurations/Base.xcconfig_sec1
52
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
52
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
53
GCC_WARN_UNDECLARED_SELECTOR = YES;
53
GCC_WARN_UNDECLARED_SELECTOR = YES;
54
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
54
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
55
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
55
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wexit-time-destructors -Wglobal-constructors;
56
GCC_NO_COMMON_BLOCKS = YES;
56
GCC_NO_COMMON_BLOCKS = YES;
57
57
58
SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx tvos tvsimulator watchos watchsimulator;
58
SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx tvos tvsimulator watchos watchsimulator;
- a/Tools/Scripts/check-for-exit-time-destructors -166 lines
Lines 1-166 a/Tools/Scripts/check-for-exit-time-destructors_sec1
1
#!/usr/bin/perl
2
3
# Copyright (C) 2006-2008, 2016 Apple Inc. All rights reserved.
4
#
5
# Redistribution and use in source and binary forms, with or without
6
# modification, are permitted provided that the following conditions
7
# are met:
8
# 1.  Redistributions of source code must retain the above copyright
9
#     notice, this list of conditions and the following disclaimer.
10
# 2.  Redistributions in binary form must reproduce the above copyright
11
#     notice, this list of conditions and the following disclaimer in the
12
#     documentation and/or other materials provided with the distribution.
13
#
14
# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
15
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16
# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17
# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18
# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19
# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20
# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
21
# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
23
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24
25
# "check-for-exit-time-destructors" script for WebKit Open Source Project
26
27
# Intended to be invoked from an Xcode build step to check if there are
28
# any exit-time destructors in a target.
29
30
use warnings;
31
use strict;
32
33
use File::Basename;
34
use File::Spec;
35
use Getopt::Long;
36
37
sub touch($);
38
sub printFunctions($$);
39
40
my $coverageBuild;
41
my $executablePath;
42
my @files;
43
my $showHelp;
44
my $tempDir;
45
46
if (@ARGV) {
47
    # Running in interactive mode with arguments.
48
    my $result = GetOptions(
49
        "h|help" => \$showHelp,
50
    );
51
    $executablePath = glob(shift @ARGV);
52
53
    if (!$result || $showHelp || @ARGV > 0) {
54
        print STDERR "Check for exit-time destructors.\n";
55
        print STDERR "Usage: " . basename($0) . " [options] path/to/executable\n";
56
        print STDERR <<END;
57
  [-h|--help]                    show this help message
58
END
59
        exit 1;
60
    }
61
62
    $tempDir = File::Spec->tmpdir();
63
    @files = ($executablePath);
64
} else {
65
    # Running from Xcode build phase script with no arguments.
66
    $coverageBuild = $ENV{'WEBKIT_COVERAGE_BUILD'};
67
    $executablePath = "$ENV{'TARGET_BUILD_DIR'}/$ENV{'EXECUTABLE_PATH'}";
68
    $tempDir = $ENV{'TARGET_TEMP_DIR'};
69
70
    my $arch = $ENV{'CURRENT_ARCH'};
71
    my $variant = $ENV{'CURRENT_VARIANT'};
72
    my $list = $ENV{"LINK_FILE_LIST_${variant}_${arch}"};
73
    open LIST, $list || die "ERROR: Could not open $list\n";
74
    @files = <LIST>;
75
    chomp @files;
76
    close LIST;
77
}
78
79
my $buildTimestampPath = File::Spec->catfile($tempDir, basename($0) . ".timestamp");
80
my $buildTimestampAge = -M $buildTimestampPath;
81
my $scriptAge = -M $0;
82
83
my $sawError = 0;
84
85
for my $file (sort @files) {
86
    if (defined $buildTimestampAge && $buildTimestampAge < $scriptAge) {
87
        my $fileAge = -M $file;
88
        next if defined $fileAge && $fileAge > $buildTimestampAge;
89
    }
90
    if (!open NM, "(nm '$file' | sed 's/^/STDOUT:/') 2>&1 |") {
91
        print "ERROR: Could not open $file\n";
92
        $sawError = 1;
93
        next;
94
    }
95
    my $sawAtExit = 0;
96
    my $shortName = $file;
97
    $shortName =~ s/.*\///;
98
99
    while (<NM>) {
100
        if (/^STDOUT:/) {
101
            # With GC logging enabled Heap.o may contain finalizers, so we ignore them.
102
            $sawAtExit = 1 if (/___cxa_atexit/ && ($shortName ne "Heap.o"));
103
        } else {
104
            print STDERR if $_ ne "nm: no name list\n";
105
        }
106
    }
107
    close NM;
108
    next unless $sawAtExit;
109
110
    $sawError = 1 if printFunctions($shortName, $file);
111
}
112
113
if ($sawError and !$coverageBuild) {
114
    print "ERROR: Use static NeverDestroyed<T> from <wtf/NeverDestroyed.h>\n";
115
    unlink $executablePath;
116
    exit 1;
117
}
118
119
touch($buildTimestampPath);
120
exit 0;
121
122
sub touch($)
123
{
124
    my ($path) = @_;
125
    open(TOUCH, ">", $path) or die "$!";
126
    close(TOUCH);
127
}
128
129
sub demangle($)
130
{
131
    my ($symbol) = @_;
132
    if (!open FILT, "c++filt $symbol |") {
133
        print "ERROR: Could not open c++filt\n";
134
        return;
135
    }
136
    my $result = <FILT>;
137
    close FILT;
138
    chomp $result;
139
    return $result;
140
}
141
142
sub printFunctions($$)
143
{
144
    my ($shortName, $path) = @_;
145
    if (!open OTOOL, "otool -tV '$path' |") {
146
        print "WARNING: Could not open $path\n";
147
        return 0;
148
    }
149
    my %functions;
150
    my $currentSymbol = "";
151
    while (<OTOOL>) {
152
        $currentSymbol = $1 if /^(\w+):$/;
153
        next unless $currentSymbol;
154
        $functions{demangle($currentSymbol)} = 1 if /___cxa_atexit/;
155
    }
156
    close OTOOL;
157
    my $result = 0;
158
    for my $function (sort keys %functions) {
159
        if (!$result) {
160
            print "ERROR: $shortName has exit time destructors in it! ($path)\n";
161
            $result = 1;
162
        }
163
        print "ERROR: In function $function\n";
164
    }
165
    return $result;
166
}
- a/Tools/Scripts/check-for-global-initializers -163 lines
Lines 1-163 a/Tools/Scripts/check-for-global-initializers_sec1
1
#!/usr/bin/perl
2
3
# Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
4
#
5
# Redistribution and use in source and binary forms, with or without
6
# modification, are permitted provided that the following conditions
7
# are met:
8
#
9
# 1.  Redistributions of source code must retain the above copyright
10
#     notice, this list of conditions and the following disclaimer. 
11
# 2.  Redistributions in binary form must reproduce the above copyright
12
#     notice, this list of conditions and the following disclaimer in the
13
#     documentation and/or other materials provided with the distribution. 
14
# 3.  Neither the name of Apple Inc. ("Apple") nor the names of
15
#     its contributors may be used to endorse or promote products derived
16
#     from this software without specific prior written permission. 
17
#
18
# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
19
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
20
# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
21
# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
22
# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
23
# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
24
# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
25
# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
27
# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28
29
# "check-for-global-initializers" script for WebKit Open Source Project
30
31
# Intended to be invoked from an Xcode build step to check if there are
32
# any global initializers in a target.
33
34
use warnings;
35
use strict;
36
37
use File::Basename;
38
39
sub touch($);
40
sub demangle($);
41
42
my $arch = $ENV{'CURRENT_ARCH'};
43
my $configuration = $ENV{'CONFIGURATION'};
44
my $target = $ENV{'TARGET_NAME'};
45
my $variant = $ENV{'CURRENT_VARIANT'};
46
my $coverageBuild = $ENV{'WEBKIT_COVERAGE_BUILD'};
47
my $debugRoot = $ENV{'WEBKIT_DEBUG_ROOT'};
48
49
my $executablePath = "$ENV{'TARGET_BUILD_DIR'}/$ENV{'EXECUTABLE_PATH'}";
50
51
my $buildTimestampPath = $ENV{'TARGET_TEMP_DIR'} . "/" . basename($0) . ".timestamp";
52
my $buildTimestampAge = -M $buildTimestampPath;
53
my $scriptAge = -M $0;
54
55
my $list = $ENV{"LINK_FILE_LIST_${variant}_${arch}"};
56
57
if (!open LIST, $list) {
58
    print "ERROR: Could not open $list\n";
59
    exit 1;
60
}
61
62
my @files = <LIST>;
63
chomp @files;
64
close LIST;
65
66
my $sawError = 0;
67
68
for my $file (sort @files) {
69
    if (defined $buildTimestampAge && $buildTimestampAge < $scriptAge) {
70
        my $fileAge = -M $file;
71
        next if defined $fileAge && $fileAge > $buildTimestampAge;
72
    }
73
    if (!open NM, "(nm '$file' | sed 's/^/STDOUT:/') 2>&1 |") {
74
        print "ERROR: Could not open $file\n";
75
        $sawError = 1;
76
        next;
77
    }
78
    my $sawGlobal = 0;
79
    my @globals;
80
    while (<NM>) {
81
        if (/^STDOUT:/) {
82
            my $line = $_;
83
            if ($line =~ /__GLOBAL__I(.+)$/) {
84
                $sawGlobal = 1;
85
                push(@globals, demangle($1));
86
            }
87
        } else {
88
            print STDERR if $_ ne "nm: no name list\n";
89
        }
90
    }
91
    close NM;
92
    if ($sawGlobal) {
93
        my $shortName = $file;
94
        $shortName =~ s/.*\///;
95
96
        # Special cases for files that have initializers in debug builds.
97
        if ($configuration eq "Debug" or $variant eq "debug" or $debugRoot) {
98
            if ($target eq "JavaScriptCore") {
99
                next if $shortName eq "AllInOneFile.o";
100
                next if $shortName eq "Opcode.o";
101
                next if $shortName eq "Structure.o";
102
                next if $shortName eq "nodes.o";
103
            }
104
            if ($target eq "WebCore") {
105
                next if $shortName eq "BidiRun.o";
106
                next if $shortName eq "CachedPage.o";
107
                next if $shortName eq "CachedResource.o";
108
                next if $shortName eq "FEGaussianBlur.o";
109
                next if $shortName eq "Frame.o";
110
                next if $shortName eq "JSCustomSQLTransactionCallback.o";
111
                next if $shortName eq "JSLazyEventListener.o";
112
                next if $shortName eq "Node.o";
113
                next if $shortName eq "Page.o";
114
                next if $shortName eq "Range.o";
115
                next if $shortName eq "RenderObject.o";
116
                next if $shortName eq "SubresourceLoader.o";
117
                next if $shortName eq "XMLHttpRequest.o";
118
            }
119
            if ($target eq "WebKit") {
120
                next if $shortName eq "HostedNetscapePluginStream.o";
121
                next if $shortName eq "NetscapePluginInstanceProxy.o";
122
            }
123
            if ($target eq "WebKit2") {
124
                next if $shortName eq "WebContext.o";
125
                next if $shortName eq "WebFrame.o";
126
                next if $shortName eq "WebPage.o";
127
                next if $shortName eq "WebPageProxy.o";
128
            }
129
        }
130
131
        print "ERROR: $shortName has one or more global initializers in it! ($file), near @globals\n";
132
        $sawError = 1;
133
    }
134
}
135
136
if ($sawError and !$coverageBuild) {
137
    unlink $executablePath;
138
    exit 1;
139
}
140
141
touch($buildTimestampPath);
142
exit 0;
143
144
sub touch($)
145
{
146
    my ($path) = @_;
147
    open(TOUCH, ">", $path) or die "$!";
148
    close(TOUCH);
149
}
150
151
sub demangle($)
152
{
153
    my ($symbol) = @_;
154
    if (!open FILT, "c++filt $symbol |") {
155
        print "ERROR: Could not open c++filt\n";
156
        return;
157
    }
158
    my $result = <FILT>;
159
    close FILT;
160
    chomp $result;
161
    return $result;
162
}
163
- a/Tools/TestWebKitAPI/Configurations/Base.xcconfig -1 / +1 lines
Lines 62-68 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; a/Tools/TestWebKitAPI/Configurations/Base.xcconfig_sec1
62
GCC_WARN_UNDECLARED_SELECTOR = YES;
62
GCC_WARN_UNDECLARED_SELECTOR = YES;
63
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64] = NO;
63
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64] = NO;
64
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
64
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
65
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
65
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wexit-time-destructors -Wglobal-constructors;
66
66
67
// DEBUG_DEFINES, GCC_OPTIMIZATION_LEVEL, STRIP_INSTALLED_PRODUCT and DEAD_CODE_STRIPPING vary between the debug and normal variants.
67
// DEBUG_DEFINES, GCC_OPTIMIZATION_LEVEL, STRIP_INSTALLED_PRODUCT and DEAD_CODE_STRIPPING vary between the debug and normal variants.
68
// We set up the values for each variant here, and have the Debug configuration in the Xcode project use the _debug variant.
68
// We set up the values for each variant here, and have the Debug configuration in the Xcode project use the _debug variant.
- a/Tools/WebEditingTester/Configurations/Base.xcconfig -1 / +1 lines
Lines 51-57 GCC_WARN_UNUSED_VARIABLE = YES a/Tools/WebEditingTester/Configurations/Base.xcconfig_sec1
51
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
51
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
52
GCC_WARN_UNDECLARED_SELECTOR = YES;
52
GCC_WARN_UNDECLARED_SELECTOR = YES;
53
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
53
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
54
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
54
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wexit-time-destructors -Wglobal-constructors;
55
CLANG_ENABLE_OBJC_ARC = YES;
55
CLANG_ENABLE_OBJC_ARC = YES;
56
56
57
TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
57
TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
- a/Tools/WebKitLauncher/Configurations/Base.xcconfig -2 / +2 lines
Lines 32-41 GCC_VERSION = com.apple.compilers.llvm.clang.1_0; a/Tools/WebKitLauncher/Configurations/Base.xcconfig_sec1
32
MACOSX_DEPLOYMENT_TARGET = 10.6;
32
MACOSX_DEPLOYMENT_TARGET = 10.6;
33
PREBINDING = NO;
33
PREBINDING = NO;
34
SDKROOT = macosx;
34
SDKROOT = macosx;
35
WARNING_CFLAGS = -Wall;
35
WARNING_CFLAGS = -Wall -Wexit-time-destructors -Wglobal-constructors;
36
36
37
ENABLE_SPARKLE = 0;
37
ENABLE_SPARKLE = 0;
38
38
39
OTHER_CFLAGS = $(inherited) $(ASAN_OTHER_CFLAGS);
39
OTHER_CFLAGS = $(inherited) $(ASAN_OTHER_CFLAGS);
40
OTHER_CPLUSPLUSFLAGS = $(inherited) $(ASAN_OTHER_CPLUSPLUSFLAGS);
40
OTHER_CPLUSPLUSFLAGS = $(inherited) $(ASAN_OTHER_CPLUSPLUSFLAGS);
41
OTHER_LDFLAGS = $(inherited) $(ASAN_OTHER_LDFLAGS);
41
OTHER_LDFLAGS = $(inherited) $(ASAN_OTHER_LDFLAGS);
- a/Tools/WebKitTestRunner/Configurations/Base.xcconfig -1 / +1 lines
Lines 46-52 GCC_WARN_UNUSED_FUNCTION = YES a/Tools/WebKitTestRunner/Configurations/Base.xcconfig_sec1
46
GCC_WARN_UNUSED_VARIABLE = YES
46
GCC_WARN_UNUSED_VARIABLE = YES
47
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64] = NO;
47
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64] = NO;
48
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
48
GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
49
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
49
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef -Wexit-time-destructors -Wglobal-constructors;
50
GCC_PREFIX_HEADER = WebKitTestRunnerPrefix.h
50
GCC_PREFIX_HEADER = WebKitTestRunnerPrefix.h
51
51
52
DEBUG_DEFINES_debug = ;
52
DEBUG_DEFINES_debug = ;

Return to Bug 160302