Attachment #226541 for bug #130151

View Details Raw Unified Return to Bug 130151



2014-03-12  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r165481.
        https://bugs.webkit.org/show_bug.cgi?id=130151

        That didn't go well. (Requested by kling on #webkit).

        Reverted changeset:

        https://bugs.webkit.org/show_bug.cgi?id=130140
        http://trac.webkit.org/changeset/165481

2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Runtime error when page is closed while print operation is in progress

Lines 35-41 void InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage(WebPage* pa a/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp_sec1
- a/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp -1 / +1 lines
35	{	35	{
36	if (!m_client.logDiagnosticMessage)	36	if (!m_client.logDiagnosticMessage)
37	return;	37	return;
38	m_client.logDiagnosticMessage(toAPI(page), toAPI(message), toAPI(description), toAPI(success), m_client.base.clientInfo);	38	m_client.logDiagnosticMessage(toAPI(page), toCopiedAPI(message), toCopiedAPI(description), toCopiedAPI(success), m_client.base.clientInfo);
39	}	39	}
40		40
41	}	41	}

Return to Bug 130151

Lines 1-3 a/Source/WebKit2/ChangeLog_sec1
- a/Source/WebKit2/ChangeLog +12 lines
		1	2014-03-12 Commit Queue <commit-queue@webkit.org>
		2
		3	Unreviewed, rolling out r165481.
		4	https://bugs.webkit.org/show_bug.cgi?id=130151
		5
		6	That didn't go well. (Requested by kling on #webkit).
		7
		8	Reverted changeset:
		9
		10	https://bugs.webkit.org/show_bug.cgi?id=130140
		11	http://trac.webkit.org/changeset/165481
		12
1	2014-03-12 Carlos Garcia Campos <cgarcia@igalia.com>	13	2014-03-12 Carlos Garcia Campos <cgarcia@igalia.com>
2		14
3	[GTK] Runtime error when page is closed while print operation is in progress	15	[GTK] Runtime error when page is closed while print operation is in progress