Attachment #196149 for bug #113788

View Details Raw Unified Return to Bug 113788



2013-04-02  Yury Semikhatsky  <yurys@chromium.org>

        Web Inspector: memory instrumentation for external strings is broken
        https://bugs.webkit.org/show_bug.cgi?id=113788

        Reviewed by NOBODY (OOPS!).

        Native memory snapshot now provides information about JS external strings.

        Test: inspector/profiler/memory-instrumentation-external-string.html

        * inspector/InspectorMemoryAgent.cpp:

2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>

        [BlackBerry] Implement ScrollingCoordinator::frameViewLayoutUpdated()

Lines 160-166 public: a/Source/WebCore/inspector/InspectorMemoryAgent.cpp_sec1
- a/Source/WebCore/inspector/InspectorMemoryAgent.cpp -1 / +1 lines
160	private:	160	private:
161	virtual void visitJSExternalString(StringImpl* string)	161	virtual void visitJSExternalString(StringImpl* string)
162	{	162	{
163	m_memoryClassInfo->addMember(string, "externalString");	163	m_memoryClassInfo->addMember(string, "externalString", WTF::RetainingPointer);
164	}	164	}
165		165
166	mutable MemoryClassInfo* m_memoryClassInfo;	166	mutable MemoryClassInfo* m_memoryClassInfo;



2013-04-02  Yury Semikhatsky  <yurys@chromium.org>

        Web Inspector: memory instrumentation for external strings is broken
        https://bugs.webkit.org/show_bug.cgi?id=113788

        Test that native memory snapshot contains information about extenral strings.

        Reviewed by NOBODY (OOPS!).

        * inspector/profiler/memory-instrumentation-external-string-expected.txt: Added.
        * inspector/profiler/memory-instrumentation-external-string.html: Added.
        * platform/efl/TestExpectations:
        * platform/gtk/TestExpectations:
        * platform/mac/TestExpectations:
        * platform/qt/TestExpectations:
        * platform/win/TestExpectations:

2013-04-02  Thiago Marcos P. Santos  <thiago.santos@intel.com>

        [EFL] Unreviewed gardening.

Line 0 a/LayoutTests/inspector/profiler/memory-instrumentation-external-string-expected.txt_sec1
- a/LayoutTests/inspector/profiler/memory-instrumentation-external-string-expected.txt +4 lines
	1	This test checks that page's external strings size reported by the memory agent includes size of script elements.Bug 113788.
	2
	3	PASS: block size for path = [ProcessPrivateMemory, JSExternalResources] is OK.
	4



<html>
<head>
<script src="../../http/tests/inspector/inspector-test.js"></script>
<script src="memory-instrumentation-test.js"></script>
<script>
function generateLongFunction()
{
    var source = [];
    source.push("function longFunction(x) {");
    for (var i = 0; i < 100*1000; i++) {
        source.push("  x += x * i;");
    }
    source.push("}");
    var sourceString = source.join("\n");
    sourceSize = sourceString.length;
    var script = document.createElement("script");
    script.textContent = sourceString;
    document.head.appendChild(script);
    return sourceSize;
}

function test()
{
    InspectorTest.evaluateInPage("generateLongFunction()", didGenerateLongScript);
    function didGenerateLongScript(result) {
        var externalStringsExpectedMinimum = result.value;
        if (externalStringsExpectedMinimum < 1024 * 1024) {
            InspectorTest.addResult("FAIL: script is less than 1Mb: " + externalStringsExpectedMinimum);
            return InspectorTest.completeTest();
        }
        InspectorTest.validateMemoryBlockSize(["ProcessPrivateMemory", "JSExternalResources"], externalStringsExpectedMinimum);
    }
}
</script>
</head>

<body onload="runTest()">
<p>
This test checks that page's external strings size reported by the memory agent
includes size of script elements.<a href="https://bugs.webkit.org/show_bug.cgi?id=113788">Bug 113788.</a>
</p>
</body>
</html>

Lines 1443-1448 webkit.org/b/50485 inspector/profiler/heap-snapshot-summary-sorting.html [ Skip a/LayoutTests/platform/efl/TestExpectations_sec1
- a/LayoutTests/platform/efl/TestExpectations +2 lines
1443	webkit.org/b/50485 inspector/profiler/heap-snapshot-summary-sorting-instances.html [ Skip ]	1443	webkit.org/b/50485 inspector/profiler/heap-snapshot-summary-sorting-instances.html [ Skip ]
1444	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]	1444	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
1445		1445
		1446	webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
		1447
1446	# ENABLE(INPUT_MULTIPLE_FIELDS_UI) is disabled	1448	# ENABLE(INPUT_MULTIPLE_FIELDS_UI) is disabled
1447	fast/forms/date-multiple-fields	1449	fast/forms/date-multiple-fields
1448	fast/forms/datetime-multiple-fields	1450	fast/forms/datetime-multiple-fields

Lines 945-950 webkit.org/b/50485 inspector/profiler/heap-snapshot-summary-sorting-instances.ht a/LayoutTests/platform/gtk/TestExpectations_sec1
- a/LayoutTests/platform/gtk/TestExpectations +1 lines
945	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]	945	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
946		946
947	webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html [ Failure ]	947	webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html [ Failure ]
		948	webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
948		949
949	webkit.org/b/73936 inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html [ Failure ]	950	webkit.org/b/73936 inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html [ Failure ]
950	webkit.org/b/73936 inspector/profiler/canvas2d/canvas-stack-trace.html [ Failure ]	951	webkit.org/b/73936 inspector/profiler/canvas2d/canvas-stack-trace.html [ Failure ]

Lines 287-292 inspector/profiler/heap-snapshot-summary-sorting.html a/LayoutTests/platform/mac/TestExpectations_sec1
- a/LayoutTests/platform/mac/TestExpectations +2 lines
287	inspector/profiler/heap-snapshot-summary-sorting-instances.html	287	inspector/profiler/heap-snapshot-summary-sorting-instances.html
288	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]	288	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
289		289
		290	webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
		291
290	# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms	292	# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms
291	webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html	293	webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html
292	webkit.org/b/73936 inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html	294	webkit.org/b/73936 inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html

Lines 272-277 inspector/profiler/heap-snapshot-summary-sorting-instances.html a/LayoutTests/platform/qt/TestExpectations_sec1
- a/LayoutTests/platform/qt/TestExpectations +2 lines
272	inspector/profiler/memory-instrumentation-cached-images.html	272	inspector/profiler/memory-instrumentation-cached-images.html
273	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]	273	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
274		274
		275	webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
		276
275	# https://bugs.webkit.org/show_bug.cgi?id=40300	277	# https://bugs.webkit.org/show_bug.cgi?id=40300
276	inspector/debugger/live-edit.html	278	inspector/debugger/live-edit.html
277	inspector/debugger/live-edit-breakpoints.html	279	inspector/debugger/live-edit-breakpoints.html

Lines 1308-1313 inspector/profiler/heap-snapshot-summary-sorting.html a/LayoutTests/platform/win/TestExpectations_sec1
- a/LayoutTests/platform/win/TestExpectations +2 lines
1308	inspector/profiler/heap-snapshot-summary-sorting-instances.html	1308	inspector/profiler/heap-snapshot-summary-sorting-instances.html
1309	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]	1309	webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
1310		1310
		1311	webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
		1312
1311	# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms	1313	# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms
1312	webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html	1314	webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html
1313	webkit.org/b/73936 inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html	1315	webkit.org/b/73936 inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html

Return to Bug 113788

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +13 lines
		1	2013-04-02 Yury Semikhatsky <yurys@chromium.org>
		2
		3	Web Inspector: memory instrumentation for external strings is broken
		4	https://bugs.webkit.org/show_bug.cgi?id=113788
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Native memory snapshot now provides information about JS external strings.
		9
		10	Test: inspector/profiler/memory-instrumentation-external-string.html
		11
		12	* inspector/InspectorMemoryAgent.cpp:
		13
1	2013-04-02 Carlos Garcia Campos <cgarcia@igalia.com>	14	2013-04-02 Carlos Garcia Campos <cgarcia@igalia.com>
2		15
3	[BlackBerry] Implement ScrollingCoordinator::frameViewLayoutUpdated()	16	[BlackBerry] Implement ScrollingCoordinator::frameViewLayoutUpdated()

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +17 lines
		1	2013-04-02 Yury Semikhatsky <yurys@chromium.org>
		2
		3	Web Inspector: memory instrumentation for external strings is broken
		4	https://bugs.webkit.org/show_bug.cgi?id=113788
		5
		6	Test that native memory snapshot contains information about extenral strings.
		7
		8	Reviewed by NOBODY (OOPS!).
		9
		10	* inspector/profiler/memory-instrumentation-external-string-expected.txt: Added.
		11	* inspector/profiler/memory-instrumentation-external-string.html: Added.
		12	* platform/efl/TestExpectations:
		13	* platform/gtk/TestExpectations:
		14	* platform/mac/TestExpectations:
		15	* platform/qt/TestExpectations:
		16	* platform/win/TestExpectations:
		17
1	2013-04-02 Thiago Marcos P. Santos <thiago.santos@intel.com>	18	2013-04-02 Thiago Marcos P. Santos <thiago.santos@intel.com>
2		19
3	[EFL] Unreviewed gardening.	20	[EFL] Unreviewed gardening.

Line 0 a/LayoutTests/inspector/profiler/memory-instrumentation-external-string.html_sec1
- a/LayoutTests/inspector/profiler/memory-instrumentation-external-string.html +43 lines
	1	<html>
	2	<head>
	3	<script src="../../http/tests/inspector/inspector-test.js"></script>
	4	<script src="memory-instrumentation-test.js"></script>
	5	<script>
	6	function generateLongFunction()
	7	{
	8	var source = [];
	9	source.push("function longFunction(x) {");
	10	for (var i = 0; i < 100*1000; i++) {
	11	source.push(" x += x * i;");
	12	}
	13	source.push("}");
	14	var sourceString = source.join("\n");
	15	sourceSize = sourceString.length;
	16	var script = document.createElement("script");
	17	script.textContent = sourceString;
	18	document.head.appendChild(script);
	19	return sourceSize;
	20	}
	21
	22	function test()
	23	{
	24	InspectorTest.evaluateInPage("generateLongFunction()", didGenerateLongScript);
	25	function didGenerateLongScript(result) {
	26	var externalStringsExpectedMinimum = result.value;
	27	if (externalStringsExpectedMinimum < 1024 * 1024) {
	28	InspectorTest.addResult("FAIL: script is less than 1Mb: " + externalStringsExpectedMinimum);
	29	return InspectorTest.completeTest();
	30	}
	31	InspectorTest.validateMemoryBlockSize(["ProcessPrivateMemory", "JSExternalResources"], externalStringsExpectedMinimum);
	32	}
	33	}
	34	</script>
	35	</head>
	36
	37	<body onload="runTest()">
	38	<p>
	39	This test checks that page's external strings size reported by the memory agent
	40	includes size of script elements.<a href="https://bugs.webkit.org/show_bug.cgi?id=113788">Bug 113788.</a>
	41	</p>
	42	</body>
	43	</html>