Bug 113788 - Web Inspector: memory instrumentation for external strings is broken
Summary: Web Inspector: memory instrumentation for external strings is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 08:37 PDT by Yury Semikhatsky
Modified: 2013-04-02 11:15 PDT (History)
11 users (show)

See Also:

Attachments
Patch (8.75 KB, patch)
2013-04-02 08:43 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-04-02 08:37:40 PDT 
r144527 broke this when skipped all raw pointers in the memory instrumentation traversal algorithm. No we don't see JS externals strings in the native memory snapshot.
Comment 1 Yury Semikhatsky 2013-04-02 08:43:46 PDT 
Created attachment 196149 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-04-02 08:48:18 PDT 
Comment on attachment 196149 [details]
Patch

LGTM
Comment 3 WebKit Review Bot 2013-04-02 11:15:00 PDT 
Comment on attachment 196149 [details]
Patch

Clearing flags on attachment: 196149

Committed r147466: <http://trac.webkit.org/changeset/147466>
Comment 4 WebKit Review Bot 2013-04-02 11:15:04 PDT 
All reviewed patches have been landed.  Closing bug.