Attachment #195589 for bug #113512

View Details Raw Unified Return to Bug 113512



2013-03-28  Philippe Normand  <pnormand@igalia.com>

        [GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
        https://bugs.webkit.org/show_bug.cgi?id=113512

        Reviewed by NOBODY (OOPS!).

        When the HTTP source element is slow downloading data for on-disk
        buffering the playback position might reach an unbuffered region
        and have bad consequences, pausing the pipeline beforehand
        prevents this case to happen.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):

2013-03-28  ChangSeok Oh  <changseok.oh@collabora.com>

        [GTK][AC] Animating layer disappears while running with clutter backend

Lines 802-807 void MediaPlayerPrivateGStreamer::processBufferingStats(GstMessage* message) a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp_sec1
- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp -1 / +5 lines
802		802
803	m_fillTimer.startRepeating(0.2);	803	m_fillTimer.startRepeating(0.2);
804	}	804	}
		805
		806	if (!m_paused && (m_bufferingPercentage < 100)) {
		807	LOG_MEDIA_MESSAGE("[Buffering] Download in progress, pausing pipeline.");
		808	gst_element_set_state(m_playBin.get(), GST_STATE_PAUSED);
		809	}
805	}	810	}
806		811
807	void MediaPlayerPrivateGStreamer::fillTimerFired(Timer<MediaPlayerPrivateGStreamer>*)	812	void MediaPlayerPrivateGStreamer::fillTimerFired(Timer<MediaPlayerPrivateGStreamer>*)
808	-

Return to Bug 113512

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +15 lines
		1	2013-03-28 Philippe Normand <pnormand@igalia.com>
		2
		3	[GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
		4	https://bugs.webkit.org/show_bug.cgi?id=113512
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	When the HTTP source element is slow downloading data for on-disk
		9	buffering the playback position might reach an unbuffered region
		10	and have bad consequences, pausing the pipeline beforehand
		11	prevents this case to happen.
		12
		13	* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
		14	(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):
		15
1	2013-03-28 ChangSeok Oh <changseok.oh@collabora.com>	16	2013-03-28 ChangSeok Oh <changseok.oh@collabora.com>
2		17
3	[GTK][AC] Animating layer disappears while running with clutter backend	18	[GTK][AC] Animating layer disappears while running with clutter backend