Attachment #186372 for bug #108638

View Details Raw Unified Return to Bug 108638

| Differences between



2013-02-04  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Move IDBFactoryBackendInterface to WebCore
        https://bugs.webkit.org/show_bug.cgi?id=108638

        Reviewed by NOBODY (OOPS!).

        Part of a larger refactoring series; see tracking bug 106829.

        * Modules/indexeddb/chromium: Added.
        * Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.
        (WebCore):
        (WebCore::setIDBFactoryBackendInterfaceCreateFunction):
        (WebCore::IDBFactoryBackendInterface::create):
        * Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.
        (WebCore):
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:

2013-02-04  Dmitry Gozman  <dgozman@chromium.org>

        Web Inspector: Allow user to change dock side by dragging toolbar

Lines 778-783 Source/WebCore/WebCore.gypi_sec1
- Source/WebCore/WebCore.gypi +2 lines
778	'Modules/indexeddb/PageGroupIndexedDatabase.h',	778	'Modules/indexeddb/PageGroupIndexedDatabase.h',
779	'Modules/indexeddb/WorkerContextIndexedDatabase.cpp',	779	'Modules/indexeddb/WorkerContextIndexedDatabase.cpp',
780	'Modules/indexeddb/WorkerContextIndexedDatabase.h',	780	'Modules/indexeddb/WorkerContextIndexedDatabase.h',
		781	'Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp',
		782	'Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h',
781	'Modules/intents/DeliveredIntent.cpp',	783	'Modules/intents/DeliveredIntent.cpp',
782	'Modules/intents/DeliveredIntent.h',	784	'Modules/intents/DeliveredIntent.h',
783	'Modules/intents/DOMWindowIntents.cpp',	785	'Modules/intents/DOMWindowIntents.cpp',



/*
 * Copyright (C) 2010 Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
 *     notice, this list of conditions and the following disclaimer in the
 *     documentation and/or other materials provided with the distribution.
 * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
 *     its contributors may be used to endorse or promote products derived
 *     from this software without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
#include "config.h"
#include "IDBFactoryBackendInterfaceChromium.h"

#if ENABLE(INDEXED_DATABASE)

namespace WebCore {

static IDBFactoryBackendInterfaceCreate* s_idbFactoryBackendInterfaceCreateFunction = 0;

void setIDBFactoryBackendInterfaceCreateFunction(IDBFactoryBackendInterfaceCreate idbFactoryBackendInterfaceCreateFunction)
{
    s_idbFactoryBackendInterfaceCreateFunction = idbFactoryBackendInterfaceCreateFunction;
}

PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterface::create()
{
    ASSERT(s_idbFactoryBackendInterfaceCreateFunction);
    // There's no reason why we need to allocate a new proxy each time, but
    // there's also no strong reason not to.
    return s_idbFactoryBackendInterfaceCreateFunction();
}

} // namespace WebCore

#endif // ENABLE(INDEXED_DATABASE)



/*
 * Copyright (C) 2013 Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
 *     notice, this list of conditions and the following disclaimer in the
 *     documentation and/or other materials provided with the distribution.
 * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
 *     its contributors may be used to endorse or promote products derived
 *     from this software without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
#ifndef IDBFactoryBackendInterfaceChromium_h
#define IDBFactoryBackendInterfaceChromium_h

#include "IDBFactoryBackendInterface.h"

#if ENABLE(INDEXED_DATABASE)

namespace WebCore {

typedef PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterfaceCreate();

void setIDBFactoryBackendInterfaceCreateFunction(IDBFactoryBackendInterfaceCreate);

} // namespace WebCore

#endif

#endif // IDBFactoryBackendInterfaceChromium_h

Lines 58-63 Source/WebCore/WebCore.gyp/WebCore.gyp_sec1
- Source/WebCore/WebCore.gyp/WebCore.gyp +1 lines
58	'../Modules/geolocation',	58	'../Modules/geolocation',
59	'../Modules/intents',	59	'../Modules/intents',
60	'../Modules/indexeddb',	60	'../Modules/indexeddb',
		61	'../Modules/indexeddb/chromium',
61	'../Modules/mediasource',	62	'../Modules/mediasource',
62	'../Modules/mediastream',	63	'../Modules/mediastream',
63	'../Modules/navigatorcontentutils',	64	'../Modules/navigatorcontentutils',



2013-02-04  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Move IDBFactoryBackendInterface to WebCore
        https://bugs.webkit.org/show_bug.cgi?id=108638

        Reviewed by NOBODY (OOPS!).

        Part of a larger refactoring series; see tracking bug 106829.

        * WebKit.gyp:
        * src/AssertMatchingEnums.cpp:
        * src/IDBFactoryBackendInterface.cpp: Removed.
        * src/IDBFactoryBackendProxy.h:
        * src/WebKit.cpp:
        (WebKit::initializeWithoutV8):

2013-02-04  Sami Kyostila  <skyostil@chromium.org>

        Disable -webkit-overflow-scrolling CSS attribute on Chromium

Lines 370-376 Source/WebKit/chromium/WebKit.gyp_sec1
- Source/WebKit/chromium/WebKit.gyp -1 lines
370	'src/IDBDatabaseCallbacksProxy.h',	370	'src/IDBDatabaseCallbacksProxy.h',
371	'src/IDBDatabaseBackendProxy.cpp',	371	'src/IDBDatabaseBackendProxy.cpp',
372	'src/IDBDatabaseBackendProxy.h',	372	'src/IDBDatabaseBackendProxy.h',
373	'src/IDBFactoryBackendInterface.cpp',
374	'src/IDBFactoryBackendProxy.cpp',	373	'src/IDBFactoryBackendProxy.cpp',
375	'src/IDBFactoryBackendProxy.h',	374	'src/IDBFactoryBackendProxy.h',
376	'src/InspectorClientImpl.cpp',	375	'src/InspectorClientImpl.cpp',

Lines 56-62 Source/WebKit/chromium/src/AssertMatchingEnums.cpp_sec1
- Source/WebKit/chromium/src/AssertMatchingEnums.cpp -1 / +1 lines
56	#include "IDBCursor.h"	56	#include "IDBCursor.h"
57	#include "IDBDatabaseBackendInterface.h"	57	#include "IDBDatabaseBackendInterface.h"
58	#include "IDBDatabaseException.h"	58	#include "IDBDatabaseException.h"
59	#include "IDBFactoryBackendInterface.h"	59	#include "IDBFactoryBackendInterfaceChromium.h"
60	#include "IDBKey.h"	60	#include "IDBKey.h"
61	#include "IDBKeyPath.h"	61	#include "IDBKeyPath.h"
62	#include "IDBMetadata.h"	62	#include "IDBMetadata.h"



/*
 * Copyright (C) 2010 Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
 *     notice, this list of conditions and the following disclaimer in the
 *     documentation and/or other materials provided with the distribution.
 * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
 *     its contributors may be used to endorse or promote products derived
 *     from this software without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
#include "config.h"
#include "IDBFactoryBackendInterface.h"

#include "IDBFactoryBackendProxy.h"

#if ENABLE(INDEXED_DATABASE)

namespace WebCore {

PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterface::create()
{
    // There's no reason why we need to allocate a new proxy each time, but
    // there's also no strong reason not to.
    return WebKit::IDBFactoryBackendProxy::create();
}

} // namespace WebCore

#endif // ENABLE(INDEXED_DATABASE)

Lines 32-38 Source/WebKit/chromium/src/IDBFactoryBackendProxy.h_sec1
- Source/WebKit/chromium/src/IDBFactoryBackendProxy.h -1 / +1 lines
32	#if ENABLE(INDEXED_DATABASE)	32	#if ENABLE(INDEXED_DATABASE)
33		33
34	#include "IDBCallbacks.h"	34	#include "IDBCallbacks.h"
35	#include "IDBFactoryBackendInterface.h"	35	#include "IDBFactoryBackendInterfaceChromium.h"
36		36
37	namespace WebCore {	37	namespace WebCore {
38	class ScriptExecutionContext;	38	class ScriptExecutionContext;

Lines 53-58 Source/WebKit/chromium/src/WebKit.cpp_sec1
- Source/WebKit/chromium/src/WebKit.cpp +8 lines
53	#include <wtf/UnusedParam.h>	53	#include <wtf/UnusedParam.h>
54	#include <wtf/text/AtomicString.h>	54	#include <wtf/text/AtomicString.h>
55		55
		56	#if ENABLE(INDEXED_DATABASE)
		57	#include "IDBFactoryBackendProxy.h"
		58	#endif
		59
56	#if ENABLE(VIDEO)	60	#if ENABLE(VIDEO)
57	#include "MediaPlayerPrivateChromium.h"	61	#include "MediaPlayerPrivateChromium.h"
58	#include "WebMediaPlayerClientImpl.h"	62	#include "WebMediaPlayerClientImpl.h"
Lines 148-153 void initializeWithoutV8(WebKitPlatformS Source/WebKit/chromium/src/WebKit.cpp_sec2
148	// this, initializing this lazily probably doesn't buy us much.	152	// this, initializing this lazily probably doesn't buy us much.
149	WebCore::UTF8Encoding();	153	WebCore::UTF8Encoding();
150		154
		155	#if ENABLE(INDEXED_DATABASE)
		156	WebCore::setIDBFactoryBackendInterfaceCreateFunction(WebKit::IDBFactoryBackendProxy::create);
		157	#endif
		158
151	#if ENABLE(VIDEO)	159	#if ENABLE(VIDEO)
152	WebCore::MediaPlayerPrivate::setMediaEngineRegisterSelfFunction(WebKit::WebMediaPlayerClientImpl::registerSelf);	160	WebCore::MediaPlayerPrivate::setMediaEngineRegisterSelfFunction(WebKit::WebMediaPlayerClientImpl::registerSelf);
153	#endif	161	#endif

Return to Bug 108638

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +19 lines
		1	2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
		2
		3	[Chromium] Move IDBFactoryBackendInterface to WebCore
		4	https://bugs.webkit.org/show_bug.cgi?id=108638
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Part of a larger refactoring series; see tracking bug 106829.
		9
		10	* Modules/indexeddb/chromium: Added.
		11	* Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.
		12	(WebCore):
		13	(WebCore::setIDBFactoryBackendInterfaceCreateFunction):
		14	(WebCore::IDBFactoryBackendInterface::create):
		15	* Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.
		16	(WebCore):
		17	* WebCore.gyp/WebCore.gyp:
		18	* WebCore.gypi:
		19
1	2013-02-04 Dmitry Gozman <dgozman@chromium.org>	20	2013-02-04 Dmitry Gozman <dgozman@chromium.org>
2		21
3	Web Inspector: Allow user to change dock side by dragging toolbar	22	Web Inspector: Allow user to change dock side by dragging toolbar

Line 0 Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp_sec1
- Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp +52 lines
	1	/*
	2	* Copyright (C) 2010 Google Inc. All rights reserved.
	3	*
	4	* Redistribution and use in source and binary forms, with or without
	5	* modification, are permitted provided that the following conditions
	6	* are met:
	7	*
	8	* 1. Redistributions of source code must retain the above copyright
	9	* notice, this list of conditions and the following disclaimer.
	10	* 2. Redistributions in binary form must reproduce the above copyright
	11	* notice, this list of conditions and the following disclaimer in the
	12	* documentation and/or other materials provided with the distribution.
	13	* 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
	14	* its contributors may be used to endorse or promote products derived
	15	* from this software without specific prior written permission.
	16	*
	17	* THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
	18	* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
	19	* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
	20	* DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
	21	* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
	22	* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
	23	* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
	24	* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
	25	* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
	26	* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
	27	*/
	28	#include "config.h"
	29	#include "IDBFactoryBackendInterfaceChromium.h"
	30
	31	#if ENABLE(INDEXED_DATABASE)
	32
	33	namespace WebCore {
	34
	35	static IDBFactoryBackendInterfaceCreate* s_idbFactoryBackendInterfaceCreateFunction = 0;
	36
	37	void setIDBFactoryBackendInterfaceCreateFunction(IDBFactoryBackendInterfaceCreate idbFactoryBackendInterfaceCreateFunction)
	38	{
	39	s_idbFactoryBackendInterfaceCreateFunction = idbFactoryBackendInterfaceCreateFunction;
	40	}
	41
	42	PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterface::create()
	43	{
	44	ASSERT(s_idbFactoryBackendInterfaceCreateFunction);
	45	// There's no reason why we need to allocate a new proxy each time, but
	46	// there's also no strong reason not to.
	47	return s_idbFactoryBackendInterfaceCreateFunction();
	48	}
	49
	50	} // namespace WebCore
	51
	52	#endif // ENABLE(INDEXED_DATABASE)

Line 0 Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h_sec1
- Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h +45 lines
	1	/*
	2	* Copyright (C) 2013 Google Inc. All rights reserved.
	3	*
	4	* Redistribution and use in source and binary forms, with or without
	5	* modification, are permitted provided that the following conditions
	6	* are met:
	7	*
	8	* 1. Redistributions of source code must retain the above copyright
	9	* notice, this list of conditions and the following disclaimer.
	10	* 2. Redistributions in binary form must reproduce the above copyright
	11	* notice, this list of conditions and the following disclaimer in the
	12	* documentation and/or other materials provided with the distribution.
	13	* 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
	14	* its contributors may be used to endorse or promote products derived
	15	* from this software without specific prior written permission.
	16	*
	17	* THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
	18	* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
	19	* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
	20	* DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
	21	* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
	22	* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
	23	* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
	24	* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
	25	* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
	26	* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
	27	*/
	28	#ifndef IDBFactoryBackendInterfaceChromium_h
	29	#define IDBFactoryBackendInterfaceChromium_h
	30
	31	#include "IDBFactoryBackendInterface.h"
	32
	33	#if ENABLE(INDEXED_DATABASE)
	34
	35	namespace WebCore {
	36
	37	typedef PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendInterfaceCreate();
	38
	39	void setIDBFactoryBackendInterfaceCreateFunction(IDBFactoryBackendInterfaceCreate);
	40
	41	} // namespace WebCore
	42
	43	#endif
	44
	45	#endif // IDBFactoryBackendInterfaceChromium_h

Lines 1-3 Source/WebKit/chromium/ChangeLog_sec1
- Source/WebKit/chromium/ChangeLog +16 lines
		1	2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
		2
		3	[Chromium] Move IDBFactoryBackendInterface to WebCore
		4	https://bugs.webkit.org/show_bug.cgi?id=108638
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Part of a larger refactoring series; see tracking bug 106829.
		9
		10	* WebKit.gyp:
		11	* src/AssertMatchingEnums.cpp:
		12	* src/IDBFactoryBackendInterface.cpp: Removed.
		13	* src/IDBFactoryBackendProxy.h:
		14	* src/WebKit.cpp:
		15	(WebKit::initializeWithoutV8):
		16
1	2013-02-04 Sami Kyostila <skyostil@chromium.org>	17	2013-02-04 Sami Kyostila <skyostil@chromium.org>
2		18
3	Disable -webkit-overflow-scrolling CSS attribute on Chromium	19	Disable -webkit-overflow-scrolling CSS attribute on Chromium