Attachment #180228 for bug #105465

View Details Raw Unified Return to Bug 105465

| Differences between



2012-12-19  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] add setIDBFactory method for embedders to call
        https://bugs.webkit.org/show_bug.cgi?id=105465

        Reviewed by NOBODY (OOPS!).

        This is step 1 of getting rid of WebKitPlatform::idbFactory. This
        adds a setter for embedders to call upon initialization, which (if
        set) will be used instead of calling the idbFactory()
        method. Eventually the idbFactory() method will go away, and this
        setter will be the only way to initialize the Indexed Database API.

        * public/WebIDBFactory.h:
        (WebKit):
        * src/IDBFactoryBackendProxy.cpp:
        (WebKit):
        (WebKit::setIDBFactory):
        (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

2012-12-19  Alexis Menard  <alexis@webkit.org>

        Implement CSS parsing for CSS transitions unprefixed.

Lines 63-68 public: Source/WebKit/chromium/public/WebIDBFactory.h_sec1
- Source/WebKit/chromium/public/WebIDBFactory.h +3 lines
63	virtual void deleteDatabase(const WebString& name, WebIDBCallbacks, const WebSecurityOrigin&, WebFrame, const WebString& dataDir) { WEBKIT_ASSERT_NOT_REACHED(); }	63	virtual void deleteDatabase(const WebString& name, WebIDBCallbacks, const WebSecurityOrigin&, WebFrame, const WebString& dataDir) { WEBKIT_ASSERT_NOT_REACHED(); }
64	};	64	};
65		65
		66	// Initializes IndexedDB support.
		67	WEBKIT_EXPORT void setIDBFactory(WebIDBFactory*);
		68
66	} // namespace WebKit	69	} // namespace WebKit
67		70
68	#endif // WebIDBFactory_h	71	#endif // WebIDBFactory_h

Lines 61-74 using namespace WebCore; Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp_sec1
- Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp -1 / +11 lines
61		61
62	namespace WebKit {	62	namespace WebKit {
63		63
		64	static WebIDBFactory* s_webIDBFactory = 0;
		65
		66	void setIDBFactory(WebIDBFactory* factory)
		67	{
		68	s_webIDBFactory = factory;
		69	}
		70
64	PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendProxy::create()	71	PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendProxy::create()
65	{	72	{
66	return adoptRef(new IDBFactoryBackendProxy());	73	return adoptRef(new IDBFactoryBackendProxy());
67	}	74	}
68		75
69	IDBFactoryBackendProxy::IDBFactoryBackendProxy()	76	IDBFactoryBackendProxy::IDBFactoryBackendProxy()
70	: m_webIDBFactory(webKitPlatformSupport()->idbFactory())
71	{	77	{
		78	if (s_webIDBFactory)
		79	m_webIDBFactory = s_webIDBFactory;
		80	else
		81	m_webIDBFactory = webKitPlatformSupport()->idbFactory();
72	}	82	}
73		83
74	IDBFactoryBackendProxy::~IDBFactoryBackendProxy()	84	IDBFactoryBackendProxy::~IDBFactoryBackendProxy()

Return to Bug 105465

Lines 1-3 Source/WebKit/chromium/ChangeLog_sec1
- Source/WebKit/chromium/ChangeLog +20 lines
		1	2012-12-19 Mark Pilgrim <pilgrim@chromium.org>
		2
		3	[Chromium] add setIDBFactory method for embedders to call
		4	https://bugs.webkit.org/show_bug.cgi?id=105465
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	This is step 1 of getting rid of WebKitPlatform::idbFactory. This
		9	adds a setter for embedders to call upon initialization, which (if
		10	set) will be used instead of calling the idbFactory()
		11	method. Eventually the idbFactory() method will go away, and this
		12	setter will be the only way to initialize the Indexed Database API.
		13
		14	* public/WebIDBFactory.h:
		15	(WebKit):
		16	* src/IDBFactoryBackendProxy.cpp:
		17	(WebKit):
		18	(WebKit::setIDBFactory):
		19	(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
		20
1	2012-12-19 Alexis Menard <alexis@webkit.org>	21	2012-12-19 Alexis Menard <alexis@webkit.org>
2		22
3	Implement CSS parsing for CSS transitions unprefixed.	23	Implement CSS parsing for CSS transitions unprefixed.