Attachment #162770 for bug #96107

View Details Raw Unified Return to Bug 96107



2012-09-07  José Dapena Paz  <jdapena@igalia.com>

        [Gtk] Enable Resource Timing
        https://bugs.webkit.org/show_bug.cgi?id=96107

        Reviewed by NOBODY (OOPS!).

        Add settings for enabling PerformanceTimeline and ResourceTiming
        on Gtk+. Disabled by default.

        No new tests, as the features are disabled now. The tests
        covering this should be the ones for the ResourceTiming support.

        * DerivedSources.cpp:
        * GNUmakefile.am:
        * GNUmakefile.features.am:
        * GNUmakefile.list.am:
        * bindings/gobject/GNUmakefile.am:
        * page/Performance.h:
        * page/PerformanceEntry.h:

2012-09-05  Tim Horton  <timothy_horton@apple.com>

        Unreviewed; revert a change to ScrollingTreeNodeMac which accidentally

Lines 268-273 a/Source/WebCore/DerivedSources.cpp_sec1
- a/Source/WebCore/DerivedSources.cpp +2 lines
268	#include "JSOverflowEvent.cpp"	268	#include "JSOverflowEvent.cpp"
269	#include "JSPageTransitionEvent.cpp"	269	#include "JSPageTransitionEvent.cpp"
270	#include "JSPerformance.cpp"	270	#include "JSPerformance.cpp"
		271	#include "JSPerformanceEntry.cpp"
		272	#include "JSPerformanceEntryList.cpp"
271	#include "JSPerformanceNavigation.cpp"	273	#include "JSPerformanceNavigation.cpp"
272	#include "JSPerformanceTiming.cpp"	274	#include "JSPerformanceTiming.cpp"
273	#include "JSPopStateEvent.cpp"	275	#include "JSPopStateEvent.cpp"



endif  # END ENABLE_WEB_TIMING

# ---
# Performance Timeline support
# ---
if ENABLE_PERFORMANCE_TIMELINE
feature_defines_overrides += ENABLE_PERFORMANCE_TIMELINE=1
else
feature_defines_overrides += ENABLE_PERFORMANCE_TIMELINE=0
endif  # END ENABLE_PERFORMANCE_TIMELINE

# ---
# Resource Timing support
# ---
if ENABLE_RESOURCE_TIMING
feature_defines_overrides += ENABLE_RESOURCE_TIMING=1
else
feature_defines_overrides += ENABLE_RESOURCE_TIMING=0
endif  # END ENABLE_RESOURCE_TIMING

# ---
# HTML iframe seamless attribute support
# ---
if ENABLE_IFRAME_SEAMLESS



	ENABLE_NOTIFICATIONS=0 \
	ENABLE_ORIENTATION_EVENTS=0 \
	ENABLE_PAGE_VISIBILITY_API=0 \
	ENABLE_PERFORMANCE_TIMELINE=1 \
	ENABLE_PROGRESS_ELEMENT=1 \
	ENABLE_QUOTA=0 \
	ENABLE_REQUEST_ANIMATION_FRAME=1 \
	ENABLE_RESOURCE_TIMING=1 \
	ENABLE_SCRIPTED_SPEECH=0 \
	ENABLE_SHADOW_DOM=1 \
	ENABLE_SHARED_WORKERS=1 \

Lines 599-604 webcore_built_sources += \ a/Source/WebCore/GNUmakefile.list.am_sec1
- a/Source/WebCore/GNUmakefile.list.am +2 lines
599	DerivedSources/WebCore/JSPerformanceNavigation.h \	599	DerivedSources/WebCore/JSPerformanceNavigation.h \
600	DerivedSources/WebCore/JSPerformanceTiming.cpp \	600	DerivedSources/WebCore/JSPerformanceTiming.cpp \
601	DerivedSources/WebCore/JSPerformanceTiming.h \	601	DerivedSources/WebCore/JSPerformanceTiming.h \
		602	DerivedSources/WebCore/JSPerformanceResourceTiming.cpp \
		603	DerivedSources/WebCore/JSPerformanceResourceTiming.h \
602	DerivedSources/WebCore/JSPopStateEvent.cpp \	604	DerivedSources/WebCore/JSPopStateEvent.cpp \
603	DerivedSources/WebCore/JSPopStateEvent.h \	605	DerivedSources/WebCore/JSPopStateEvent.h \
604	DerivedSources/WebCore/JSPositionCallback.cpp \	606	DerivedSources/WebCore/JSPositionCallback.cpp \



	DerivedSources/webkit/WebKitDOMPerformanceTimingPrivate.h
endif

if ENABLE_PERFORMANCE_TIMELINE
webkitgtk_built_h_api += \
	DerivedSources/webkit/WebKitDOMPerformanceEntry.h \
	DerivedSources/webkit/WebKitDOMPerformanceEntryList.h
webkitgtk_gdom_built_sources += \
	DerivedSources/webkit/WebKitDOMPerformanceEntry.cpp \
	DerivedSources/webkit/WebKitDOMPerformanceEntryPrivate.h \
	DerivedSources/webkit/WebKitDOMPerformanceEntryList.cpp \
	DerivedSources/webkit/WebKitDOMPerformanceEntryListPrivate.h
endif

if ENABLE_RESOURCE_TIMING
webkitgtk_built_h_api += \
	DerivedSources/webkit/WebKitDOMPerformanceResourceTiming.h
webkitgtk_gdom_built_sources += \
	DerivedSources/webkit/WebKitDOMPerformanceResourceTiming.cpp \
	DerivedSources/webkit/WebKitDOMPerformanceResourceTiming.h
endif

gdom_class_list := $(subst WebKitDOM,, $(filter-out %Private, $(basename $(notdir $(webkitgtk_gdom_built_sources)))))
gdom_class_list += Custom EventTarget Object
DerivedSources/webkit/webkitdom.h: $(WebCore)/bindings/scripts/gobject-generate-headers.pl $(WebCore)/bindings/gobject/GNUmakefile.am

Lines 36-41 a/Source/WebCore/page/Performance.h_sec1
- a/Source/WebCore/page/Performance.h +1 lines
36	#include "DOMWindowProperty.h"	36	#include "DOMWindowProperty.h"
37	#include "EventTarget.h"	37	#include "EventTarget.h"
38	#include "MemoryInfo.h"	38	#include "MemoryInfo.h"
		39	#include "PerformanceEntry.h"
39	#include "PerformanceEntryList.h"	40	#include "PerformanceEntryList.h"
40	#include "PerformanceNavigation.h"	41	#include "PerformanceNavigation.h"
41	#include "PerformanceTiming.h"	42	#include "PerformanceTiming.h"




#if ENABLE(WEB_TIMING) && ENABLE(PERFORMANCE_TIMELINE)

#include "Performance.h"
#include <wtf/PassRefPtr.h>
#include <wtf/RefCounted.h>
#include <wtf/text/WTFString.h>


}

#endif // ENABLE(WEB_TIMING) && ENABLE(PERFORMANCE_TIMELINE)
#endif // !defined(PerformanceEntry_h)



2012-09-07  José Dapena Paz  <jdapena@igalia.com>

        [Gtk] Enable Resource Timing
        https://bugs.webkit.org/show_bug.cgi?id=96107

        Reviewed by NOBODY (OOPS!).

        Add settings for enabling PerformanceTimeline and ResourceTiming
        on Gtk+. Disabled by default.

        * configure.ac:

2012-09-05  George Staikos  <staikos@webkit.org>

        [BlackBerry] Match th ebuild flags from the platform library



              [],[enable_web_timing=$enable_unstable_features])
AC_MSG_RESULT([$enable_web_timing])

# check whether to enable Performance Timeline support
AC_MSG_CHECKING([whether to enable Performance Timeline support])
AC_ARG_ENABLE(performance_timeline,
              AC_HELP_STRING([--enable-performance-timeline],
                             [enable support for Performance Timeline (experimental) [default=no]]),
              [],[enable_performance_timeline=$enable_unstable_features])
AC_MSG_RESULT([$enable_performance_timeline])

# check whether to enable Resource Timing support
AC_MSG_CHECKING([whether to enable Resource Timing support])
AC_ARG_ENABLE(resource_timing,
              AC_HELP_STRING([--enable-resource-timing],
                             [enable support for Resource Timing (experimental and incomplete) [default=no]]),
              [],[enable_resource_timing=$enable_unstable_features])
AC_MSG_RESULT([$enable_resource_timing])
if test "$enable_resource_timing" = "yes" && test "$enable_performance_timeline" != "yes"; then
   AC_MSG_ERROR([Performance timeline is required for Resource timing])
fi

# check whether to enable Blob support
AC_MSG_CHECKING([whether to enable Blob support])
AC_ARG_ENABLE(blob,

AM_CONDITIONAL([ENABLE_WEB_SOCKETS],[test "$enable_web_sockets" = "yes"])
AM_CONDITIONAL([ENABLE_WEB_AUDIO],[test "$enable_web_audio" = "yes"])
AM_CONDITIONAL([ENABLE_WEB_TIMING],[test "$enable_web_timing" = "yes"])
AM_CONDITIONAL([ENABLE_PERFORMANCE_TIMELINE],[test "$enable_performance_timeline" = "yes"])
AM_CONDITIONAL([ENABLE_RESOURCE_TIMING],[test "$enable_resource_timing" = "yes"])
AM_CONDITIONAL([ENABLE_OPCODE_STATS],[test "$enable_opcode_stats" = "yes"])
AM_CONDITIONAL([ENABLE_WEBKIT2],[test "$enable_webkit2" = "yes"])
AM_CONDITIONAL([ENABLE_PLUGIN_PROCESS],[test "$enable_plugin_process" = "yes"])

 Media stream support                                     : $enable_media_stream
 Opcode stats                                             : $enable_opcode_stats
 Page Visibility API support                              : $enable_page_visibility_api
 Performance Timeline support                             : $enable_performance_timeline
 Quota API support                                        : $enable_quota
 Register Protocol Handler support                        : $enable_register_protocol_handler
 RequestAnimationFrame support                            : $enable_request_animation_frame
 Resource Timing support                                  : $enable_resource_timing
 SQL client-side database storage support                 : $enable_sql_database
 SVG fonts support                                        : $enable_svg_fonts
 SVG support                                              : $enable_svg

Return to Bug 96107

Lines 721-726 feature_defines_overrides += ENABLE_WEB_TIMING=0 a/Source/WebCore/GNUmakefile.am_sec1
- a/Source/WebCore/GNUmakefile.am +18 lines
721	endif # END ENABLE_WEB_TIMING	721	endif # END ENABLE_WEB_TIMING
722		722
723	# ---	723	# ---
		724	# Performance Timeline support
		725	# ---
		726	if ENABLE_PERFORMANCE_TIMELINE
		727	feature_defines_overrides += ENABLE_PERFORMANCE_TIMELINE=1
		728	else
		729	feature_defines_overrides += ENABLE_PERFORMANCE_TIMELINE=0
		730	endif # END ENABLE_PERFORMANCE_TIMELINE
		731
		732	# ---
		733	# Resource Timing support
		734	# ---
		735	if ENABLE_RESOURCE_TIMING
		736	feature_defines_overrides += ENABLE_RESOURCE_TIMING=1
		737	else
		738	feature_defines_overrides += ENABLE_RESOURCE_TIMING=0
		739	endif # END ENABLE_RESOURCE_TIMING
		740
		741	# ---
724	# HTML iframe seamless attribute support	742	# HTML iframe seamless attribute support
725	# ---	743	# ---
726	if ENABLE_IFRAME_SEAMLESS	744	if ENABLE_IFRAME_SEAMLESS

Lines 459-464 webkitgtk_gdom_built_sources += \ a/Source/WebCore/bindings/gobject/GNUmakefile.am_sec1
- a/Source/WebCore/bindings/gobject/GNUmakefile.am +19 lines
459	DerivedSources/webkit/WebKitDOMPerformanceTimingPrivate.h	459	DerivedSources/webkit/WebKitDOMPerformanceTimingPrivate.h
460	endif	460	endif
461		461
		462	if ENABLE_PERFORMANCE_TIMELINE
		463	webkitgtk_built_h_api += \
		464	DerivedSources/webkit/WebKitDOMPerformanceEntry.h \
		465	DerivedSources/webkit/WebKitDOMPerformanceEntryList.h
		466	webkitgtk_gdom_built_sources += \
		467	DerivedSources/webkit/WebKitDOMPerformanceEntry.cpp \
		468	DerivedSources/webkit/WebKitDOMPerformanceEntryPrivate.h \
		469	DerivedSources/webkit/WebKitDOMPerformanceEntryList.cpp \
		470	DerivedSources/webkit/WebKitDOMPerformanceEntryListPrivate.h
		471	endif
		472
		473	if ENABLE_RESOURCE_TIMING
		474	webkitgtk_built_h_api += \
		475	DerivedSources/webkit/WebKitDOMPerformanceResourceTiming.h
		476	webkitgtk_gdom_built_sources += \
		477	DerivedSources/webkit/WebKitDOMPerformanceResourceTiming.cpp \
		478	DerivedSources/webkit/WebKitDOMPerformanceResourceTiming.h
		479	endif
		480
462	gdom_class_list := $(subst WebKitDOM,, $(filter-out %Private, $(basename $(notdir $(webkitgtk_gdom_built_sources)))))	481	gdom_class_list := $(subst WebKitDOM,, $(filter-out %Private, $(basename $(notdir $(webkitgtk_gdom_built_sources)))))
463	gdom_class_list += Custom EventTarget Object	482	gdom_class_list += Custom EventTarget Object
464	DerivedSources/webkit/webkitdom.h: $(WebCore)/bindings/scripts/gobject-generate-headers.pl $(WebCore)/bindings/gobject/GNUmakefile.am	483	DerivedSources/webkit/webkitdom.h: $(WebCore)/bindings/scripts/gobject-generate-headers.pl $(WebCore)/bindings/gobject/GNUmakefile.am

Lines 972-977 AC_ARG_ENABLE(web_timing, a/configure.ac_sec1
- a/configure.ac +23 lines
972	[],[enable_web_timing=$enable_unstable_features])	972	[],[enable_web_timing=$enable_unstable_features])
973	AC_MSG_RESULT([$enable_web_timing])	973	AC_MSG_RESULT([$enable_web_timing])
974		974
		975	# check whether to enable Performance Timeline support
		976	AC_MSG_CHECKING([whether to enable Performance Timeline support])
		977	AC_ARG_ENABLE(performance_timeline,
		978	AC_HELP_STRING([--enable-performance-timeline],
		979	[enable support for Performance Timeline (experimental) [default=no]]),
		980	[],[enable_performance_timeline=$enable_unstable_features])
		981	AC_MSG_RESULT([$enable_performance_timeline])
		982
		983	# check whether to enable Resource Timing support
		984	AC_MSG_CHECKING([whether to enable Resource Timing support])
		985	AC_ARG_ENABLE(resource_timing,
		986	AC_HELP_STRING([--enable-resource-timing],
		987	[enable support for Resource Timing (experimental and incomplete) [default=no]]),
		988	[],[enable_resource_timing=$enable_unstable_features])
		989	AC_MSG_RESULT([$enable_resource_timing])
		990	if test "$enable_resource_timing" = "yes" && test "$enable_performance_timeline" != "yes"; then
		991	AC_MSG_ERROR([Performance timeline is required for Resource timing])
		992	fi
		993
975	# check whether to enable Blob support	994	# check whether to enable Blob support
976	AC_MSG_CHECKING([whether to enable Blob support])	995	AC_MSG_CHECKING([whether to enable Blob support])
977	AC_ARG_ENABLE(blob,	996	AC_ARG_ENABLE(blob,
Lines 1477-1482 AM_CONDITIONAL([ENABLE_SHARED_WORKERS],[test "$enable_shared_workers" = "yes"]) a/configure.ac_sec2
1477	AM_CONDITIONAL([ENABLE_WEB_SOCKETS],[test "$enable_web_sockets" = "yes"])	1496	AM_CONDITIONAL([ENABLE_WEB_SOCKETS],[test "$enable_web_sockets" = "yes"])
1478	AM_CONDITIONAL([ENABLE_WEB_AUDIO],[test "$enable_web_audio" = "yes"])	1497	AM_CONDITIONAL([ENABLE_WEB_AUDIO],[test "$enable_web_audio" = "yes"])
1479	AM_CONDITIONAL([ENABLE_WEB_TIMING],[test "$enable_web_timing" = "yes"])	1498	AM_CONDITIONAL([ENABLE_WEB_TIMING],[test "$enable_web_timing" = "yes"])
		1499	AM_CONDITIONAL([ENABLE_PERFORMANCE_TIMELINE],[test "$enable_performance_timeline" = "yes"])
		1500	AM_CONDITIONAL([ENABLE_RESOURCE_TIMING],[test "$enable_resource_timing" = "yes"])
1480	AM_CONDITIONAL([ENABLE_OPCODE_STATS],[test "$enable_opcode_stats" = "yes"])	1501	AM_CONDITIONAL([ENABLE_OPCODE_STATS],[test "$enable_opcode_stats" = "yes"])
1481	AM_CONDITIONAL([ENABLE_WEBKIT2],[test "$enable_webkit2" = "yes"])	1502	AM_CONDITIONAL([ENABLE_WEBKIT2],[test "$enable_webkit2" = "yes"])
1482	AM_CONDITIONAL([ENABLE_PLUGIN_PROCESS],[test "$enable_plugin_process" = "yes"])	1503	AM_CONDITIONAL([ENABLE_PLUGIN_PROCESS],[test "$enable_plugin_process" = "yes"])
Lines 1586-1594 Features: a/configure.ac_sec3
1586	Media stream support : $enable_media_stream	1607	Media stream support : $enable_media_stream
1587	Opcode stats : $enable_opcode_stats	1608	Opcode stats : $enable_opcode_stats
1588	Page Visibility API support : $enable_page_visibility_api	1609	Page Visibility API support : $enable_page_visibility_api
		1610	Performance Timeline support : $enable_performance_timeline
1589	Quota API support : $enable_quota	1611	Quota API support : $enable_quota
1590	Register Protocol Handler support : $enable_register_protocol_handler	1612	Register Protocol Handler support : $enable_register_protocol_handler
1591	RequestAnimationFrame support : $enable_request_animation_frame	1613	RequestAnimationFrame support : $enable_request_animation_frame
		1614	Resource Timing support : $enable_resource_timing
1592	SQL client-side database storage support : $enable_sql_database	1615	SQL client-side database storage support : $enable_sql_database
1593	SVG fonts support : $enable_svg_fonts	1616	SVG fonts support : $enable_svg_fonts
1594	SVG support : $enable_svg	1617	SVG support : $enable_svg

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +21 lines
		1	2012-09-07 José Dapena Paz <jdapena@igalia.com>
		2
		3	[Gtk] Enable Resource Timing
		4	https://bugs.webkit.org/show_bug.cgi?id=96107
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Add settings for enabling PerformanceTimeline and ResourceTiming
		9	on Gtk+. Disabled by default.
		10
		11	No new tests, as the features are disabled now. The tests
		12	covering this should be the ones for the ResourceTiming support.
		13
		14	* DerivedSources.cpp:
		15	* GNUmakefile.am:
		16	* GNUmakefile.features.am:
		17	* GNUmakefile.list.am:
		18	* bindings/gobject/GNUmakefile.am:
		19	* page/Performance.h:
		20	* page/PerformanceEntry.h:
		21
1	2012-09-05 Tim Horton <timothy_horton@apple.com>	22	2012-09-05 Tim Horton <timothy_horton@apple.com>
2		23
3	Unreviewed; revert a change to ScrollingTreeNodeMac which accidentally	24	Unreviewed; revert a change to ScrollingTreeNodeMac which accidentally

Lines 65-73 feature_defines_defaults += \ a/Source/WebCore/GNUmakefile.features.am_sec1
- a/Source/WebCore/GNUmakefile.features.am +2 lines
65	ENABLE_NOTIFICATIONS=0 \	65	ENABLE_NOTIFICATIONS=0 \
66	ENABLE_ORIENTATION_EVENTS=0 \	66	ENABLE_ORIENTATION_EVENTS=0 \
67	ENABLE_PAGE_VISIBILITY_API=0 \	67	ENABLE_PAGE_VISIBILITY_API=0 \
		68	ENABLE_PERFORMANCE_TIMELINE=1 \
68	ENABLE_PROGRESS_ELEMENT=1 \	69	ENABLE_PROGRESS_ELEMENT=1 \
69	ENABLE_QUOTA=0 \	70	ENABLE_QUOTA=0 \
70	ENABLE_REQUEST_ANIMATION_FRAME=1 \	71	ENABLE_REQUEST_ANIMATION_FRAME=1 \
		72	ENABLE_RESOURCE_TIMING=1 \
71	ENABLE_SCRIPTED_SPEECH=0 \	73	ENABLE_SCRIPTED_SPEECH=0 \
72	ENABLE_SHADOW_DOM=1 \	74	ENABLE_SHADOW_DOM=1 \
73	ENABLE_SHARED_WORKERS=1 \	75	ENABLE_SHARED_WORKERS=1 \

Lines 33-39 a/Source/WebCore/page/PerformanceEntry.h_sec1
- a/Source/WebCore/page/PerformanceEntry.h -2 / +1 lines
33		33
34	#if ENABLE(WEB_TIMING) && ENABLE(PERFORMANCE_TIMELINE)	34	#if ENABLE(WEB_TIMING) && ENABLE(PERFORMANCE_TIMELINE)
35		35
36	#include "Performance.h"
37	#include <wtf/PassRefPtr.h>	36	#include <wtf/PassRefPtr.h>
38	#include <wtf/RefCounted.h>	37	#include <wtf/RefCounted.h>
39	#include <wtf/text/WTFString.h>	38	#include <wtf/text/WTFString.h>
Lines 63-67 private: a/Source/WebCore/page/PerformanceEntry.h_sec2
63		62
64	}	63	}
65		64
66	#endif // !ENABLE(WEB_TIMING) && ENABLE(PERFORMANCE_TIMELINE)	65	#endif // ENABLE(WEB_TIMING) && ENABLE(PERFORMANCE_TIMELINE)
67	#endif // !defined(PerformanceEntry_h)	66	#endif // !defined(PerformanceEntry_h)

Lines 1-3 a/ChangeLog_sec1
- a/ChangeLog +12 lines
		1	2012-09-07 José Dapena Paz <jdapena@igalia.com>
		2
		3	[Gtk] Enable Resource Timing
		4	https://bugs.webkit.org/show_bug.cgi?id=96107
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Add settings for enabling PerformanceTimeline and ResourceTiming
		9	on Gtk+. Disabled by default.
		10
		11	* configure.ac:
		12
1	2012-09-05 George Staikos <staikos@webkit.org>	13	2012-09-05 George Staikos <staikos@webkit.org>
2		14
3	[BlackBerry] Match th ebuild flags from the platform library	15	[BlackBerry] Match th ebuild flags from the platform library