Attachment #141051 for bug #86038

View Details Raw Unified Return to Bug 86038



2012-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r116573.
        http://trac.webkit.org/changeset/116573
        https://bugs.webkit.org/show_bug.cgi?id=86038

        Broke the Chromium Mac compile (Requested by ojan_gardening on
        #webkit).

        * public/WebPlugin.h:
        (WebPlugin):

2012-05-09  Fady Samuel  <fsamuel@chromium.org>

        [Chromium] Expose WebPluginContainer of WebPlugin to embedder



    virtual bool initialize(WebPluginContainer*) = 0;
    virtual void destroy() = 0;

    virtual WebPluginContainer* container() const { return 0; }

    virtual NPObject* scriptableObject() = 0;

    // Returns true if the form submission value is successfully obtained

Return to Bug 86038

Lines 1-3 a/Source/WebKit/chromium/ChangeLog_sec1
- a/Source/WebKit/chromium/ChangeLog +12 lines
		1	2012-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
		2
		3	Unreviewed, rolling out r116573.
		4	http://trac.webkit.org/changeset/116573
		5	https://bugs.webkit.org/show_bug.cgi?id=86038
		6
		7	Broke the Chromium Mac compile (Requested by ojan_gardening on
		8	#webkit).
		9
		10	* public/WebPlugin.h:
		11	(WebPlugin):
		12
1	2012-05-09 Fady Samuel <fsamuel@chromium.org>	13	2012-05-09 Fady Samuel <fsamuel@chromium.org>
2		14
3	[Chromium] Expose WebPluginContainer of WebPlugin to embedder	15	[Chromium] Expose WebPluginContainer of WebPlugin to embedder

Lines 56-63 public: a/Source/WebKit/chromium/public/WebPlugin.h_sec1
- a/Source/WebKit/chromium/public/WebPlugin.h -2 lines
56	virtual bool initialize(WebPluginContainer*) = 0;	56	virtual bool initialize(WebPluginContainer*) = 0;
57	virtual void destroy() = 0;	57	virtual void destroy() = 0;
58		58
59	virtual WebPluginContainer* container() const { return 0; }
60
61	virtual NPObject* scriptableObject() = 0;	59	virtual NPObject* scriptableObject() = 0;
62		60
63	// Returns true if the form submission value is successfully obtained	61	// Returns true if the form submission value is successfully obtained