Attachment #115143 for bug #72013

View Details Raw Unified Return to Bug 72013

| Differences between



2011-11-15  Rosen Dash  <rosen.dash@motorola.com>

        Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes.
        https://bugs.webkit.org/show_bug.cgi?id=72013

        Reviewed by NOBODY (OOPS!).

        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype.afterShow): Caret is moved inside query prompt after tab
        key pressed on corrresponding Resource Panel Element.
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.DatabaseTreeElement.prototype.onpopulate.tableNamesCallback.get this):
        (WebInspector.DatabaseTreeElement.prototype.onpopulate): Removing and adding children while populating
        is done at same place to avoid inconsistent behaviour.
        (WebInspector.DatabaseTreeElement.prototype.ontab): Added.
        * inspector/front-end/treeoutline.js:
        (TreeOutline.prototype._treeKeyDown): Tab key press is handled.

2011-11-14  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: [regression r99960] null callback access.



}

WebInspector.DatabaseQueryView.prototype = {
    afterShow: function()
    {
        WebInspector.setCurrentFocusElement(this._promptElement);
    },

    afterTab: function()
    {
        function moveBackIfOutside()
        {

        setTimeout(moveBackIfOutside.bind(this), 0);
    },

    afterShow: function()
    {
        WebInspector.setCurrentFocusElement(this._promptElement);
    },

    completions: function(wordRange, force, completionsReadyCallback)
    {
        var prefix = wordRange.toString().toLowerCase();

Lines 1-6 a/Source/WebCore/inspector/front-end/ResourcesPanel.js_sec1
- a/Source/WebCore/inspector/front-end/ResourcesPanel.js -4 / +19 lines
1	/*	1	/*
2	* Copyright (C) 2007, 2008, 2010 Apple Inc. All rights reserved.	2	* Copyright (C) 2007, 2008, 2010 Apple Inc. All rights reserved.
3	* Copyright (C) 2009 Joseph Pecoraro	3	* Copyright (C) 2009 Joseph Pecoraro
		4	* Portions Copyright (C) 2011 Motorola Mobility, Inc. All rights reserved.
4	*	5	*
5	* Redistribution and use in source and binary forms, with or without	6	* Redistribution and use in source and binary forms, with or without
6	* modification, are permitted provided that the following conditions	7	* modification, are permitted provided that the following conditions
Lines 1457-1471 WebInspector.DatabaseTreeElement.prototype = { a/Source/WebCore/inspector/front-end/ResourcesPanel.js_sec2
1457		1458
1458	onpopulate: function()	1459	onpopulate: function()
1459	{	1460	{
1460	this.removeChildren();
1461
1462	function tableNamesCallback(tableNames)	1461	function tableNamesCallback(tableNames)
1463	{	1462	{
		1463	var itemURL = WebInspector.settings.resourcesLastSelectedItem.get();
		1464	this.removeChildren();
		1465
1464	var tableNamesLength = tableNames.length;	1466	var tableNamesLength = tableNames.length;
1465	for (var i = 0; i < tableNamesLength; ++i)	1467	for (var i = 0; i < tableNamesLength; ++i) {
1466	this.appendChild(new WebInspector.DatabaseTableTreeElement(this._storagePanel, this._database, tableNames[i]));	1468	var element = new WebInspector.DatabaseTableTreeElement(this._storagePanel, this._database, tableNames[i]);
		1469	this.appendChild(element);
		1470	if (itemURL && itemURL === element.itemURL)
		1471	element.revealAndSelect();
		1472	}
1467	}	1473	}
1468	this._database.getTableNames(tableNamesCallback.bind(this));	1474	this._database.getTableNames(tableNamesCallback.bind(this));
		1475	},
		1476
		1477	ontab: function()
		1478	{
		1479	if (this._database && this._database._queryView) {
		1480	view = this._database._queryView;
		1481	if (view.afterTab)
		1482	view.afterTab();
		1483	}
1469	}	1484	}
1470	}	1485	}
1471		1486

Lines 404-409 TreeOutline.prototype._treeKeyDown = function(event) a/Source/WebCore/inspector/front-end/treeoutline.js_sec1
- a/Source/WebCore/inspector/front-end/treeoutline.js +3 lines
404	} else if (isEnterKey(event)) {	404	} else if (isEnterKey(event)) {
405	if (this.selectedTreeElement.onenter)	405	if (this.selectedTreeElement.onenter)
406	handled = this.selectedTreeElement.onenter();	406	handled = this.selectedTreeElement.onenter();
		407	} else if (event.keyCode === 9 /* Tab */) {
		408	if (this.selectedTreeElement.ontab)
		409	handled = this.selectedTreeElement.ontab();
407	}	410	}
408		411
409	if (nextSelectedElement) {	412	if (nextSelectedElement) {

Return to Bug 72013

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +18 lines
		1	2011-11-15 Rosen Dash <rosen.dash@motorola.com>
		2
		3	Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes.
		4	https://bugs.webkit.org/show_bug.cgi?id=72013
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* inspector/front-end/DatabaseQueryView.js:
		9	(WebInspector.DatabaseQueryView.prototype.afterShow): Caret is moved inside query prompt after tab
		10	key pressed on corrresponding Resource Panel Element.
		11	* inspector/front-end/ResourcesPanel.js:
		12	(WebInspector.DatabaseTreeElement.prototype.onpopulate.tableNamesCallback.get this):
		13	(WebInspector.DatabaseTreeElement.prototype.onpopulate): Removing and adding children while populating
		14	is done at same place to avoid inconsistent behaviour.
		15	(WebInspector.DatabaseTreeElement.prototype.ontab): Added.
		16	* inspector/front-end/treeoutline.js:
		17	(TreeOutline.prototype._treeKeyDown): Tab key press is handled.
		18
1	2011-11-14 Pavel Feldman <pfeldman@google.com>	19	2011-11-14 Pavel Feldman <pfeldman@google.com>
2		20
3	Web Inspector: [regression r99960] null callback access.	21	Web Inspector: [regression r99960] null callback access.

Lines 54-60 WebInspector.DatabaseQueryView.Events = { a/Source/WebCore/inspector/front-end/DatabaseQueryView.js_sec1
- a/Source/WebCore/inspector/front-end/DatabaseQueryView.js -6 / +6 lines
54	}	54	}
55		55
56	WebInspector.DatabaseQueryView.prototype = {	56	WebInspector.DatabaseQueryView.prototype = {
57	wasShown: function()	57	afterShow: function()
		58	{
		59	WebInspector.setCurrentFocusElement(this._promptElement);
		60	},
		61
		62	afterTab: function()
58	{	63	{
59	function moveBackIfOutside()	64	function moveBackIfOutside()
60	{	65	{
Lines 65-75 WebInspector.DatabaseQueryView.prototype = { a/Source/WebCore/inspector/front-end/DatabaseQueryView.js_sec2
65	setTimeout(moveBackIfOutside.bind(this), 0);	70	setTimeout(moveBackIfOutside.bind(this), 0);
66	},	71	},
67		72
68	afterShow: function()
69	{
70	WebInspector.setCurrentFocusElement(this._promptElement);
71	},
72
73	completions: function(wordRange, force, completionsReadyCallback)	73	completions: function(wordRange, force, completionsReadyCallback)
74	{	74	{
75	var prefix = wordRange.toString().toLowerCase();	75	var prefix = wordRange.toString().toLowerCase();