Bug 9938 - Fix viewBox issues in Hixie's test
Summary: Fix viewBox issues in Hixie's test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 6018
  Show dependency tree / graph
 
Reported: 2006-07-15 12:45 PDT by Rob Buis
Modified: 2006-07-27 00:40 PDT (History)
0 users

See Also:

Attachments
First attempt (2.91 KB, patch)
2006-07-15 13:24 PDT, Rob Buis 		darin: review-
Details | Formatted Diff | Diff
Now with testcase (25.61 KB, patch)
2006-07-25 11:17 PDT, Rob Buis 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2006-07-15 12:45:48 PDT 
Fix viewBox issues in tests error/010.xml and error/011.xml of Hixie's svg tests, see
bug 6018.
Comment 1 Rob Buis 2006-07-15 13:24:07 PDT 
Created attachment 9467 [details]
First attempt

This patch should fix the problem. Let me know if the bug requires testcases, like
Hixie's 010 and 011 error tests.
Cheers,

Rob.
Comment 2 Rob Buis 2006-07-15 14:24:06 PDT 
Test for new email address, ignore.

(In reply to comment #1)
> Created an attachment (id=9467) [edit]
> First attempt
> 
> This patch should fix the problem. Let me know if the bug requires testcases,
> like
> Hixie's 010 and 011 error tests.
> Cheers,
> 
> Rob.
>
Comment 3 Darin Adler 2006-07-24 21:20:18 PDT 
Comment on attachment 9467 [details]
First attempt

Code change looks OK. Ideally we'd do the work without converting the string to ASCII.

But the patch doesn't include a test case or changes to existing test results. So review- just for that.
Comment 4 Rob Buis 2006-07-25 11:17:12 PDT 
Created attachment 9681 [details]
Now with testcase

The new patch has the two testcases, taken literally from Hixie's tests but renamed. Also
included are the .png, .checksum files, not sure whether they need to be part of this patch, but
I'll need them for landing for sure :)
Cheers,

Rob.
Comment 5 Darin Adler 2006-07-26 13:58:16 PDT 
Comment on attachment 9681 [details]
Now with testcase

r=me