Bug 9928 – REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alexey Proskuryakov]

All options in the View->Text Encoding menu are always dimmed out.

This is present in r15440, and is a very recent regression.

[Alexey Proskuryakov]

Worked in r15418.

[Darin Adler]

The dimmed-out menu items use the selector changeTextEncoding: and have no target (so they use the responder chain).

[Darin Adler]

This happened because of the protocol changes that Tim Hatcher made.

Since the WebDocumentText protocol is now appearing on a category of WebHTMLView rather than on WebHTMLView itself, the -[WebView supportsTextEncoding] method is returning NO.

    id documentView = [[[self mainFrame] frameView] documentView];
    return [documentView conformsToProtocol:@protocol(WebDocumentText)]
        && [documentView supportsTextEncoding];

Apparently having a category that implements a protocol is not sufficient to make an object return YES to conformsToProtocol: -- a short term solution could be to add a special case for WebHTMLView.

It's really unfortunate that WebHTMLView.h is a public header!

[John Sullivan]

WebHTMLView.h is not a public header -- it's "private" == SPI. Or is that what you meant?

[Darin Adler]

It's possible that this would be fixed by implementing the category -- we're currently declaring but not implementing it.

[Darin Adler]

Created attachment 9465 [details]
patch to actually implement the new categories

[John Sullivan]

Comment on attachment 9465 [details]
patch to actually implement the new categories

Makes it tempting to fix that prepare-ChangeLog bug, eh?

[Darin Adler]

<rdar://problem/4632173>

[Darin Adler]

Committed revision 15452.