Bug 9905 – REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

Open the url, click inside the div and press the delete key. WebKit crashes:

0    WebCore::TypingCommand::deleteKeyPressed(WebCore::TextGranularity) + 2020
1    WebCore::TypingCommand::doApply() + 312
2    WebCore::EditCommand::apply() + 616
3    WebCore::TypingCommand::deleteKeyPressed(WebCore::Document*, bool, WebCore::TextGranularity) + 252
4    -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] + 92
5    -[WebHTMLView(WebHTMLViewFileInternal) _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:] + 344
6    -[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:] + 256
7    -[WebHTMLView(WebNSTextInputSupport) doCommandBySelector:] + 120
8    -[NSKeyBindingManager(NSKeyBindingManager_MultiClients) interpretEventAsCommand:forClient:] + 1700
9    -[NSTSMInputContext interpretKeyEvents:] + 1104

I believe this is a regression from one of:
- r15408 <rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table
- r15414 <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

Created attachment 9442 [details]
Add missing null checks

Created attachment 9444 [details]
Add missing null checks

Changes to the test -- removed stray comment and added missing newline.

[Darin Adler]

Comment on attachment 9444 [details]
Add missing null checks

r=me

[David Kilzer (:ddkilzer)]

Committed revision 15426.

[Brady Eidson]

I couldn't find this bug so I filed a new one here
http://bugzilla.opendarwin.org/show_bug.cgi?id=9916
It points to my radar bug about it - 4630522

Will confirm and close shortly...

[David Kilzer (:ddkilzer)]

*** Bug 9916 has been marked as a duplicate of this bug. ***