Bug 9882 - run-webkit-tests should provide pixel comparisons of failing tests
Summary: run-webkit-tests should provide pixel comparisons of failing tests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P3 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-12 15:44 PDT by mitz
Modified: 2007-10-02 11:15 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-07-12 15:44:26 PDT
When a layout test fails, it is often useful to compare the "failed" rendering with the expected rendering. The color profile acrobatics are probably not necessary in this case.
Comment 1 David Kilzer (:ddkilzer) 2006-07-12 16:14:43 PDT
So you're saying that when you run run-webkit-tests without the --pixel option, you still want the pixels generated regardless for the failure (without the color profile acrobatics)?
Comment 2 mitz 2006-07-12 22:21:07 PDT
(In reply to comment #1)
> So you're saying that when you run run-webkit-tests without the --pixel option,
> you still want the pixels generated regardless for the failure (without the
> color profile acrobatics)?

Yes.
Comment 3 David Kilzer (:ddkilzer) 2006-07-13 04:05:44 PDT
Should this feature always happen, or should there be a command-line switch?

If it should be a switch, what should it be called?  Something like --generate-pixel-on-error, except shorter?

Comment 4 mitz 2006-07-13 05:05:35 PDT
(In reply to comment #3)
> Should this feature always happen, or should there be a command-line switch?
> 
> If it should be a switch, what should it be called?  Something like
> --generate-pixel-on-error, except shorter?
> 

In my opinion, it should be the default, but there should be a way to disable it. Perhaps --no-pixel-on-error ?