WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
9882
run-webkit-tests should provide pixel comparisons of failing tests
https://bugs.webkit.org/show_bug.cgi?id=9882
Summary
run-webkit-tests should provide pixel comparisons of failing tests
mitz
Reported
2006-07-12 15:44:26 PDT
When a layout test fails, it is often useful to compare the "failed" rendering with the expected rendering. The color profile acrobatics are probably not necessary in this case.
Attachments
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2006-07-12 16:14:43 PDT
So you're saying that when you run run-webkit-tests without the --pixel option, you still want the pixels generated regardless for the failure (without the color profile acrobatics)?
mitz
Comment 2
2006-07-12 22:21:07 PDT
(In reply to
comment #1
)
> So you're saying that when you run run-webkit-tests without the --pixel option, > you still want the pixels generated regardless for the failure (without the > color profile acrobatics)?
Yes.
David Kilzer (:ddkilzer)
Comment 3
2006-07-13 04:05:44 PDT
Should this feature always happen, or should there be a command-line switch? If it should be a switch, what should it be called? Something like --generate-pixel-on-error, except shorter?
mitz
Comment 4
2006-07-13 05:05:35 PDT
(In reply to
comment #3
)
> Should this feature always happen, or should there be a command-line switch? > > If it should be a switch, what should it be called? Something like > --generate-pixel-on-error, except shorter? >
In my opinion, it should be the default, but there should be a way to disable it. Perhaps --no-pixel-on-error ?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug