RESOLVED FIXED 9880
Memory leaks running DOM-Hanoi 
https://bugs.webkit.org/show_bug.cgi?id=9880
Summary Memory leaks running DOM-Hanoi
Alexey Proskuryakov
Reported 2006-07-12 11:45:35 PDT
Technically, these are not leaks, but the effect is similar :) When running certain non-stop browser tests, such as DOM-Hanoi (see bug URL), Safari memory usage grows fast, because Obj-C autoreleased objects do not get a chance to be collected. I suspect they may fill the address space before the test actually finishes, but I was not patient enough to stand the paging. All such allocations are made inside FrameMac::setStatusBarText(), so I gave this method an autorelease pool of its own.
Attachments
proposed patch (766 bytes, patch)
2006-07-12 11:47 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-07-12 11:47:22 PDT
Created attachment 9409 [details] proposed patch
Darin Adler
Comment 2 2006-07-12 14:25:31 PDT
Comment on attachment 9409 [details] proposed patch Looks good. r=me But are there any other calls besides "set status bar text" that need an autorelease pool for the same reason?
Alexey Proskuryakov
Comment 3 2006-07-12 21:17:21 PDT
(In reply to comment #2) > But are there any other calls besides "set status bar text" that need an > autorelease pool for the same reason? This patch fixes all DOM-Hanoi "leaks". Perhaps, other tests will uncover more?
David Kilzer (:ddkilzer)
Comment 4 2006-07-12 21:23:17 PDT
Darin, should this patch be committed now, or should it wait until after the stabilization period?
Darin Adler
Comment 5 2006-07-12 21:43:40 PDT
(In reply to comment #4) > Darin, should this patch be committed now, or should it wait until after the > stabilization period? I think it's good to land this now.
Alexey Proskuryakov
Comment 6 2006-07-13 08:49:04 PDT
Committed revision 15405.
Note You need to log in before you can comment on or make changes to this bug.