Bug 9838 - REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache
Summary: REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: John Sullivan
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2006-07-10 13:20 PDT by mitz
Modified: 2006-07-10 16:51 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (1.39 KB, patch)
2006-07-10 14:09 PDT, mitz 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-07-10 13:20:46 PDT 
Summary: When using shipping Safari 2.0.4 (419.3) with ToT WebKit, View Source brings up an empty window for pages loaded from the back/forward cache.

To reproduce: go to http://webkit.opendarwin.org/ and wait for it to finish loading, then go to about:blank, go back, and choose View > View Source.

Expected: source of webkit home page.

Actual: blank source window.

This is a regression that occurred between r14968 and r14977. A likely suspect in that range is r14976 - start moving loading logic to new WebFrameLoader class; move management of WebLoaders there.
Comment 1 John Sullivan 2006-07-10 13:40:53 PDT 
This also occurs with tip of tree Safari, so it's not a mismatch between WebKit and WebBrowser.

View Source uses the WebDocumentRepresentation protocol method -(NSString *)documentSource, so that method isn't returning the right result in this case.
Comment 2 mitz 2006-07-10 14:09:16 PDT 
Created attachment 9347 [details]
Proposed patch
Comment 3 John Sullivan 2006-07-10 14:26:47 PDT 
Comment on attachment 9347 [details]
Proposed patch

Looks good.
Comment 4 John Sullivan 2006-07-10 16:38:22 PDT 
I'll land this
Comment 5 John Sullivan 2006-07-10 16:51:56 PDT 
checked in as svn revision 15315