Bug 9810 – OPTGROUP label text is using the default font instead of Lucida Grande

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Chris Petersen]

* SUMMARY
I'm noticing OPTGROUP value text appears in the wrong font  (times). See attach screen shot.

* STEPS TO REPRODUCE
1. With a custom css sheet applied,  (select {
-webkit-appearance: menulist;
box-sizing: border-box;
}, open attached test case "OPTGROUP_test.html"
2. Mouse down on menu and notice the font used for "Cities". This is the wrong font used for the label text.

* RESULTS
The correct font should be used for label text in a OPTGROUP but isn't

* REGRESSION
Yes, tested with NB r15239.  Looks correct in stock 10.4.7 .  

[Chris Petersen]

Created attachment 9301 [details]
OPTGROUP test case

[Chris Petersen]

Created attachment 9302 [details]
sample screen shot comparing nativepopup menu and stock 10.4.7

[Chris Petersen]

This issue has been filed as <rdar://problem/4619534>

[Darin Adler]

The code is a bit mixed up. It basically says that if your font is the default font, then use the OS X default font for the menu item. That means that instead of Times, you get Lucida Grande. But then if anything at all is different from the default, you get the specified font. Since optgroup elements are bold, you get Times Bold.

I have no idea why we get Helvetica for the options in the group!

[Darin Adler]

I see the problem. Style inheritance goes through the render tree. But since option and optgroup elements don't have render tree elements, they can only inherit from the select element, not from other option and optgroup elements. This should be easy to fix.

[Darin Adler]

All those theories seem to be wrong. The style inheritance is working fine.

But somehow the font family name is "LucidaGrande" without a space. And that ends up being not found so we fall back on Times.

[Darin Adler]

Created attachment 9352 [details]
patch, including change log

[Geoffrey Garen]

Comment on attachment 9352 [details]
patch, including change log

r=me

land test case too, please

[Darin Adler]

Committed revision 15329.