Bug 9738 – Unqualified :hover selector ignored in strict parsing mode

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mark Rowe (bdash)]

When in strict parsing mode :hover { text-decoration: underline; } is ignored.  Firefox ignores the selector in quirks mode, but accepts it in strict mode.  I believe WebKit should do the same.

[Mark Rowe (bdash)]

Created attachment 9206 [details]
Quirks test case

[Mark Rowe (bdash)]

Created attachment 9207 [details]
Strict test case

[Mark Rowe (bdash)]

Heh, I just realised that the text in both of the test cases is meaningless, and is left over from reducing bug 9737.  The expected results are that in the quirks case, moving the mouse into the document or over the text should have no effect.  In the strict case, moving the mouse over the document or text should result in the text being underlined.

[Mark Rowe (bdash)]

Created attachment 9208 [details]
Only ignore unqualified :hover rules in quirks mode

[Maciej Stachowiak]

Conceptually this is a good fix. However:

+    // intended to apply the rules only to links.
+    bool onlyHoverActive = !strictParsing && (!sel->hasTag() &&
+                                              (sel->match == CSSSelector::PseudoClass &&
+                                                (sel->pseudoType() == CSSSelector::PseudoHover ||
+                                                 sel->pseudoType() == CSSSelector::PseudoActive)));


This makes "onlyHoverActive" a poor variable name now, since it no longer represents just the fact tha the style consists of only hover and active states.

I think it would be better to change the point of use instead, in terms of clarity:

    // disallow *:hover, *:active, and *:hover:active except for links
    if (onlyHoverActive && subject) {

Otherwise the variable name should be changed to something like shouldTreatAsQuirkyHoverActiveRule or something like that.

[Maciej Stachowiak]

Comment on attachment 9208 [details]
Only ignore unqualified :hover rules in quirks mode

r=me

[Maciej Stachowiak]

Comment on attachment 9208 [details]
Only ignore unqualified :hover rules in quirks mode

Er, meant to r- this due to comments above.

[Mark Rowe (bdash)]

Created attachment 9333 [details]
Updated patch

Changed point of use as per Maciej's comment.  I'm not really sure why I missed that initially.

[Darin Adler]

Comment on attachment 9333 [details]
Updated patch

r=mjs

[Timothy Hatcher]

Landed in r15727.