Bug 9689 - Nightly builds should warn a user about potential problems when using "Safari extensions"
Summary: Nightly builds should warn a user about potential problems when using "Safari...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-01 22:58 PDT by Mark Rowe (bdash)
Modified: 2006-07-02 04:57 PDT (History)
1 user (show)

See Also:


Attachments
Implement as described (5.50 KB, patch)
2006-07-01 23:04 PDT, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff
Update to explicitly check that bundle is in known extension paths (6.65 KB, patch)
2006-07-01 23:57 PDT, Mark Rowe (bdash)
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2006-07-01 22:58:17 PDT
Nightly builds should detect whether "Safari extensions" (aka haxies) have been loaded into Safari, and warn the user about the potential they have for causing crashes or other problems when used with the nightlies.
Comment 1 Mark Rowe (bdash) 2006-07-01 23:04:15 PDT
Created attachment 9135 [details]
Implement as described
Comment 2 Timothy Hatcher 2006-07-01 23:09:35 PDT
Comment on attachment 9135 [details]
Implement as described

I would check the path the bundle is loaded from, like if it is in the Input Managers or SIMBL folder.
Comment 3 Mark Rowe (bdash) 2006-07-01 23:57:47 PDT
Created attachment 9139 [details]
Update to explicitly check that bundle is in known extension paths
Comment 4 Timothy Hatcher 2006-07-02 00:05:28 PDT
Comment on attachment 9139 [details]
Update to explicitly check that bundle is in known extension paths

This looks good now.
Comment 5 David Kilzer (:ddkilzer) 2006-07-02 04:57:04 PDT
Committed revision 15136.