Bug 9684 – [GDK] multiple little fixes and a few new things for Templinkstubs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Shawn Stricker (kb1ibt)]

there multiple little spelling errors and minor glitches that were causing GDK to not build i'll attach a patch file

[Shawn Stricker (kb1ibt)]

Created attachment 9132 [details]
basic patch

[Shawn Stricker (kb1ibt)]

there are still problems with the finished product of the build, however 

../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::SiteIcon::getImage(WebCore::IntSize const&)'
../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument(WebCore::DOMImplementation*, WebCore::FrameView*)'
../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::HTMLViewSourceDocument::addViewSourceToken(WebCore::Token*)'
../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::SiteIcon::SiteIcon(WebCore::String const&)'
../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::IndentOutdentCommand::IndentOutdentCommand(WebCore::Document*, WebCore::IndentOutdentCommand::EIndentType, int)'

[Timothy Hatcher]

Comment on attachment 9132 [details]
basic patch

r=me

[Timothy Hatcher]

You might need to make those symbols in the TemporaryLinkStubs.cpp file.

[Mark Rowe (bdash)]

It seems to me that new files added to SVN are responsible for the undefined symbol errors.  In particular, WebCore/icon/SiteIcon.cpp, WebCore/editing/IndentOutdentCommand.cpp and WebCore/html/HTMLViewSourceDocument.cpp account for the undefined symbols mentioned.  Adding these files to the relevant places in the Bakefile should resolve the link errors.

[David Kilzer (:ddkilzer)]

Comment on attachment 9132 [details]
basic patch

Shawn, if you're going to hand-edit patches, please make sure they apply when you're done.  :)  The first two patches had extra whitespace at the end of the changed lines, the second patch had an invalid segment (@@) with no changes, and the third patch had a line-count off by one (7 instead of 6 for both - and +).

Also, please use WebKitTools/Scripts/prepare-ChangeLog to create a ChangeLog entry for your patch in the future.  Thanks!

[David Kilzer (:ddkilzer)]

Committed revision 15135.

Please file a new bug for the bakefile changes per Comment #5.