RESOLVED FIXED 9649
The no-svg build broke after r15091 
https://bugs.webkit.org/show_bug.cgi?id=9649
Summary The no-svg build broke after r15091
David Kilzer (:ddkilzer)
Reported 2006-06-29 04:26:42 PDT
The no-svg build broke after r15091 was committed: <rdar://problem/4599760> Objective-C XPath support I have a patch to fix this build.
Attachments
Patch v1 (4.21 KB, patch)
2006-06-29 04:30 PDT, David Kilzer (:ddkilzer) 		darin: review-
DetailsFormatted DiffDiff
Patch v2 (landed) (3.96 KB, patch)
2006-06-29 08:23 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-06-29 04:30:44 PDT
Created attachment 9088 [details] Patch v1
Timothy Hatcher
Comment 2 2006-06-29 08:07:32 PDT
Comment on attachment 9088 [details] Patch v1 Is the #ifndef DOMXPath_H needed? When using ObjC's #import you do not need to do this. Are we using #include and not #import for these headers? r=me otherwise
Darin Adler
Comment 3 2006-06-29 08:07:42 PDT
Comment on attachment 9088 [details] Patch v1 Objective-C headers don't need multiple-includes defines. That's because Objective-C uses import, which takes care of such things automatically. Any headers that support being included from C or C++ code need such defines, but pure Objective-C or Objective-C++ ones should *not* have them. review- because of this. Would have been review+ otherwise.
Darin Adler
Comment 4 2006-06-29 08:08:16 PDT
In fact, it's OK to land the patch as long as you don't add the unnecessary header guards.
David Kilzer (:ddkilzer)
Comment 5 2006-06-29 08:23:45 PDT
Created attachment 9090 [details] Patch v2 (landed) Removed header guards, fixed comments in ChangeLog and landed this patch per Darin's comments.
David Kilzer (:ddkilzer)
Comment 6 2006-06-29 08:24:02 PDT
Committed revision 15092.
Note You need to log in before you can comment on or make changes to this bug.