Bug 9649 - The no-svg build broke after r15091
Summary: The no-svg build broke after r15091
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-29 04:26 PDT by David Kilzer (:ddkilzer)
Modified: 2006-06-29 08:24 PDT (History)
0 users

See Also:

Attachments
Patch v1 (4.21 KB, patch)
2006-06-29 04:30 PDT, David Kilzer (:ddkilzer) 		darin: review-
Details | Formatted Diff | Diff
Patch v2 (landed) (3.96 KB, patch)
2006-06-29 08:23 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2006-06-29 04:26:42 PDT 
The no-svg build broke after r15091 was committed:

<rdar://problem/4599760> Objective-C XPath support

I have a patch to fix this build.
Comment 1 David Kilzer (:ddkilzer) 2006-06-29 04:30:44 PDT 
Created attachment 9088 [details]
Patch v1
Comment 2 Timothy Hatcher 2006-06-29 08:07:32 PDT 
Comment on attachment 9088 [details]
Patch v1

Is the #ifndef DOMXPath_H needed? When using ObjC's #import you do not need to do this. Are we using #include and not #import for these headers?

r=me otherwise
Comment 3 Darin Adler 2006-06-29 08:07:42 PDT 
Comment on attachment 9088 [details]
Patch v1

Objective-C headers don't need multiple-includes defines. That's because Objective-C uses import, which takes care of such things automatically.

Any headers that support being included from C or C++ code need such defines, but pure Objective-C or Objective-C++ ones should *not* have them.

review- because of this. Would have been review+ otherwise.
Comment 4 Darin Adler 2006-06-29 08:08:16 PDT 
In fact, it's OK to land the patch as long as you don't add the unnecessary header guards.
Comment 5 David Kilzer (:ddkilzer) 2006-06-29 08:23:45 PDT 
Created attachment 9090 [details]
Patch v2 (landed)

Removed header guards, fixed comments in ChangeLog and landed this patch per Darin's comments.
Comment 6 David Kilzer (:ddkilzer) 2006-06-29 08:24:02 PDT 
Committed revision 15092.