Bug 9642 - GMail Editor: Operations that use drop down menus blow away the selection 
Summary: GMail Editor: Operations that use drop down menus blow away the selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 8497 (view as bug list)
Depends on:
Blocks: 9638
  Show dependency tree / graph
 
Reported: 2006-06-28 15:24 PDT by Justin Garcia
Modified: 2006-07-17 21:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch applied as r15358 (10.38 KB, patch)
2006-07-11 15:57 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2006-06-28 15:24:32 PDT 
Font Style, Size, Color and Background Color all use execCommands we support, but when they are performed, there's no selection, because its blown away when the user mouse downs inside the drop down menu.
Comment 1 Justin Garcia 2006-06-29 12:10:21 PDT 
When a WebHTMLView resigns as firstResponder, we clear its selection if it doesn't maintainInactiveSelection.  There's a problem with that method, it will return no unless the WebView is editable.
Also, when a WebHTMLView resigns as firstResponder, we clear selections in all frames unconditionally, even if they are editable.
Comment 2 Justin Garcia 2006-07-11 15:29:37 PDT 
r15358
Comment 3 David Kilzer (:ddkilzer) 2006-07-11 15:57:47 PDT 
Created attachment 9380 [details]
Patch applied as r15358
Comment 4 Timothy Hatcher 2006-07-14 19:21:07 PDT 
Reopened, Dave Harrison says this isn't fixed. Talk to him.
Comment 5 Timothy Hatcher 2006-07-14 19:21:48 PDT 
Patch rolled out in r15441.
Comment 6 Justin Garcia 2006-07-17 12:35:09 PDT 
Rolled the changes back in and removed the call to _clearSelectionInOtherFrames to -[WebHTMLView becomeFirstResponder] to fix this.
Comment 7 Justin Garcia 2006-07-17 12:35:19 PDT 
r15487.
Comment 8 David Kilzer (:ddkilzer) 2006-07-17 21:41:01 PDT 
*** Bug 8497 has been marked as a duplicate of this bug. ***