Bug 9606 - REGRESSION: some callers are still using clientX/Y to get pageX/Y
Summary: REGRESSION: some callers are still using clientX/Y to get pageX/Y
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-26 09:17 PDT by Darin Adler
Modified: 2019-02-06 09:03 PST (History)
3 users (show)

See Also:

Attachments
patch to fix the bad callers (1.66 KB, patch)
2006-06-26 09:20 PDT, Darin Adler 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2006-06-26 09:17:55 PDT 
The fix for bug 8707 introduced this problem.
Comment 1 Darin Adler 2006-06-26 09:20:40 PDT 
Created attachment 9048 [details]
patch to fix the bad callers
Comment 2 Geoffrey Garen 2006-06-26 11:27:38 PDT 
Comment on attachment 9048 [details]
patch to fix the bad callers

r=me
Comment 3 Geoffrey Garen 2006-06-26 11:28:23 PDT 
... but can I get a ChangeLog and a testcase?
Comment 4 David Kilzer (:ddkilzer) 2006-06-26 12:41:39 PDT 
It appears this was committed as r15047.
Comment 5 Darin Adler 2006-06-26 13:36:24 PDT 
Really? No way. Did I do that by accident?
Comment 6 Darin Adler 2006-06-26 13:41:55 PDT 
(In reply to comment #4)
> It appears this was committed as r15047.

No. It's not in yet.
Comment 7 David Kilzer (:ddkilzer) 2006-06-26 15:24:29 PDT 
(In reply to comment #6)
> (In reply to comment #4)
> > It appears this was committed as r15047.
> 
> No. It's not in yet.

Sorry.  Comments from that commit lead me to believe this bug was fixed.
Comment 8 Darin Adler 2006-06-27 09:47:04 PDT 
Test cases for each of these are going to be a pain. Working on them.
Comment 9 Darin Adler 2006-06-27 10:17:25 PDT 
Landed two of these fixes with test cases and change log.

Committed revision 15052.

Still need a test case for the frameset one.
Comment 10 Darin Adler 2006-06-27 10:39:53 PDT 
Turns out the frameset one wasn't really a bug -- clientX/Y and pageX/Y will always be the same for framesets.

I decided to make the change anyway.

Committed revision 15053.
Comment 11 Lucas Forschler 2019-02-06 09:03:51 PST 
Mass moving XML DOM bugs to the "DOM" Component.