Bug 9581 - REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
Summary: REGRESSION: The new NativeTextArea scrolls to the top when the control is unf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Adele Peterson
URL:
Keywords: Regression
: 10670 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-25 13:33 PDT by Rosyna
Modified: 2006-11-02 20:36 PST (History)
3 users (show)

See Also:


Attachments
patch (1.26 KB, patch)
2006-06-29 11:09 PDT, Adele Peterson
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rosyna 2006-06-25 13:33:23 PDT
If I have a lot of text In a textarea control, such that it makes the textarea get a scroll bar and I scroll to the bottom of the textarea control, then click on another control (such as a checkbox, radio control, or push button), the textarea scrolls to the top. This seems to be really "jarring". Especially if I'm trying to copy and paste something into the textarea from the webpage I'm commenting on. Since it means I have to scroll all the way down to the bottom again to find the location I was *just* at in order to paste the thing I am going to quote.
Comment 1 Rosyna 2006-06-25 13:34:46 PDT
This is a test. There should be no line breaks in this comment. This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.
Comment 2 Adele Peterson 2006-06-29 11:09:58 PDT
Created attachment 9096 [details]
patch
Comment 3 Adele Peterson 2006-06-29 12:21:45 PDT
Comment on attachment 9096 [details]
patch

clearing review flag. this isn't quite right.
Comment 4 Adele Peterson 2006-06-29 12:49:16 PDT
That patch fixes some common cases of this problem, but RenderLayer::updateScrollInfoAfterLayout is still sometimes causing the layer to scroll back to the top.

I'm not sure I understand this code.... we're calculating a new scroll position (line 1036):

        int newY = max(0, min(m_scrollY, scrollHeight() - m_object->clientHeight()));

where m_scrollY is 26... which seems to be valid, but gets clobbered by this calculation.
Comment 5 Simon Raboczi 2006-07-13 08:18:08 PDT
A more severe (and presumably related) problem with the scrolling of textareas is that touching the scrollbar instantly and reproducibly crashes the browser.
Comment 6 Adele Peterson 2006-07-13 09:28:01 PDT
Simon, please file a new bug about the crash, so we can fix that separately from this issue.  Thanks!
Comment 7 David Kilzer (:ddkilzer) 2006-07-15 12:57:51 PDT
This is a regression from production Safari, so adding Regression keyword.  Regressions are P1, and should have a Radar associated with them (adding NeedsRadar).

Comment 8 David Kilzer (:ddkilzer) 2006-07-15 14:50:44 PDT
Bug 9942 may be related to this bug since it exhibits similar behavior.

Comment 9 mitz 2006-09-01 00:48:22 PDT
*** Bug 10670 has been marked as a duplicate of this bug. ***
Comment 10 Jon 2006-10-05 22:06:22 PDT
Highlight scrolling is still crazy as of r16831. Major usability (i.e. testing) problem
Comment 11 Adele Peterson 2006-11-02 20:17:27 PST
Comment on attachment 9096 [details]
patch

I actually do think this patch is right.  The problem I was seeing before is caused by the flexbox double layout bugs.  Now that we've moved textareas off of RenderFlexibleBox, this change should fully fix this scrolling problem.
Comment 12 Adele Peterson 2006-11-02 20:18:14 PST
Comment on attachment 9096 [details]
patch

oh, and of course, I'll update this patch so RenderTextField --> RenderTextControl
Comment 13 Anders Carlsson 2006-11-02 20:26:19 PST
Comment on attachment 9096 [details]
patch

r=me
Comment 14 Adele Peterson 2006-11-02 20:36:48 PST
Committed revision 17560.