Bug 9539 – Another case error preventing build

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Nicholas Shanks]

cc1plus: warnings being treated as errors
In file included from /Users/nicholas/Projects/Safari/JavaScriptCore/API/JSContextRef.cpp:27:
/Users/nicholas/Projects/Safari/JavaScriptCore/API/APICast.h:31: warning: mismatched case in filenames, wanted "UString.h" but found "ustring.h"
** BUILD FAILED **

[David Kilzer (:ddkilzer)]

Obvious build fix.  Per Maciej, I checked this in without a review.

Committed revision 14969.

[David Kilzer (:ddkilzer)]

Created attachment 8960 [details]
Patch committed as r14969

[Nicholas Shanks]

Still doesn't build, next error pasted below.
Am I the only one who gets these errors?

cc1plus: warnings being treated as errors
/Users/nicholas/Projects/Safari/JavaScriptCore/API/JSObjectRef.cpp:31: warning: mismatched case in filenames, wanted "Identifier.h" but found "identifier.h"
** BUILD FAILED **

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> Still doesn't build, next error pasted below.
> Am I the only one who gets these errors?

Yes, because you're on a case-sensitive filesystem.  Actually, the Linux porters run into this problem as well.

> cc1plus: warnings being treated as errors
> /Users/nicholas/Projects/Safari/JavaScriptCore/API/JSObjectRef.cpp:31: warning:
> mismatched case in filenames, wanted "Identifier.h" but found "identifier.h"
> ** BUILD FAILED **

Please go through and fix ALL of the errors until it compiles, then create a patch and post it to this bug.

[Nicholas Shanks]

I'm not on a case sensitive file system! I've just got a bog standard HFS+ disk, exactly the same as you. I am also using a bog standard svn checkout, with no changes to the build system. The only thing I can think it might be is GCC. my version is:
powerpc-apple-darwin8-gcc-4.0.0 (GCC) 4.0.0 (Apple Computer, Inc. build 5026)
What are you using?

[Alexey Proskuryakov]

Created attachment 8967 [details]
Document the Xcode 2.3 requirement

Shouldn't we just document that WebKit needs at least Xcode 2.3? With new features being used, such as DWARF debug symbols and better support for path quoting, it is not really compatible with 2.2 anyway.

[Darin Adler]

Comment on attachment 8967 [details]
Document the Xcode 2.3 requirement

Looks good. But we should also change the checkRequiredSystemConfig function in webkitdirs.pm, so you'll get a good error message if you try to build.

[Alexey Proskuryakov]

Created attachment 8968 [details]
checkRequiredSystemConfig patch

[Geoffrey Garen]

Comment on attachment 8968 [details]
checkRequiredSystemConfig patch

r=me

[Alexey Proskuryakov]

Looks like the option to warn about wrong filename case has disappeared from Xcode, that's why others are not seeing the problem.

I've committed a fix for Identifier.h; since it's the only remaining failure that was reported, I'm closing this bug.