WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
9509
Would like a way to pause/resume XML parsing
https://bugs.webkit.org/show_bug.cgi?id=9509
Summary
Would like a way to pause/resume XML parsing
Anders Carlsson
Reported
2006-06-19 15:36:44 PDT
This is needed to be able to load external DTD definitions without blocking, as well as external scripts (if a <script src=""> tag is encountered, parsing should pause until the file has loaded and then resume.
Attachments
Patch
(20.10 KB, patch)
2006-06-19 16:27 PDT
,
Anders Carlsson
mjs
: review-
Details
Formatted Diff
Diff
Address comments
(20.42 KB, patch)
2006-06-20 09:08 PDT
,
Anders Carlsson
ggaren
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2006-06-19 16:27:22 PDT
Created
attachment 8925
[details]
Patch Unfortunately there's no way to pause/resume the libxml SAX parser (it's possible with expat) so a rather kludgey workaround is used. I've verified that it works by calling pause before parsing and resume inside ::finish.
Maciej Stachowiak
Comment 2
2006-06-20 02:41:01 PDT
Comment on
attachment 8925
[details]
Patch On the substance this looks ok, but I think it would be better to use subclasses instead of just a tagged union for PendingCallbacks, this would allow elimination of most of the switch statements also. Suggest rewriting along theselines.
Anders Carlsson
Comment 3
2006-06-20 09:08:04 PDT
Created
attachment 8933
[details]
Address comments
Geoffrey Garen
Comment 4
2006-06-20 14:24:47 PDT
Comment on
attachment 8933
[details]
Address comments union gone. band happy. r me.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug