Bug 9501 – Windows build fails with link error CharsetTable not defined

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ben Goodger]

Windows builds fail with a link error: CharsetTable is not defined. 

WebCore/DerivedSources/CharsetData.cpp exists, but is empty. In the build log there is a report that a script failed whilst running. It seems that the script that generates this file - make-charset-table.pl - is having difficulty. 

make-charset-table.pl does not properly normalize alias names in subroutine process_iana_charsets. character-sets.txt has some Alias: lines that have escape characters on the end that are not properly chomped, meaning that in more than one case the statement:

next if $new_alias eq "None";

does not work. 

This needs to be moved after the normalization steps and adjusted to:

next if $new_alias eq "none";

[Ben Goodger]

Created attachment 8918 [details]
patch

move test for equality to "none" to after normalization steps. 

ChangeLog entry:

* platform/make-charset-table.pl:
(process_iana_charsets):
Move test for equality to alias "None" until after normalization steps
to ensure escape characters in the input data don't interfere with 
processing.
Convert nearby tabs to 4 spaces in this function.

[Darin Adler]

Comment on attachment 8918 [details]
patch

This looks fine -- but I'm working on a patch that eliminates the character set table entirely!

[Darin Adler]

Comment on attachment 8918 [details]
patch

Seems fine to land this, but even better to remove this script entirely!

r=me

[David Kilzer (:ddkilzer)]

Committed revision 14919.