Bug 9390 – Move full-frame plugins to WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Anders Carlsson]

We should move handling of full-frame plugins to WebCore

[Anders Carlsson]

Created attachment 8797 [details]
Patch

After this it's possible to merge WebNetscapePluginEmbeddedView with WebBaseNetscapePluginView, and WebNetscapePluginStream with WebBaseNetscapePluginStream. I didn't want to do this right now because it would mean a lot of extra changes.

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> Created an attachment (id=8797) [edit]
> Patch

FWIW, there are tabs in some of the ChangeLogs and a few source files.

[Tim Omernick]

I read this patch, and it seems OK.  You should have someone else look at the WebCore tokenizer/document stuff as well for a review+.

[Geoffrey Garen]

Comment on attachment 8797 [details]
Patch

I reviewed the WebCore parts, so by our powers combined... r+

Recommended changing some " *" to "* " and adding the new files to the Windows project.

[David Kilzer (:ddkilzer)]

This commit changed the results of (broke is too strong of a word :) the following tests:

    css2.1/t0801-c412-hz-box-00-b-a
    plugins/pluginDocumentView-deallocated-dataSource

http://build.webkit.org/results/post-commit-powerpc-mac-os-x/2186/

The other failing test on the above link (dom/svg/level3/xpath/Attribute_Nodes) is known to fail from time-to-time.

[David Kilzer (:ddkilzer)]

(In reply to comment #5)
> This commit changed the results of (broke is too strong of a word :) the
> following tests: [...]

See Bug 9406.  Sorry...I used the word "broke" on that summary.