Bug 9390 - Move full-frame plugins to WebCore
Summary: Move full-frame plugins to WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-10 08:00 PDT by Anders Carlsson
Modified: 2006-06-11 18:24 PDT (History)
0 users

See Also:

Attachments
Patch (96.62 KB, patch)
2006-06-10 08:47 PDT, Anders Carlsson 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2006-06-10 08:00:09 PDT 
We should move handling of full-frame plugins to WebCore
Comment 1 Anders Carlsson 2006-06-10 08:47:48 PDT 
Created attachment 8797 [details]
Patch

After this it's possible to merge WebNetscapePluginEmbeddedView with WebBaseNetscapePluginView, and WebNetscapePluginStream with WebBaseNetscapePluginStream. I didn't want to do this right now because it would mean a lot of extra changes.
Comment 2 David Kilzer (:ddkilzer) 2006-06-10 11:53:50 PDT 
(In reply to comment #1)
> Created an attachment (id=8797) [edit]
> Patch

FWIW, there are tabs in some of the ChangeLogs and a few source files.
Comment 3 Tim Omernick 2006-06-10 18:07:26 PDT 
I read this patch, and it seems OK.  You should have someone else look at the WebCore tokenizer/document stuff as well for a review+.
Comment 4 Geoffrey Garen 2006-06-11 12:31:06 PDT 
Comment on attachment 8797 [details]
Patch

I reviewed the WebCore parts, so by our powers combined... r+

Recommended changing some " *" to "* " and adding the new files to the Windows project.
Comment 5 David Kilzer (:ddkilzer) 2006-06-11 18:12:42 PDT 
This commit changed the results of (broke is too strong of a word :) the following tests:

    css2.1/t0801-c412-hz-box-00-b-a
    plugins/pluginDocumentView-deallocated-dataSource

http://build.webkit.org/results/post-commit-powerpc-mac-os-x/2186/

The other failing test on the above link (dom/svg/level3/xpath/Attribute_Nodes) is known to fail from time-to-time.
Comment 6 David Kilzer (:ddkilzer) 2006-06-11 18:24:04 PDT 
(In reply to comment #5)
> This commit changed the results of (broke is too strong of a word :) the
> following tests: [...]

See Bug 9406.  Sorry...I used the word "broke" on that summary.