Bug 9384 - WebView's initWithCoder: does not set useBackForwardList correctly
Summary: WebView's initWithCoder: does not set useBackForwardList correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-10 01:04 PDT by Graham Dennis
Modified: 2006-06-10 06:33 PDT (History)
0 users

See Also:

Attachments
patch (1.37 KB, patch)
2006-06-10 01:08 PDT, Graham Dennis 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Dennis 2006-06-10 01:04:22 PDT 
When init'ing with a keyed coder, the value of useBackForwardList in WebView's _private ivar is set on line 1608, but this value is reset on line 1630 by the function's local variable useBackForwardList. Instead of setting the value of useBackForwardList in the _private ivar on line 1608, the local variable should be set, which in turn sets the value in the _private ivar.
I will attach a patch in a moment.
Comment 1 Graham Dennis 2006-06-10 01:08:47 PDT 
Created attachment 8793 [details]
patch
Comment 2 John Sullivan 2006-06-10 06:29:08 PDT 
Comment on attachment 8793 [details]
patch

Good catch. I'm surprised the method even compiles, since the local variable useBackForwardList is uninitialized (but then used!) if [decoder allowsKeyedCoding] returns YES.
Comment 3 John Sullivan 2006-06-10 06:33:41 PDT 
Commited in svn revision 14804.