Bug 9304 - Minor cleanup in JavaScriptCore
Summary: Minor cleanup in JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-04 11:34 PDT by Geoffrey Garen
Modified: 2006-06-04 20:04 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2006-06-04 11:36 PDT, Geoffrey Garen
mjs: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2006-06-04 11:34:37 PDT
Patch coming.
Comment 1 Geoffrey Garen 2006-06-04 11:36:41 PDT
Created attachment 8695 [details]
Patch
Comment 2 Maciej Stachowiak 2006-06-04 16:02:41 PDT
Comment on attachment 8695 [details]
Patch

Removing the declarations is right, but I don't think the change to 3 to 4 is necessary. Characters that require 4 bytes in UTF-8 also require a surrogate pair in UTF-16, which is treated as two characters.
Comment 3 Maciej Stachowiak 2006-06-04 16:07:15 PDT
Comment on attachment 8695 [details]
Patch

r- (but fine with me if it turns out I am wrong about the UTF8 thing)
Comment 4 Geoffrey Garen 2006-06-04 20:01:40 PDT
Thanks for the info about UTF-8; I hadn't considered that. I'm going to land just the header change.
Comment 5 Geoffrey Garen 2006-06-04 20:04:33 PDT
Committed revision 14731.