Bug 9183 – Finish renaming of RenderCanvas to RenderView

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[David Kilzer (:ddkilzer)]

Nearly 3000 tests broke when RenderCanvas was renamed to RenderView in r14638.  This fix to WebCore/rendering/RenderView.h had to be checked in to make those tests pass again (r14642):

-    virtual const char *renderName() const { return "RenderView"; }
+    // FIXME: Update this eventually and check in new layout tests.
+    virtual const char *renderName() const { return "RenderCanvas"; }

The layout tests should be easily updated by a simple find+perl command before committing:

find LayoutTests -name \*-expected.txt -exec perl -p -i -e 's/\bRenderCanvas\b/RenderView/' {} \;

[David Kilzer (:ddkilzer)]

Created attachment 8641 [details]
Patch v1

You are reviewing Patch v1 plus running the "find" command noted in Comment #0.

The only changes of interest in the LayoutTests are two HTML files that had "RenderCanvas" in their contents:

LayoutTests/editing/selection/7152-1.html
LayoutTests/editing/selection/7152-2.html

As of this patch (r14663) there were 3023 *-expected.txt files changed.  I ran run-webkit-tests and all the results were identical to build.webkit.org (the same tests were failing in the same way, while the rest passed).

[David Kilzer (:ddkilzer)]

Created attachment 8658 [details]
Patch v2

Changes since Patch v1:

- Removed newline change for LayoutTests/editing/selection/7152-[12].html
- Added only significant change to test results:  LayoutTests/editing/selection/7152-[12]-expected.txt (which changed because the text inside them changed)

[David Kilzer (:ddkilzer)]

Created attachment 8659 [details]
Patch v3 (the charm!)

Changes since Patch v2:

- Fixed comments in LayoutTests changelog to be clearer.
- Included image updates for editing/selection/7152-[12].html tests.

[Maciej Stachowiak]

Comment on attachment 8659 [details]
Patch v3 (the charm!)

r=me

Whoever applies this make sure to also run the find command to do the search and replace!

[David Kilzer (:ddkilzer)]

Committed as r14684.