RESOLVED INVALID 9133
Split CSSStyleSelector.* into separate files (one class per file). 
https://bugs.webkit.org/show_bug.cgi?id=9133
Summary Split CSSStyleSelector.* into separate files (one class per file).
Sam Weinig
Reported 2006-05-26 17:32:35 PDT
This one was a little more tricky.
Attachments
patch (404.80 KB, patch)
2006-05-26 17:40 PDT, Sam Weinig 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2006-05-26 17:40:17 PDT
Created attachment 8567 [details] patch Like the other split patches, this requires the lander to do some work to split the files on their end (ussually just running a script). It is a little more complicated than some of the others as StyleSelector.h, CSSRuleData.h and CSSRuleDataList.h all do not have implementation (.cpp) files and thus only require cssstyleselector.h to be copied. In addition, CSSRuleSet.h and CSSRuleSet.cpp come from within cssstyleselector.cpp and require to copies of it. Lastly, I could not find a way to convert cssstyleselector.h and cssstyleselector.cpp into CSSStyleSelector.h and CSSStyleSelector.cpp due to svn not understanding the case change.
Darin Adler
Comment 2 2006-05-31 14:52:12 PDT
Comment on attachment 8567 [details] patch Looks great. But there's no patch here for the project files, nor for ChangeLog. Need to include those.
Alexey Proskuryakov
Comment 3 2010-06-11 17:24:38 PDT
Please feel free to reopen if you'd like to revisit this work.
Note You need to log in before you can comment on or make changes to this bug.