Bug 9122 – REGRESSION: Incorrect vertical position for text fields in a "display: table" block

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Denis Defreyne]

OVERVIEW

In a block with 'display' attribute set to 'table', text fields and their labels are positioned incorrectly.

STEPS TO REPRODUCE

1. Load <http://stoneship.org/pub/css/input-field-jump/jump.html>.

2. Type something in the first text field.
(The text field will jump down.)

3. Delete the contents of the text field
(The text field will jump up.)

4. Watch the 8 text fields below the horizontal rule.

ACTUAL RESULTS

When typing something in the first text field, the field jumps down and the label jumps up.
When deleting the content of the field, the label jumps down and the field jumps up.

The fields below the rule are incorrectly aligned.
The labels of filled fields are too high, or the filled fields themselves are too low.
The labels of empty fields are too low, or the empty fields themselves are too high.
The size of the "table" row changes slightly.

EXPECTED RESULTS

When typing something in the first text field, the field should not jump up or down.
The label and the text field should be on the same line.
The height of the "table" row should always be the same.

BUILD DATE AND PLATFORM:

Does not happen in stock Safari (417.9.3).
Happens in r14606.

ADDITIONAL INFORMATION:

mitz' local patch for bug #8969 does not fix the issue, but merely hides it. Possibly not relevant, but I'll quote from #webkit anyway:

< mitzpettel> ddfreyne: funny, i have TOT+ a local textfield patch and i can't reproduce, so maybe my local patch accidently fixed it
< mitzpettel> ddfreyne: aha, so my patch sort of delays the jumping-around until you resize the document

[Trey Matteson]

Also happens in the search field at the top of cnn.com, which is within a table.

[Alice Liu]

<rdar://problem/4575258>

I am going to post a patch. Note that in TOT you need to resize the window or otherwise force relayout in order to see the jump.

Created attachment 8738 [details]
Proposed patch

[Dave Hyatt]

Comment on attachment 8738 [details]
Proposed patch

This is not unique to text fields.  Make an editable inline block with another block inside it.

Need to just fix the broken logic of the method rather than putting in an isTextField check.

Created attachment 8747 [details]
Revised patch

We talked about it on IRC. I changed the check to isReplaced() and added the inline block case to the test.

[Darin Adler]

Comment on attachment 8747 [details]
Revised patch

r=me

[Darin Adler]

Committed revision 14760.