Bug 9109 - Remove bogus assertion in RenderBlock::tabWidth
Summary: Remove bogus assertion in RenderBlock::tabWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-25 10:16 PDT by mitz
Modified: 2006-05-31 23:25 PDT (History)
0 users

See Also:

Attachments
Remove the assert and change the uninitialized value to -1 (2.13 KB, patch)
2006-05-25 10:19 PDT, mitz 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-05-25 10:16:47 PDT 
If the font's space width is 0 (which can happen with a very small font) then it's OK for the tab width to also be 0. See attachment 8485 [details] (bug 9062). Since 0 is a valid value, the uninitialized value should be something else.
Comment 1 mitz 2006-05-25 10:19:27 PDT 
Created attachment 8541 [details]
Remove the assert and change the uninitialized value to -1

No layout test since DumpRenderTree forces a minimum font size.
Comment 2 Geoffrey Garen 2006-05-25 11:44:36 PDT 
Comment on attachment 8541 [details]
Remove the assert and change the uninitialized value to -1

r=me