Bug 9077 - [S60] Result page is not loaded completely on www.expedia.com
Summary: [S60] Result page is not loaded completely on www.expedia.com
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 312.x
Hardware: S60 Hardware S60 3rd edition
: P2 Normal
Assignee: Nobody
URL: http://www.expedia.com
Keywords: PlatformOnly
Depends on: 5312
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-23 13:23 PDT by Krishna
Modified: 2006-09-08 12:26 PDT (History)
3 users (show)

See Also:


Attachments
Fix taken from Tiger branch (see comments) (6.37 KB, patch)
2006-08-22 14:23 PDT, Sriram
koivisto: review-
Details | Formatted Diff | Diff
Made changes based on comments (8.89 KB, patch)
2006-08-29 20:48 PDT, Sriram
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krishna 2006-05-23 13:23:06 PDT
Steps to reproduce:
1. Load the URL
2. In 'Create your own trip' section, Select 'cars only' option OR select the car image. Enter "Bos" as the pickup location. Enter appropriate pickup and drop-off date and time. Now Select the 'Search for car' link.
3. Verify that the corresponding page is displayed with all available full size rental cars.
Expected Result:
Result page is loaded completely and and user is able to view the details and select the first car
Actual Result:
Result page is partially loaded and user is not able to view the details and select the first car
Comment 1 Geoffrey Garen 2006-05-23 13:43:04 PDT
I can't reproduce this bug with Version 2.0.3 (418.3).
Comment 2 David Carson 2006-05-23 15:44:53 PDT
Page seems to full load in TOT, but nothing happens when I select the first car. Changed Version to reflect that this is also a problem in TOT.
Comment 3 Sriram 2006-05-26 12:08:11 PDT
Expedia populates car rental entries by replacing comments in HTML with actual data. In the S60 browser code base,comment nodes are not created when <!--c--> is encountered. 

Here is piece of HTML that causes the problem on the S60 browser:
function writeCarRow2(s, c, v)
{
s = s.replace(/<!--C-->/,c.carccart);
....
}

For the Safari browser, Expedia sends out "&lt;!--c--&gt;" instead of "<!--c-->" and thats why the string replace works fine.

This would work on the S60 HW if fix for #5312 is available.
Comment 4 Bradley Morrison 2006-05-29 12:22:30 PDT
Given previous comment, should the PlatformOnly keyword be added to this bug?
Comment 5 David Kilzer (:ddkilzer) 2006-05-29 17:17:35 PDT
(In reply to comment #4)
> Given previous comment, should the PlatformOnly keyword be added to this bug?

I filed Bug 9165 to cover the ToT (tip-of-tree) WebKit issue, so I'm adding PlatformOnly to this bug and changing Version back to 312.x.
Comment 6 Krishna 2006-05-30 10:24:26 PDT
TSW Error ID: ASHA-6J97FA
Comment 7 David Kilzer (:ddkilzer) 2006-06-06 12:06:28 PDT
This search results page for Expedia seems to do some user-agent sniffing.  This is HIGHLY SPECULATIVE, but the issue MIGHT be a server-side issue where the page might hang because it doesn't know what to output given the user agent string.  (Note that this is easily testable--just fake a user agent string to see the content change.)

I haven't completed testing on Bug 9165 yet (see Bug 9165 Comment #4), but it looks like if a WebKit-esque user agent string is sent, you will get the desired "&lt;!--c--&gt;" output on the page.

S60 Bug 9189 may also be related (or may cause similar problems to be exhibited as Bug 9165).
Comment 8 Sriram 2006-08-22 14:23:15 PDT
Created attachment 10171 [details]
Fix taken from Tiger branch (see comments)
Comment 9 Sriram 2006-08-22 14:46:28 PDT
Comment on attachment 10171 [details]
Fix taken from Tiger branch (see comments)

changeset_r14419 & changeset_r14187
Comment 10 Antti Koivisto 2006-08-29 14:32:44 PDT
Comment on attachment 10171 [details]
Fix taken from Tiger branch (see comments)

- documentElement optimization should be like in tot
- no need to change tokenizer constructor defaults, just change it where it is constructed
- check if parser change in tot needs to be brought in as well
Comment 11 Sriram 2006-08-29 20:48:57 PDT
Created attachment 10312 [details]
Made changes based on comments
Comment 12 Sriram 2006-08-29 20:51:51 PDT
Comment on attachment 10312 [details]
Made changes based on comments

Couldnt make the change for  HTMLParser::handleError method as it is not implemented in S60 codebase
Comment 13 Antti Koivisto 2006-08-30 14:41:33 PDT
Comment on attachment 10312 [details]
Made changes based on comments

r=me
Comment 14 zalan 2006-08-31 08:55:53 PDT
r16142
Comment 15 Krishna 2006-09-01 07:24:44 PDT
Bug 10674 blocks verification of this bug.
Comment 16 Krishna 2006-09-08 12:26:23 PDT
Verified and Closed.