Bug 9010 - REGRESSION: Inspector tree does not render at the correct size
Summary: REGRESSION: Inspector tree does not render at the correct size
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 9018
  Show dependency treegraph
 
Reported: 2006-05-19 18:49 PDT by Timothy Hatcher
Modified: 2006-07-31 11:19 PDT (History)
2 users (show)

See Also:


Attachments
Picture showing the problem (76.37 KB, image/png)
2006-05-19 18:49 PDT, Timothy Hatcher
no flags Details
Before bug 7604 landed (r14350) (69.73 KB, image/png)
2006-05-19 19:32 PDT, Timothy Hatcher
no flags Details
After bug 7604 landed (r14357) (66.30 KB, image/png)
2006-05-19 19:33 PDT, Timothy Hatcher
no flags Details
Simple test case that shows the regression (564 bytes, text/html)
2006-05-19 19:54 PDT, Timothy Hatcher
no flags Details
patch (4.37 KB, patch)
2006-05-20 15:51 PDT, Sam Weinig
hyatt: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2006-05-19 18:49:12 PDT
THe tree outline view does not stay contained in the top area or resize when you drag the divider.
Comment 1 Timothy Hatcher 2006-05-19 18:49:45 PDT
Created attachment 8423 [details]
Picture showing the problem
Comment 2 Timothy Hatcher 2006-05-19 19:31:47 PDT
This regression was caused by bug 7604. See the attached pictures of before and after.
Comment 3 Timothy Hatcher 2006-05-19 19:32:44 PDT
Created attachment 8424 [details]
Before bug 7604 landed (r14350)
Comment 4 Timothy Hatcher 2006-05-19 19:33:31 PDT
Created attachment 8425 [details]
After bug 7604 landed (r14357)
Comment 5 Timothy Hatcher 2006-05-19 19:54:52 PDT
Created attachment 8426 [details]
Simple test case that shows the regression

This test shows the regression. This is a regression from shipping Safari since r14350.

This only happens if the element "c" (the red block) is an object, img or other replaced element. Make element c a div and it works.

Element "c" specifies height of 100%, but it is a child of element "b" that has no specified height (auto). Element "a" has a height and that is the height element "c" is reflects with 100%.
Comment 6 Sam Weinig 2006-05-20 15:51:23 PDT
Created attachment 8439 [details]
patch

This patch does fix the issue, but I think that a more thought out fix might serve quite a bit better.  I also was not able to test this in the test suite so if that reason alone it should not be landed.  I would really appreciate any comments.
Comment 7 Dave Hyatt 2006-05-23 02:47:06 PDT
I don't think a new method is necessary.  I'd just do it inline.  I'm really curious what caused the regression though.  What change broke the test?
Comment 8 Alice Liu 2006-06-06 09:42:20 PDT
<rdar://problem/4575241>
Comment 9 Timothy Hatcher 2006-07-31 11:19:41 PDT
This is no longer broken, something else must have fixed this.