Bug 8983 – Autogenerate another 22 HTML classes

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anders Carlsson]

Patch coming up

[Anders Carlsson]

Created attachment 8398 [details]
Patch

I've been very careful not to remove any existing attributes/functions while porting.

[Eric Seidel (no email)]

Comment on attachment 8398 [details]
Patch

In general this looks great.

We shoudl make sure to land a test for every place in which we differ from the spec.  In autogenerating other classes I found that the dom 2 html spec changed the type of several attributes, which might be what you're noticing in these as well.

Second, you also should fix the style Document *doc instead of Document* doc, in HTMLBodyElement.cpp

With those additional test cases to cover the places where we differ from the spec, you're good to land.

[Anders Carlsson]

I did not want to change too much of the implementation logic, so I filed http://bugzilla.opendarwin.org/show_bug.cgi?id=8992 to keep track of the three attributes where we differ.

[Darin Adler]

Anders landed this. Version 14483.

Anders, it looks like the XMLHttpRequest layout tests are now failing. We need to fix that. And perhaps the Windows build as well.