Bug 8983 - Autogenerate another 22 HTML classes
Summary: Autogenerate another 22 HTML classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-18 15:39 PDT by Anders Carlsson
Modified: 2006-05-19 08:48 PDT (History)
0 users

See Also:

Attachments
Patch (143.11 KB, patch)
2006-05-18 15:45 PDT, Anders Carlsson 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2006-05-18 15:39:48 PDT 
Patch coming up
Comment 1 Anders Carlsson 2006-05-18 15:45:44 PDT 
Created attachment 8398 [details]
Patch

I've been very careful not to remove any existing attributes/functions while porting.
Comment 2 Eric Seidel (no email) 2006-05-18 16:14:29 PDT 
Comment on attachment 8398 [details]
Patch

In general this looks great.

We shoudl make sure to land a test for every place in which we differ from the spec.  In autogenerating other classes I found that the dom 2 html spec changed the type of several attributes, which might be what you're noticing in these as well.

Second, you also should fix the style Document *doc instead of Document* doc, in HTMLBodyElement.cpp

With those additional test cases to cover the places where we differ from the spec, you're good to land.
Comment 3 Anders Carlsson 2006-05-19 03:50:37 PDT 
I did not want to change too much of the implementation logic, so I filed http://bugzilla.opendarwin.org/show_bug.cgi?id=8992 to keep track of the three attributes where we differ.
Comment 4 Darin Adler 2006-05-19 08:48:36 PDT 
Anders landed this. Version 14483.

Anders, it looks like the XMLHttpRequest layout tests are now failing. We need to fix that. And perhaps the Windows build as well.