RESOLVED FIXED 8951
REGRESSION: AtomicString hash corrupted by high-bit Latin-1 
https://bugs.webkit.org/show_bug.cgi?id=8951
Summary REGRESSION: AtomicString hash corrupted by high-bit Latin-1
mitz
Reported 2006-05-16 23:12:52 PDT
CStringTranslator::equal() is broken for high-bit C strings, which leads to duplicate entries in the AtomicString hash map.
Attachments
Patch (3.32 KB, patch)
2006-05-16 23:15 PDT, mitz 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-05-16 23:15:37 PDT
Created attachment 8361 [details] Patch The test is for the fix in StringImpl.cpp. The hash map corruption can't be tested reliably in a normal debug build. I don't know if the corruption happens in shipping WebKit, but the test succeeds, so at least part of this bug is a regression.
Maciej Stachowiak
Comment 2 2006-05-16 23:31:46 PDT
Comment on attachment 8361 [details] Patch r=me
Darin Adler
Comment 3 2006-05-16 23:42:16 PDT
I broke this when I converted from QChar to UChar!
Darin Adler
Comment 4 2006-05-16 23:46:39 PDT
Committed revision 14434.
Note You need to log in before you can comment on or make changes to this bug.