Bug 8940 - remove extra copy of image code
Summary: remove extra copy of image code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-16 09:26 PDT by Darin Adler
Modified: 2006-05-16 15:23 PDT (History)
3 users (show)

See Also:

Attachments
patch to remove code from both WebKit and WebCore (159.70 KB, patch)
2006-05-16 10:01 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2006-05-16 09:26:28 PDT 
I started removing the extra image code. For all I know Anders already started doing this, but I couldn't help myself!
Comment 1 Anders Carlsson 2006-05-16 09:56:42 PDT 
How far along are you with this? I'm working on it right now and I'm almost finished (I think)
Comment 2 Darin Adler 2006-05-16 10:01:58 PDT 
Created attachment 8351 [details]
patch to remove code from both WebKit and WebCore
Comment 3 Anders Carlsson 2006-05-16 10:12:31 PDT 
Comment on attachment 8351 [details]
patch to remove code from both WebKit and WebCore

Looks like the way I did it, except for one thing:

I used ForElement in _web_declareAndWriteDragImageElement and _web_dragImageElement, as per John's suggestion.

Feel free to change that if you want.
Comment 4 Darin Adler 2006-05-16 11:40:42 PDT 
Darn. I should have waiting. Didn't realize you were so far along!
Comment 5 Darin Adler 2006-05-16 13:12:42 PDT 
(In reply to comment #3)
> I used ForElement in _web_declareAndWriteDragImageElement and
> _web_dragImageElement, as per John's suggestion.

OK. I'll do that.
Comment 6 Darin Adler 2006-05-16 15:22:26 PDT 
Committed revision 14420.
Comment 7 Darin Adler 2006-05-16 15:23:33 PDT 
Committed revision 14421.